From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.parhasard.net (mail.parhasard.net [88.198.122.198]) by sourceware.org (Postfix) with ESMTP id 14D0E3858C27 for ; Thu, 9 Dec 2021 08:39:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14D0E3858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=parhasard.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=parhasard.net Received: by mail.parhasard.net (Postfix, from userid 1000) id 1EB924A4ADA; Thu, 9 Dec 2021 09:39:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=parhasard.net; s=mail; t=1639039153; bh=x+HvR5XY7S7GQ0k5+JaqttMHjinGih4Gu5KmgJ1NzJE=; h=From:Date:To:Cc:Subject:In-Reply-To:References:From; b=VEm/eAR8XMgNUI6vXFiNcln9+ffO/mLXgbvGgzH0EgQHiY2F1A1iCppgd3pbxyqLM qwKi23scxnUsb6j8b8X2dOFkuUlP+8W+ApEFw6DYrik0rOt/2K8qtVQTm1na42V5j9 zJ+svp1Erp1vaDkUWME+lQ4on+WVMItHEgEFF3Io= From: Aidan Kehoe MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <61b1.c0b0.e1670.14b2@parhasard.net> Date: Thu, 9 Dec 2021 08:39:12 +0000 To: "Henry S. Thompson" Cc: Ken Brown , cygwin@cygwin.com Subject: XEmacs versus Cygwin 3.3 (was Re: Another pipe-related problem?) In-Reply-To: References: <05c4180e-396b-4af3-ac0c-2ab8125df17e@cornell.edu> <0971ace1-5ee8-bdcc-5fd9-4551b294ebf8@cornell.edu> <75197fd0-d5da-3236-a7df-b8ffc3f67da7@cornell.edu> <4b937b32-e348-19d2-2406-c55fa12e20a3@cornell.edu> <83df50b8-5c0c-41b9-1e9e-4ea6bfa3d69f@cornell.edu> X-Mailer: VM 8.2.0b under 21.5 (beta34) "kale" cca3709a62ad XEmacs Lucid (x86_64-unknown-linux) X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 08:39:20 -0000 Ar an t-ochtú lá de mí na Nollaig, scríobh Henry S. Thompson: > [...] > #define STRIDE sizeof (STRIDE_TYPE) > > Ken/Aidan, is it possible that the last line interacts badly with some > (stale?) #ifdef code at lines 177 and 190 in sysdep.c [attached for > Ken's benefit] in a way that only the new pipe code is sensitive to? Yes, it’s 100% possible. Until my text.h change, the #if defined (STRIDE) conditional only applied with some 1980s m68k machines, with AIX, and with pfa (which is hard to pin down, but is likely a 1980s Unix implementation on IBM hardware). Now it always applies for non-WIN32-NATIVE builds, and I’m surprised we haven’t had issues with it on other platforms. On looking a bit closer we currently set the FD to be non-blocking twice on Cygwin, which is asking for trouble. There’s no need for a STRIDE #define anyway, sizeof (STRIDE_TYPE) is sufficiently general already. I’ll commit a change removing the STRIDE #define from my code later today, and will probably do a bit of unifdef(1) work for similar ancient systems too. Thanks for your careful work on this, Henry! -- ‘As I sat looking up at the Guinness ad, I could never figure out / How your man stayed up on the surfboard after forty pints of stout’ (C. Moore)