From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3883 invoked by alias); 12 Jan 2019 11:39:42 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 3875 invoked by uid 89); 12 Jan 2019 11:39:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=blush, HContent-Transfer-Encoding:8bit X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (217.72.192.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Jan 2019 11:39:40 +0000 Received: from [192.168.178.45] ([95.91.209.148]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MqJuP-1h4RA11bD1-00nQpd for ; Sat, 12 Jan 2019 12:39:38 +0100 Subject: Re: iswcntrl() regression To: cygwin@cygwin.com References: <24530320.43gEWRNkUz@omega> <20181219133711.GJ28727@calimero.vinschen.de> <6550638.IhVCuUnqCC@omega> <20190106202109.GD4430@calimero.vinschen.de> <8758e963-7f32-a3f4-4d66-ce0d0c5f831e@towo.net> <18c44153-0e69-80f9-81c7-544009f83b8c@towo.net> <20190111091634.GS593@calimero.vinschen.de> From: Thomas Wolff Message-ID: <625240da-c6b1-05e1-35b2-f39021287fcb@towo.net> Date: Sat, 12 Jan 2019 11:39:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190111091634.GS593@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00086.txt.bz2 Am 11.01.2019 um 10:16 schrieb Corinna Vinschen: > On Jan 11 02:07, Thomas Wolff wrote: >> Am 06.01.2019 um 23:39 schrieb Thomas Wolff: >>> Am 06.01.2019 um 21:21 schrieb Corinna Vinschen: >>>> On Dec 19 21:57, Bruno Haible wrote: >>>>> Hello Thomas, >>>>> >>>>> Oops 1: I forgot to add the reference to POSIX: >>>>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswcntrl.html >>>>> >>>>> Oops 2: >>>>> The relevant expression is iswcntrl (WEOF), not iswcntrl (EOF). >>>>> [...] >>>> Thomas, any input?  Are you going to provide patches? >>> Well, yes, now I'm assuming that this is the only WEOF special case and >>> I'll look after it this week. >>> Thomas >> The fix should be as attached. >> However, I don't seem to be able to produce a git format patch; when I `git >> format-patch -1` (after `git pull` and modifying only the affected file) it >> produces a patch file >> >> Subject: [PATCH] Cygwin: try_to_bin: don't check recycler filename all the >> time >> ... >> Signed-off-by: Corinna Vinschen >> --- >>  winsup/cygwin/syscalls.cc | 71 +++++++++++++++++++++------------------ >> ... >> >> which is weird. > No, it's not. Only commited patches are printed by `git format-patch', > so, after `git pull' you have to *commit* your patches, write a nice > description (with a blank line after the first line to separate the > commit message into synopsis and body). *Then* call `git format-patch -1'. Blush; forgot about the workflow... > Apart from that, please send your patch to the newlib mailing list. Done. Also sent a Unicode 11.0 update patch. Thomas -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple