public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: The Cygwin Mailing List <cygwin@cygwin.com>
Subject: Re: Updated [test]: bash-4.4.5-1
Date: Fri, 16 Dec 2016 19:27:00 -0000	[thread overview]
Message-ID: <669c7f78-0f30-2e7b-4f5b-e9b2ffbc2da0@redhat.com> (raw)
In-Reply-To: <47a95317-4845-16fb-21db-3befaa8b94be@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1164 bytes --]

On 12/13/2016 04:30 PM, Eric Blake (cygwin) wrote:
> A new release of bash, 4.4.5-1, has been uploaded and will soon reach a
> mirror near you.  For now it is marked experimental, and requires the
> use of experimental readline7-7.0.1-1 (leaving bash 4.3.48-8 as the
> current version).  But if no major complaints are raised during testing,
> this will be promoted to current in a few days.

In testing this, I've noticed that the cygport install sub-command is
rather noisy on some binaries, due to its use of undefined behavior in
$() that causes the new bash to emit a warning:

/usr/share/cygport/lib/src_postinst.cygpart: line 970: warning: command
substitution: ignored null byte in input
/usr/share/cygport/lib/src_postinst.cygpart: line 977: warning: command
substitution: ignored null byte in input

A simple solution would be:

- case $(tail -c 12 "${exe}") in
+ case $(tail -c 12 "${exe}" | tr -d \\0) in

I'll wait to promote bash 4.4 to current until after I know if it is
worth waiting for a speedy cygport update.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

           reply	other threads:[~2016-12-16 19:27 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <47a95317-4845-16fb-21db-3befaa8b94be@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=669c7f78-0f30-2e7b-4f5b-e9b2ffbc2da0@redhat.com \
    --to=eblake@redhat.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).