From: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.7
Date: Fri, 08 Feb 2019 14:43:00 -0000 [thread overview]
Message-ID: <6b182191-b235-fcbb-5b25-66243950043c@ssi-schaefer.com> (raw)
In-Reply-To: <20190208132807.GP13951@calimero.vinschen.de>
On 2/8/19 2:28 PM, Corinna Vinschen wrote:
> On Feb 8 14:06, Corinna Vinschen wrote:
>> On Feb 8 13:52, Michael Haubenwallner wrote:
>>> On 2/8/19 1:23 PM, Corinna Vinschen wrote:
>>>> On Feb 8 13:21, Corinna Vinschen wrote:
>>>>> On Feb 8 12:51, Michael Haubenwallner wrote:
>>>>>>
>>>>>> For now it seems like there's an inconsistency with PIDs:
>>>>>> A first process PID 100, receives PID 101 from spawn(),
>>>>>> but in the new process getpid() returns 102:
>>>>>>
>>>>>> $ ./dospawn /bin/bash -c 'echo $$'
>>>>>> 12625
>>>>>> waitpid: pid 12624 status 0x0
>>>>>
>>>>> Oh, hmm. If you call spawnve, rather than execve, a new child pid
>>>>> is generated in spawnve, rather than just keeping the callers pid.
>>>>>
>>>>> However, apparently the child invents its own pid in pinfo::thisproc
>>>>> after being spawned. But actually this should only occur for forked
>>>>> processes aore processes started from non-Cygwin parents.
>>>>
>>>> Does that help, by any chance:
>>>> [nope]
>>>
>>> How should the child be informed at all about the new cygpid value generated in
>>> parent's child_info_spawn::worker() ?
>>
>> I just realized this myself. The old method creating Cygwin pids just
>> fetched the pid from GetCurrentProcessId(), which was right for spawned
>> (but not execed) processes. For the new pid we might have to give this
>> to the child via child_info_spawn.
>
> This works for me, can you test this, too, please?
Looks good to me as well, I'm going to start my hours running use case now.
>
> I pushed your forkable branch to master, btw. Would you mind to do the
> honors in the ;rease notes at cygwin/release/3.0 and doc/new-features.xml?
Ok, just preparing the tests first. Thanks a lot!
/haubi/
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2019-02-08 14:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 15:24 Corinna Vinschen
2019-02-07 16:14 ` Michael Haubenwallner
2019-02-07 18:27 ` Corinna Vinschen
2019-02-08 6:46 ` Michael Haubenwallner
2019-02-08 11:32 ` Corinna Vinschen
2019-02-08 11:51 ` Michael Haubenwallner
2019-02-08 12:21 ` Corinna Vinschen
2019-02-08 12:23 ` Corinna Vinschen
2019-02-08 12:52 ` Michael Haubenwallner
2019-02-08 13:06 ` Corinna Vinschen
2019-02-08 13:28 ` Corinna Vinschen
2019-02-08 14:43 ` Michael Haubenwallner [this message]
2019-02-08 14:49 ` Corinna Vinschen
2019-02-08 16:18 ` Michael Haubenwallner
2019-02-08 16:50 ` Corinna Vinschen
2019-02-08 16:35 ` Michael Haubenwallner
2019-02-08 16:58 ` Corinna Vinschen
2019-02-08 17:00 ` Corinna Vinschen
2019-02-11 11:50 ` Michael Haubenwallner
2019-02-11 13:33 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b182191-b235-fcbb-5b25-66243950043c@ssi-schaefer.com \
--to=michael.haubenwallner@ssi-schaefer.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).