From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m0.truegem.net (m0.truegem.net [69.55.228.47]) by sourceware.org (Postfix) with ESMTPS id 13F413858C32 for ; Tue, 2 Apr 2024 08:57:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13F413858C32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maxrnd.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maxrnd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13F413858C32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=69.55.228.47 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712048251; cv=none; b=NKJdaeUe1sPS3yy7aSKDuRSx7Y0WqOrxw9yAeSasKlcl2MDWzlpPJB5OQ6cFhiUcWm6/kVj2jNoyjBHNNVTAOX8HxuhbVON/VhWVAqeLHImCDf4tjmmZs/w8zv+O0OxbWm1gD6MnIFUErdWmoSGSNeQZOD3eLn457WdSJtq37ps= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712048251; c=relaxed/simple; bh=NriCXiwuQuNzNBFxXUzxW1ZliSrndDL7HAhzrn9SrIw=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=qvSVuwTI2L0pdPJmejdJof1H0EXZ3tWXbEv4RHLiM9tb6emX7Tj8gPzuFQqx2Brgfco/iy8NwnSNH+FU3E10rLrVANT4WBvegTZE6XfahbqpvMheff1eVgvncKDKWSRwHrA0z6o0QacwdHqM1eHQz0a0XQzNTfZiA0vcIU9AP0M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: (from daemon@localhost) by m0.truegem.net (8.12.11/8.12.11) id 43293QK2049122 for ; Tue, 2 Apr 2024 02:03:26 -0700 (PDT) (envelope-from mark@maxrnd.com) Received: from 50-1-245-188.fiber.dynamic.sonic.net(50.1.245.188), claiming to be "[192.168.4.101]" via SMTP by m0.truegem.net, id smtpdByztWa; Tue Apr 2 01:03:18 2024 Message-ID: <72594c25-f142-42f0-b4cd-e2650e8044db@maxrnd.com> Date: Tue, 2 Apr 2024 01:57:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: util-linux-2.39.3-1: libblkid returns invalid physical_sector_size To: cygwin@cygwin.com References: <0fb74540-3878-206d-b623-15437fe79b01@t-online.de> Content-Language: en-US From: Mark Geisert In-Reply-To: <0fb74540-3878-206d-b623-15437fe79b01@t-online.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Christian, On 3/31/2024 1:11 AM, Christian Franke via Cygwin wrote: > Testcase: > > # cygcheck -f /sbin/fdisk.exe > util-linux-2.39.3-1 > > # /sbin/fdisk.exe -l /dev/sdd > Disk /dev/sdd: 465.76 GiB, 500107862016 bytes, 976773168 sectors > Units: sectors of 1 * 512 = 512 bytes > Sector size (logical/physical): 512 bytes / 34359738880 bytes > I/O size (minimum/optimal): 34359738880 bytes / 34359738880 bytes [...valuable investigation and patch suggestion elided...] Your suggested patch looks fine to me. I have added it to the patch deck for a new util-linux 2.39.3-2, which has just been uploaded. The patch allows fdisk.exe to report the three correct values in my limited testing. Thanks for the report and the patch! ..mark