public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: bug-gnulib@gnu.org
Cc: cygwin@cygwin.com
Subject: Re: [PATCH] localename: Port to cygwin 2.6.
Date: Fri, 20 Jan 2017 02:47:00 -0000	[thread overview]
Message-ID: <737a9fb1-0598-c6eb-e720-6d7b20f196b4@redhat.com> (raw)
In-Reply-To: <20170119203057.13986-1-eblake@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1191 bytes --]

On 01/19/2017 02:30 PM, Eric Blake wrote:
> Cygwin 2.6 introduced uselocale() and thread-local locales in general,
> but lacks any way to get at the name of each portion of a locale_t
> object short of peeking behind an opaque object.  I'm proposing a
> patch to add NL_LOCALE_NAME() to Cygwin patterned after glibc's
> extension of the same name, but we might as well work around it
> in the meantime.
> 
> * lib/localename.c (gl_locale_name_thread_unsafe): Add clause for
> Cygwin.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> I won't actually push this to gnulib until I've sent the corresponding
> newlib/Cygwin patch to add NL_LOCALE_NAME, and tweaked the commit
> messages of both patches to refer to the appropriate mailing list
> threads.  But this was enough to get test-localename passing on
> Cygwin again.

> +#   ifdef NL_LOCALE_NAME
> +        return nl_langinfo_l (NL_LOCALE_NAME (category), thread_locale);

Here's the proposed cygwin patch for adding NL_LOCALE_NAME():
https://sourceware.org/ml/newlib/2017/msg00071.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2017-01-20  2:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 20:31 Eric Blake
2017-01-20  2:47 ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=737a9fb1-0598-c6eb-e720-6d7b20f196b4@redhat.com \
    --to=eblake@redhat.com \
    --cc=bug-gnulib@gnu.org \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).