From: Marco Atzeri <marco.atzeri@gmail.com>
To: cygwin@cygwin.com
Cc: emilyw@yahoo.com
Subject: Re: ImageMagick maybe broken by libgs9 upgrade
Date: Wed, 24 Jun 2020 20:21:56 +0200 [thread overview]
Message-ID: <7577f575-9a66-bdb6-1cb9-30a6f9e305ad@gmail.com> (raw)
In-Reply-To: <094cb004-e88e-4b4c-89ce-e8c8791c3f9e@cornell.edu>
On 24.06.2020 12:24, Ken Brown via Cygwin wrote:
> On 6/24/2020 1:30 AM, Marco Atzeri via Cygwin wrote:
>> On 23.06.2020 23:02, Marco Atzeri wrote:
>>> On 23.06.2020 22:56, Ken Brown via Cygwin wrote:
>>>>
>>>> I think I've found the problem, although it will take patching and
>>>> rebuilding ImageMagick (which I haven't done) to confirm that I'm
>>>> right.
>>>>
>>>> In the ImageMagick source file coders/ps.c:237, there's a call to
>>>> ghost_info->new_instance, a.k.a. gsapi_new_instance (see line 214).
>>>> The documentation of the latter in the ghostscript sources
>>>> (psi/iapi.c:57) says that the first argument pinstance should
>>>> satisfy *pinstance == NULL in the first call to that function.
>>>>
>>>> But *pinstance in this call is the variable 'interpreter', defined
>>>> without initialization in ps.c:191. As a result, **pinstance
>>>> contains garbage, and the program eventually crashes when it tries
>>>> to dereference a garbage pointer.
>>>>
>>>> The fix, if I'm right, is to initialize interpreter to NULL in
>>>> ps.c:191.
>>>>
>>>> Ken
>>>
>>> Noted.
>>>
>>> Regards
>>> MArco
>>>
>>
>> a test ImageMagick-6.9.10.11-3 is going up.
>> Let me know if it solves the problem
>
> That fixes it for my .eps file. I didn't think of it before, but a
> similar patch to coders/pdf.c:201 will be needed for .pdf files. I
> won't be able to test that because I haven't found a .pdf file that
> exhibits the problem.
>
> Ken
>
test version 6.9.10.11-4 is going up.
If Emily tests with her pdf files, it will be nice
Regards
Marco
next prev parent reply other threads:[~2020-06-24 18:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <241354771.1752406.1592876221936.ref@mail.yahoo.com>
2020-06-23 1:37 ` Emily
2020-06-23 11:27 ` Ken Brown
2020-06-23 12:15 ` Ken Brown
2020-06-23 13:03 ` Markus Hoenicka
2020-06-23 16:56 ` Marco Atzeri
2020-06-23 18:18 ` Ken Brown
2020-06-23 20:56 ` Ken Brown
2020-06-23 21:02 ` Marco Atzeri
2020-06-24 5:30 ` Marco Atzeri
2020-06-24 10:24 ` Ken Brown
2020-06-24 18:21 ` Marco Atzeri [this message]
2020-06-24 18:46 ` Emily
2020-06-24 19:03 ` Ken Brown
2020-06-24 19:04 ` Marco Atzeri
[not found] ` <1033343864.3079093.1593118308854@mail.yahoo.com>
2020-06-26 3:38 ` Marco Atzeri
2020-06-26 4:00 ` Marco Atzeri
2020-06-26 5:46 ` Emily
2020-06-26 18:10 ` marco atzeri
2020-06-23 13:05 ` Lemures Lemniscati
2020-06-23 19:32 ` Emily
2020-06-23 19:41 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7577f575-9a66-bdb6-1cb9-30a6f9e305ad@gmail.com \
--to=marco.atzeri@gmail.com \
--cc=cygwin@cygwin.com \
--cc=emilyw@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).