From: Ken Brown <kbrown@cornell.edu>
To: cygwin@cygwin.com
Subject: Re: posix_spawn issues on i686
Date: Wed, 12 Jan 2022 11:32:39 -0500 [thread overview]
Message-ID: <77b87e94-b945-baf0-af8a-d88a8fc69142@cornell.edu> (raw)
In-Reply-To: <Yd6wZ0r7EXOGcQfQ@calimero.vinschen.de>
On 1/12/2022 5:41 AM, Corinna Vinschen wrote:
> On Jan 11 16:08, Ken Brown wrote:
>> I don't have time to check this carefully, but it looks to me like the
>> problem is that process_spawnattr calls setegid and seteuid instead of
>> setegid32 and seteuid32. This causes truncation of the gid and uid.
>
> You're right. Additionally the calls to getgid and getuid have to use
> the internal getgid32 and getuid32 functions.
I'll be glad when this 32-bit cruft can be removed. It is *very* confusing to
read the code and see a function called getuid that is really only used by old
applications, except when it's accidentally used internally. I introduced a
32-bit-only bug a couple years ago because of a similar confusion between fstat
and fstat64.
Ken
next prev parent reply other threads:[~2022-01-12 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 19:38 Jeremy Drake
2022-01-11 10:07 ` Corinna Vinschen
2022-01-11 18:45 ` Jeremy Drake
2022-01-11 21:08 ` Ken Brown
2022-01-12 10:41 ` Corinna Vinschen
2022-01-12 11:24 ` Corinna Vinschen
2022-01-12 16:32 ` Ken Brown [this message]
2022-01-12 21:25 ` Jeremy Drake
2022-01-14 9:15 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77b87e94-b945-baf0-af8a-d88a8fc69142@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).