public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.6.0-0.11
Date: Thu, 25 Aug 2016 14:46:00 -0000	[thread overview]
Message-ID: <77c3c26e-c52a-bd5a-9069-660d6999e1a5@SystematicSw.ab.ca> (raw)
In-Reply-To: <20160825080700.GD9783@calimero.vinschen.de>

On 2016-08-25 02:07, Corinna Vinschen wrote:
> On Aug 24 14:47, Brian Inglis wrote:
>>
>> On 2016-08-24 12:29, Corinna Vinschen wrote:
>>> On Aug 24 11:30, Brian Inglis wrote:
>>>> On 2016-08-24 02:22, Corinna Vinschen wrote:
>>>>> On Aug 23 23:36, Brian Inglis wrote:
>>>>>> On 2016-08-23 22:15, Brian Inglis wrote:
>>>>>>> On 2016-08-23 10:11, Corinna Vinschen wrote:
>>>>>>>> On Aug 23 07:27, Brian Inglis wrote:
>>>>>>>>> Compared lists of locale_t headers and functions for POSIX, Cygwin,
>>>>>>>>> and glibc, attached below for comparison, and found:
>>>>>>>>> * missed string.h(strerror_l) on my first check;
>>>>>>>>>    not sure if you can implement that easily on Windows?
>>>>>>>>> * GNU also supports wchar.h(wcsftime_l) and time.h(strptime_l);
>>>>>>>>> * GNU also defines string.h(str[n]casecmp_l) functions as an extension,
>>>>>>>>>    as well as in POSIX specified strings.h.
>>>>>>>> I just applied a couple of patches to add the missing strerror_l,
>>>>>>>> strptime_l and wcsftime_l.  I also added the missing str[n]casecmp_l
>>>>>>>> prototypes to strings.h.  I'll create a new test release in a bit.
>>>>>>> GNU duplicates the POSIX strings.h(str[n]casecmp_l) in string.h also.
>>>>>> i.e. str[n]casecmp_l should be defined under #if __POSIX_VISIBLE >= 200809
>>>>>> but not defined under #ifdef __GNU_VISIBLE in string*s*.h,
>>>>>> and defined under #ifdef __GNU_VISIBLE but not defined under
>>>>>> #if __POSIX_VISIBLE >= 200809 in *string*.h;
>>>>>> strerror_l should be under #if __POSIX_VISIBLE  >= 200809 in *string*.h,
>>>>>> or its #includes.
>>>>> They were already declared in string,h.
>>>> Sorry for the poor explanation, but what I was failing to say clearly
>>>> was that:
>>>> * there does not appear to be any strerror_l declaration in string.h
>>>> [...]
>>>> and that str[n]casecmp_l conditionals __GNU_VISIBLE and __POSIX_VISIBLE >= 200809
>>>> appear to be flipped around between string.h and strings.h declarations in:
>>>> [...]
>>> Care to send patches to the newlib list?  Patches (git format-patch)
>>> rule over descriptions alone :}
>>
>> Knew there were good reasons I avoided git for a decade!
>> See https://en.wikipedia.org/wiki/Git_(slang)
>> Developers never heard of KISS, unlike you folks at Cygwin ;^> and the folks at hg.
>>
>> git show attached in case my patch email does not get thru or is scrambled some way,
>> so it does not apply with git am, after my screwing around with git and mailx.
>
> It applied, but I had to make a few changes, see my reply to the
> newlib list.  What you shouldn't do is to put the entire log
> message into one line.  The first line of your log message becomes
> the subject of your patch email.  Keep it short and add the
> rest of the log message starting in line 3.  Line 2 stays clear,
> it separates the subject from the body.

Seems like mailx -t does not handle multi-line subjects and .sig
properly: may have some digging to do there. Other mail clients
do not support plain text attachments: I've used most in Cygwin,
and built mailx from s-nail based on Heirloom, as Heirloom mailx
just failed to email  from Cygwin.
  
> You don't need mailx, btw.  After you created your patch with
> `git format-patch', you can send it with `git send-email' :)

Looked for that, and everything there, but:

$ uname -srvmo
CYGWIN_NT-10.0 2.5.2(0.297/5/3) 2016-06-23 14:29 x86_64 Cygwin
$ git --version
git version 2.8.3
$ man git | fgrep git-send-email
        git-send-email(1)
$ git help send-email
No manual entry for gitsend-email
$ git help git-send-email
No manual entry for git-send-email
$ man git-send-email
No manual entry for git-send-email
$ ls -1 /usr/share/man/man1/git* | wc -l
143
$ ls /usr/share/man/man1/git-send-email*
ls: cannot access '/usr/share/man/man1/git-send-email*': No such file or directory
$ git send-email
git: 'send-email' is not a git command. See 'git --help'.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  reply	other threads:[~2016-08-25 14:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-20 22:09 Corinna Vinschen
2016-08-23 13:41 ` Brian Inglis
2016-08-23 16:20   ` Corinna Vinschen
2016-08-24  8:22     ` Brian Inglis
2016-08-24  8:28       ` Brian Inglis
2016-08-24  8:31         ` Corinna Vinschen
2016-08-24 18:29           ` Brian Inglis
2016-08-24 18:53             ` Corinna Vinschen
2016-08-25  7:30               ` Brian Inglis
2016-08-25 10:03                 ` Corinna Vinschen
2016-08-25 14:46                   ` Brian Inglis [this message]
2016-08-25 14:48                     ` Eliot Moss
2016-08-25 15:01                     ` Corinna Vinschen
2016-08-25 15:29                       ` Brian Inglis
2016-08-25 22:23                       ` Eliot Moss
2016-08-25 15:21                     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77c3c26e-c52a-bd5a-9069-660d6999e1a5@SystematicSw.ab.ca \
    --to=brian.inglis@systematicsw.ab.ca \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).