From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25969 invoked by alias); 7 Nov 2018 21:14:50 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 25955 invoked by uid 89); 7 Nov 2018 21:14:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=tarxz, pvr, debuginfo-$, a3997ae7ac X-HELO: vsmx009.vodafonemail.xion.oxcs.net Received: from vsmx009.vodafonemail.xion.oxcs.net (HELO vsmx009.vodafonemail.xion.oxcs.net) (153.92.174.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 21:14:47 +0000 Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id D4D86C00FE for ; Wed, 7 Nov 2018 21:14:45 +0000 (UTC) Received: from Gertrud (unknown [91.47.63.38]) by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id A4EA2300064 for ; Wed, 7 Nov 2018 21:14:43 +0000 (UTC) From: Achim Gratz To: cygwin@cygwin.com Subject: Re: cygport fails with package starting with number References: <703d2702-0407-82fa-3a84-237bc913cd41@gmail.com> <878t24d4qd.fsf@Rainer.invalid> <35e00f32-4e09-34d9-d1f6-34544a92bd2e@SystematicSw.ab.ca> Date: Wed, 07 Nov 2018 21:14:00 -0000 In-Reply-To: <35e00f32-4e09-34d9-d1f6-34544a92bd2e@SystematicSw.ab.ca> (Brian Inglis's message of "Wed, 7 Nov 2018 14:02:04 -0700") Message-ID: <87sh0cbnel.fsf@Rainer.invalid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00076.txt.bz2 Brian Inglis writes: > On 2018-11-07 13:15, Achim Gratz wrote: >> Marco Atzeri writes: >>> It seems that the behaviour of cygport is changed recently >>> and rebuilding the 4ti2 package fails on the name 4ti2. >> Introduced by a3997ae7ac, which constructs a variable whose name starts >> with the package name. However, a leading number does not result in a >> valid identifier. So if such package names must be supported then the >> substitution made earlier (replacing invalid characters from the name by >> an underscore) also needs to handle that particular case. So something >> like >> local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS; >> + dbg_contents_var=${dbg_contents_var/#[0-9]/_} >> __step "${PN}-debuginfo-${PVR}.tar.xz"; >> in lib/pkg_pkg.cygpart should fix it. > > or just prefix var name with "_": > > [ -d ${autoloaddir} ] || autoloaddir= > - local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS; > + local dbg_contents_var=_${PN//[-+\.]/_}_debuginfo_CONTENTS; That would run against the naming convention cygport assumes and thus break all cygport files that make use of them (which probably are just a a handful, but the breakage is easy enough to avoid). Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple