From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19372 invoked by alias); 20 May 2016 05:46:14 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 19356 invoked by uid 89); 20 May 2016 05:46:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_COUK,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:sk:smtp-ou, Hx-spam-relays-external:sk:smtp-ou, H*RU:sk:smtp-ou, H*Ad:D*co.uk X-HELO: smtp-out-3.tiscali.co.uk Received: from smtp-out-3.tiscali.co.uk (HELO smtp-out-3.tiscali.co.uk) (62.24.135.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 May 2016 05:46:04 +0000 Received: from [192.168.1.3] ([79.68.194.81]) by smtp.talktalk.net with SMTP id 3dG4bacnDd8FZ3dG4beDEk; Fri, 20 May 2016 06:46:01 +0100 Subject: Re: Necessity for the assignment form To: cygwin@cygwin.com References: From: David Stacey Message-ID: <8af86ed5-e1cd-77f4-335b-d192ef3dfe6e@tiscali.co.uk> Date: Fri, 20 May 2016 05:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfKukQbta7g182SxINPT7iUu/i5EIZYszxvVhUNa3yEnKACn4wjbimnM01zmHUGG5ZbzlpWKnBhve7sa7cobtko001P5u8f9bg4McDIEJAPLn1BmkRi/N wJCmjPWIfMNx3anZFLvEDaZZDwjuryAAEX/oAfA3oi7ChNDoN1YDMzZ6 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00217.txt.bz2 On 20/05/16 01:44, KOBAYASHI Shinji wrote: > I found a bug and I am willing to submit a patch (under > winsup/cygwin). But before doing that, I was asked from my employer to > clarify some points.https://cygwin.com/contrib.html says that the > assignment form is required "if your change is going to be a > significant one in terms of the size of your code changes". So the > questions are: > > 1. Who is going to determine if the change is "a significant one"? > 2. In fact, my patch is just two lines of modifications, so I believe > that it is not "a significant one". Is it okay to send such a small > patch without the assignment form? For Cygwin, the boundary between trivial and substantial is usually taken as ten lines. A two-line patch would probably be accepted without an assignment form. Dave. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple