From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71422 invoked by alias); 14 Aug 2018 06:09:50 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 71414 invoked by uid 89); 14 Aug 2018 06:09:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=emailing, H*F:D*mail.com, H*Ad:D*mail.com, intend X-HELO: mout.gmx.com Received: from mout.gmx.com (HELO mout.gmx.com) (74.208.4.200) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Aug 2018 06:09:48 +0000 Received: from johndoe65534.mail.com ([85.28.70.154]) by mail.gmx.com (mrgmxus002 [74.208.5.15]) with ESMTPSA (Nemesis) id 0Lp3gI-1gLTxd1DYi-00exdK for ; Tue, 14 Aug 2018 08:09:45 +0200 Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.11.0-0.1 To: cygwin@cygwin.com References: <20180810114254.GA25560@calimero.vinschen.de> <57b3092a9b5027be5f14e59c305200bc@smtp-cloud8.xs4all.net> <71f1280d04f70e8b74cfce78ba5690d3@xs4all.nl> <9a902fe9715b173671599a2e32eca26d@xs4all.nl> From: john doe Message-ID: <8d94b72b-4be9-311a-ddc6-c43942234693@mail.com> Date: Tue, 14 Aug 2018 06:09:00 -0000 MIME-Version: 1.0 In-Reply-To: <9a902fe9715b173671599a2e32eca26d@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00165.txt.bz2 On 8/14/2018 12:26 AM, Houder wrote: > On 2018-08-14 00:16, Eric Blake wrote: >> On 08/13/2018 04:29 PM, Houder wrote: >> >>>> The modication would require changing: >>>> >>>> winsup/cygwin/fenv.cc (_feinitialise() ) >>>> winsup/cygwin/include/fenv.h (FE_ALL_EXCEPT) >>> >>> GRRR! The file encoding of fenv.h is "cp1252" because of 2 characters >>> in this >>> line: >>> >>>       Intel® 64 and IA-32 Architectures Software Developer’s Manuals: >>> >>> ... part of a comment at the beginning of the file. >>> >>> (the registered trademark sign (u00ae) is encoded as 0xae (cp1252), >>> while it >>>   would be: 0xc2 0xae, in utf-8, >>>   the right single quotation mark (u2019) is encoded as 0x92 >>> (cp1252), but in >>>   utf-8 it would be: 0xc2 0x80 0x98) >>> >>> I intend to convert the file encoding of fenv.h to utf-8. Is that a >>> "No-No" >>> or is it allowed? (I assume GIT will notice). >> >> In general, git doesn't care if you change a file's encoding - that's >> just another content change.  In practice, you may get weird effects >> when viewing that particular patch (as the patch is not well-formed in >> the new multibyte locale, and looks funky when displayed in the old >> locale), and emailing a patch may require care in telling git which >> encoding to use for the email; but that's cosmetic, and shouldn't >> matter in the long run.  Updating the code base to uniformly use UTF-8 >> seems reasonable to me. > > ... and emailing a patch may require care in telling git which encoding > to use for the email ... Huh, huh ????? > > Last time I used: > >  - git format-patch >  - git send-mail > > Am I safe here? > To better understand what has happened in the code cosmetic changes should be done in separate commits. - Code changes -- Will only change the code. - Cosmetic changes -- Will only change the cosmetic aspect of the code (encoding, spacing, indentation ...) In most cases you can simply do 'git send-email' and pass the options for 'git format-patch' at the end of the cmd: $ git send-email master --to=me@example.com --reroll-count 1 --rfc The options '--reroll-count, --rfc' are format-patch options. -- John Doe -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple