Re: setup 2.927 release candidate - please test

[Jon Turney <jon.turney@dronecode.org.uk>]

On 14/10/2023 15:04, Christian Franke via Cygwin wrote:
> Jon Turney via Cygwin wrote:
>>
>> A new setup release candidate is available at:
>>
>> ...
>> - Translation updates.
>>
>> - Add German and Polish translations (thanks to weblate contributors 
>> Markus, Ettore Atalan, Luis Mengel and WaldiS)
>>
>> Some small adjustments have been made to the layout of the dialog 
>> templates to accommodate places where the translation is longer. 
>> Please report it if there are any spots I've missed where the text 
>> overflows the space available.
>>
> 
> The IDC_CHOOSE_SYNC button with German text "Synchronisieren" overlaps 
> with "Test" checkbox:
> "(.) Synchronisier[.] Test"
> 
> Could be fixed by increasing res.rc:SETUP_KPCE_W from 52 to 60 (the 
> three radio buttons IMO do not look "nice" then),

Thanks for pointing this out.

Yeah, I agree it's not very pleasing, evenly spreading the radio buttons 
out horizontally like that.

I think maybe this dialog could use a little reworking, as I suspect the 
original layout was made with the assumption it needs to fit in on a 
640x480 VGA display, which is probably no longer valid. :)

> or by an individual adjustment like:
> - CONTROL "&Beste",IDC_CHOOSE_BEST,...,SETUP_BEST_X,30,SETUP_KPCE_W,14
> - CONTROL 
> "&Synchronisieren",IDC_CHOOSE_SYNC,...,SETUP_SYNC_X,30,SETUP_KPCE_W,14
> + CONTROL 
> "&Beste",IDC_CHOOSE_BEST,"Button",...,SETUP_BEST_X,30,SETUP_KPCE_W-10,14
> + CONTROL 
> "&Synchronisieren",IDC_CHOOSE_SYNC,...,SETUP_SYNC_X-12,30,SETUP_KPCE_W+12,14
> 
> or by simply using an abbreviation like "Synchr.".

Unfortunately, the tool used to merge in updated translations uses the 
English dialog layouts as a template, so per-language customizations 
like this will be hard to maintain.