From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18360 invoked by alias); 13 Aug 2018 22:26:11 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 18061 invoked by uid 89); 13 Aug 2018 22:26:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_40,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=emailing, H*r:sk:webmail, Hx-spam-relays-external:sk:webmail, H*RU:sk:webmail X-HELO: lb1-smtp-cloud9.xs4all.net Received: from lb1-smtp-cloud9.xs4all.net (HELO lb1-smtp-cloud9.xs4all.net) (194.109.24.22) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Aug 2018 22:26:09 +0000 Received: from webmail.xs4all.nl ([IPv6:2001:888:0:22:194:109:20:209]) by smtp-cloud9.xs4all.net with ESMTPA id pLHrfSprCEJtcpLHrfP4E2; Tue, 14 Aug 2018 00:26:07 +0200 Received: from a83-162-234-136.adsl.xs4all.nl ([83.162.234.136]) by webmail.xs4all.nl with HTTP (HTTP/1.1 POST); Tue, 14 Aug 2018 00:26:07 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 13 Aug 2018 22:26:00 -0000 From: Houder To: cygwin@cygwin.com Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.11.0-0.1 In-Reply-To: References: <20180810114254.GA25560@calimero.vinschen.de> <57b3092a9b5027be5f14e59c305200bc@smtp-cloud8.xs4all.net> <71f1280d04f70e8b74cfce78ba5690d3@xs4all.nl> Message-ID: <9a902fe9715b173671599a2e32eca26d@xs4all.nl> X-Sender: houder@xs4all.nl User-Agent: XS4ALL Webmail X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00157.txt.bz2 On 2018-08-14 00:16, Eric Blake wrote: > On 08/13/2018 04:29 PM, Houder wrote: > >>> The modication would require changing: >>> >>> winsup/cygwin/fenv.cc (_feinitialise() ) >>> winsup/cygwin/include/fenv.h (FE_ALL_EXCEPT) >> >> GRRR! The file encoding of fenv.h is "cp1252" because of 2 characters >> in this >> line: >> >>      Intel® 64 and IA-32 Architectures Software Developer’s Manuals: >> >> ... part of a comment at the beginning of the file. >> >> (the registered trademark sign (u00ae) is encoded as 0xae (cp1252), >> while it >>  would be: 0xc2 0xae, in utf-8, >>  the right single quotation mark (u2019) is encoded as 0x92 (cp1252), >> but in >>  utf-8 it would be: 0xc2 0x80 0x98) >> >> I intend to convert the file encoding of fenv.h to utf-8. Is that a >> "No-No" >> or is it allowed? (I assume GIT will notice). > > In general, git doesn't care if you change a file's encoding - that's > just another content change. In practice, you may get weird effects > when viewing that particular patch (as the patch is not well-formed in > the new multibyte locale, and looks funky when displayed in the old > locale), and emailing a patch may require care in telling git which > encoding to use for the email; but that's cosmetic, and shouldn't > matter in the long run. Updating the code base to uniformly use UTF-8 > seems reasonable to me. ... and emailing a patch may require care in telling git which encoding to use for the email ... Huh, huh ????? Last time I used: - git format-patch - git send-mail Am I safe here? Regards, Henri -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple