From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57869 invoked by alias); 7 Aug 2019 00:45:58 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 57675 invoked by uid 89); 7 Aug 2019 00:45:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,SPF_PASS autolearn=ham version=3.3.1 spammy=U*cygwin-patches, cygwin-patches@cygwin.com, cygwinpatchescygwincom, Hx-ms-oob-tlc-oobclassifiers:1728 X-HELO: nihcesxway3.hub.nih.gov Received: from nihcesxway3.hub.nih.gov (HELO nihcesxway3.hub.nih.gov) (128.231.90.125) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 00:45:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nih.gov; i=@nih.gov; q=dns/txt; s=NIH; t=1565138726; x=1596674726; h=from:to:subject:date:message-id: content-transfer-encoding:mime-version; bh=wHPaKb2JtufRRHM5jr47L4yA4YwBLRZ8wCz8VEDJ6zs=; b=n3tjzzxApxKHAOR+cvaAPc6f6VEtSYxxEAUwI3VpPf0caJkfC3P8jlsb utS3FHp2K++Qyuo1tqUzuZbhulxPBBMubnoBE0Ws3IiwZ9Tq+wNYlNtg3 CqFLo98oUA+d+U9OcOs9YFEneC4ez8tATmGF9pUvUOiKQWLd8LbS6GQpR OgA1NHHI7Po2Gk/KpQfGVqCSAUQ3LL46SI0WD5lLwgAVMJSEcSdM85VGu FzLzrLQfAtPSYdLvF/TPZMgzf95E0ElpVbIBoOLhP9u5oX0MEz/E+y9Kx nZlCDIGeI4fNZmt5ZPrXyMmHRulsS/V/0xnQwPTShBjDf1jq2emRo+goJ A==; IronPort-SDR: WYTd340FfrzKtZ19/T2rkufmVNKxs/a+W4kVHpnAeugIF3bemJQSZWl5CL2W+Doz/OVVTsK1k8 rYpke3lixAlA== Received: from uccsx02.nih.gov (HELO ces.nih.gov) ([165.112.194.92]) by nihcesxway3.hub.nih.gov with ESMTP/TLS/ECDHE-RSA-AES256-SHA384; 06 Aug 2019 20:45:23 -0400 Received: from uccsX04.nih.gov (165.112.194.94) by uccsX02.nih.gov (165.112.194.92) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 6 Aug 2019 20:45:23 -0400 Received: from uccsX02.nih.gov (165.112.194.92) by UCCSX04.nih.gov (165.112.194.94) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 6 Aug 2019 20:45:23 -0400 Received: from GCC01-CY1-obe.outbound.protection.outlook.com (165.112.194.6) by uccsX02.nih.gov (165.112.194.92) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 6 Aug 2019 20:45:23 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SYr8pF/uRtPNOQqgL+UPDMS1YNakluAdIDu1d4jg2zICF2gqP0W+mXLL40YEMIUJ++PaF2ul83VY4rvKIvHNUGIzYoEjFCIoYYLOdj384IKUPVSwaEEHfuSs14DJ8+Jr2Qrxy/aj5me0lmmLys+HaSS5k+A0ixI7AK/VgcxVh0QOqNeoQrhCsVD4Q6ESWo6CPJde1W+C5M+7nKxsiHjhQsqSSrOglSmxjtGqbgiW0TgvezR8HzCmMpbayrMbMphfIUbalMNabhDAnkzW1TqnsQyOlP6VOB6nY4MnSkXK1X96VCkH7vb0Sfo07VTrz09z8mrkTQsJTKFAmQyGHvjwzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHPaKb2JtufRRHM5jr47L4yA4YwBLRZ8wCz8VEDJ6zs=; b=ZT8RdAOJN2mLe0Lpb4CHWg8XHT2KH1F2UzoU+0xjJK31xukAwhb34iCWAvfsg0oL/lWiBaJRv7LMVGSSaLXhIKKfSa581dgkPoLWVehf+dpouFupsuzU1W/kkMPoPPNp2uWo5KSoizqhNa+fcWRua5fiVxjwcrGNbBZ8l8dSyCtmuHZebi4h8tWcmf9UOiMW+pgsrP9yVXZxeoJvDpzm3TbzvVnnSPnyf8JH24rV8T27ZFBxMxEDAfB4HuwjSax5tYRqF4yN/8FTZjVRojUpotxaMxytmu4FyT0KJUzwK7na4DzUcbuAiSrLuXtQoZ55vEyf/+vaHPbSHwnoNhLdEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=ncbi.nlm.nih.gov;dmarc=pass action=none header.from=ncbi.nlm.nih.gov;dkim=pass header.d=ncbi.nlm.nih.gov;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nih.onmicrosoft.com; s=selector1-nih-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHPaKb2JtufRRHM5jr47L4yA4YwBLRZ8wCz8VEDJ6zs=; b=Zo2JKMB8o3boG9QYXHGXXYFNZYD4gzybfFrQYBq4whfMYvyKBWb/74thZnsrd68omNBN86Y0DJQIqRcDmfuzqgA0k9JFFtvA6f2jJ6qRVI+hQvNT/STmrxojGRgMmnhsGRmNTmMTRkyloOE6a4WmGTU3S6eUPbks8EqEvLqjqPQ= Received: from BL0PR0901MB4308.namprd09.prod.outlook.com (52.135.47.83) by BL0PR0901MB2385.namprd09.prod.outlook.com (52.132.17.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Wed, 7 Aug 2019 00:45:21 +0000 Received: from BL0PR0901MB4308.namprd09.prod.outlook.com ([fe80::8052:3866:283f:306c]) by BL0PR0901MB4308.namprd09.prod.outlook.com ([fe80::8052:3866:283f:306c%3]) with mapi id 15.20.2157.011; Wed, 7 Aug 2019 00:45:21 +0000 From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C] via cygwin" Reply-To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" To: "'cygwin@cygwin.com'" Subject: Re: getpriority() and top display for priority is inconsistent Date: Wed, 07 Aug 2019 00:45:00 -0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=lavr@ncbi.nlm.nih.gov; x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BhB63S4UXnlQh5HdUY8vPqNo1aq3S2rWNK0G5Z+ZWMhDgqp6cVVsIVknqdNTVVtx Return-Path: lavr@ncbi.nlm.nih.gov X-SW-Source: 2019-08/txt/msg00093.txt.bz2 > You seem to have worked it out already so please send a patch in > git format-patch foramt to the cygwin-patches mailing list. I tried :-/ : Sorry, only subscribers may post. (#5.7.2) I do not use git to pull Cygwin sources. The last snapshot (that correspon= ds to the last-known-stable release I'm allowed to use) is a little old, but here goes the diff patch: $ diff -p cygwin-snapshot-20181226-{0,1}/winsup/cygwin/fhandler_process.cc *** cygwin-snapshot-20181226-0/winsup/cygwin/fhandler_process.cc 201= 8-08-17 14:41:04.000000000 -0400 --- cygwin-snapshot-20181226-1/winsup/cygwin/fhandler_process.cc 201= 9-08-06 17:05:35.421073900 -0400 *************** format_process_stat (void *data, char *& *** 1066,1072 **** unsigned long fault_count =3D 0UL, vmsize =3D 0UL, vmrss =3D 0UL, vmmaxrss =3D 0UL; uint64_t utime =3D 0ULL, stime =3D 0ULL, start_time =3D 0ULL; ! int priority =3D 0; if (p->process_state & PID_EXITED) strcpy (cmd, ""); else --- 1066,1072 ---- unsigned long fault_count =3D 0UL, vmsize =3D 0UL, vmrss =3D 0UL, vmmaxrss =3D 0UL; uint64_t utime =3D 0ULL, stime =3D 0ULL, start_time =3D 0ULL; ! if (p->process_state & PID_EXITED) strcpy (cmd, ""); else *************** format_process_stat (void *data, char *& *** 1095,1101 **** HANDLE hProcess; VM_COUNTERS vmc; KERNEL_USER_TIMES put; - PROCESS_BASIC_INFORMATION pbi; QUOTA_LIMITS ql; SYSTEM_TIMEOFDAY_INFORMATION stodi; SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION spt; --- 1095,1100 ---- *************** format_process_stat (void *data, char *& *** 1115,1123 **** status =3D NtQueryInformationProcess (hProcess, ProcessTimes, (PVOID) &put, sizeof put, NULL); if (NT_SUCCESS (status)) - status =3D NtQueryInformationProcess (hProcess, ProcessBasicInformati= on, - (PVOID) &pbi, sizeof pbi, NULL); - if (NT_SUCCESS (status)) status =3D NtQueryInformationProcess (hProcess, ProcessQuotaLimits, (PVOID) &ql, sizeof ql, NULL); CloseHandle (hProcess); --- 1114,1119 ---- *************** format_process_stat (void *data, char *& *** 1138,1154 **** stime =3D put.KernelTime.QuadPart * CLOCKS_PER_SEC / NS100PERSEC; start_time =3D (put.CreateTime.QuadPart - stodi.BootTime.QuadPart) * CLOCKS_PER_SEC / NS100PERSEC; - /* The BasePriority returned to a 32 bit process under WOW64 is - apparently broken, for 32 and 64 bit target processes. 64 bit - processes get the correct base priority, even for 32 bit processes. = */ - if (wincap.is_wow64 ()) - priority =3D 8; /* Default value. */ - else - priority =3D pbi.BasePriority; unsigned page_size =3D wincap.page_size (); vmsize =3D vmc.PagefileUsage; vmrss =3D vmc.WorkingSetSize / page_size; vmmaxrss =3D ql.MaximumWorkingSetSize / page_size; destbuf =3D (char *) crealloc_abort (destbuf, strlen (cmd) + 320); return __small_sprintf (destbuf, "%d (%s) %c " --- 1134,1144 ---- stime =3D put.KernelTime.QuadPart * CLOCKS_PER_SEC / NS100PERSEC; start_time =3D (put.CreateTime.QuadPart - stodi.BootTime.QuadPart) * CLOCKS_PER_SEC / NS100PERSEC; unsigned page_size =3D wincap.page_size (); vmsize =3D vmc.PagefileUsage; vmrss =3D vmc.WorkingSetSize / page_size; vmmaxrss =3D ql.MaximumWorkingSetSize / page_size; + int nice =3D winprio_to_nice(GetPriorityClass(hProcess)); destbuf =3D (char *) crealloc_abort (destbuf, strlen (cmd) + 320); return __small_sprintf (destbuf, "%d (%s) %c " *************** format_process_stat (void *data, char *& *** 1160,1166 **** p->pid, cmd, state, p->ppid, p->pgid, p->sid, p->ctty, -1, 0, fault_count, fault_count, 0, 0, utime, stime, ! utime, stime, priority, 0, 0, 0, start_time, vmsize, vmrss, vmmaxrss ); --- 1150,1156 ---- p->pid, cmd, state, p->ppid, p->pgid, p->sid, p->ctty, -1, 0, fault_count, fault_count, 0, 0, utime, stime, ! utime, stime, NZERO + nice, nice, 0, 0, start_time, vmsize, vmrss, vmmaxrss ); -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple