From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19223 invoked by alias); 7 Aug 2019 19:28:03 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 19210 invoked by uid 89); 7 Aug 2019 19:28:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: nihcesxway2.hub.nih.gov Received: from nihcesxway2.hub.nih.gov (HELO nihcesxway2.hub.nih.gov) (128.231.90.124) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 19:27:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nih.gov; i=@nih.gov; q=dns/txt; s=NIH; t=1565206078; x=1596742078; h=from:to:subject:date:message-id: content-transfer-encoding:mime-version; bh=8GcL6oHbOVm7yNg/53WhmQzF2lnhspfFI8tjr/ilml8=; b=dpxMJy0kdq1G/cteQ/4YH4RQTzWlQAMGgyFD2HQDvAYMpt2Vy1w3Dm7Q ZCOVmas67oIC+EFilJOJqm3QZ1hm6wQTKCX5q4pKAqH2t5gOt2lL7axqS CEwo+/xX2+JTThZrLMkXUasbcZn13fkAU5JbV2ugR9gEG/lQrW0QzNlm9 2LmnGw5FMpKNywiO+exgkcsrLRlTiSnbSsDSjx0lQnR5ZiDRuFNrGO4lQ tUsnExGGqDNwarmxExIFJWWuHDWSEyxgXLZJOsReI7R+06eu60qZBipqY H075foa98Ws7veN7D3dogP4Ze3+drs1ajGd3QobyFT5wwiHmVBXOrzp+l A==; IronPort-SDR: G7dPoV9oS72NY5h34alLe2PEUSz8DbT+jxxwLQWHjHW5Oa2Z6eJYNNPm0qtcDL+I9qKh76A9Rx 0Xy1RsQsteS/AI1B5SCR6cEYGZG73NfruSJv00Ck3vQSa4Qz1+AzhxPO5t+l+UGfl/yPt07xtl Ld4WQAeybyGKHjlnku/P9ft9rPKbZoM2Mv4hsYc3vRs9Yu5/jEDEdexybTSuwmW33fB2B8l2Ic qbytNPcRbdGpvWDXyssFr/57/5S8/R+SHrYSRcDbYVdhPaAToECcPTZa9Hs+WKXS9Iimuz+GfW tpk= Received: from uccbx01.nih.gov (HELO ces.nih.gov) ([156.40.79.151]) by nihcesxway2.hub.nih.gov with ESMTP/TLS/ECDHE-RSA-AES256-SHA384; 07 Aug 2019 15:27:48 -0400 Received: from uccbX01.nih.gov (156.40.79.151) by uccbX01.nih.gov (156.40.79.151) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 7 Aug 2019 15:27:43 -0400 Received: from GCC02-BL0-obe.outbound.protection.outlook.com (156.40.79.134) by uccbX01.nih.gov (156.40.79.151) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 7 Aug 2019 15:27:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aff1Kggwdi8nA9D6hMLzBn2T/Bw9iE2eQbnKj0KYiLkopGATqxJXksBhnzmnSV4VsXxjKchtJC4nCHDEmqVDWFRtV1QIc3HKEU1nd6UCeSlco5Ufr4Pup6LApTrsSHL0WrhPjUKp4vdKj/ABTjIzmaSj5YKGMg1KalVkmgJukNVBAp9zQZfLRuA6B0ft2gHMlv+DYXCIUcqA4QwyyyhxLqUSonx5dYFuNU8AmrhxYZN7V+CK5+gaEuW/Uw1PSLAJbMP9oLNP5f6cWioBIzb/vqy2G4VgjlyiaELya3x65Lipsxq2pqzM57CpQEXcYhcbiRRjyt5d91SrZljy5o102A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8GcL6oHbOVm7yNg/53WhmQzF2lnhspfFI8tjr/ilml8=; b=Yo0WZUqPMco+Qy3xjSajzT1R5cfrl912BzQL2vdT7COYPszjHynx9+QpJDSbhaPpSY1qsmUp5XpXtNC6jfmUAkiqfWsz45MnlyMWJup41v+hsKxCSINXoy1dtgHCvOxOYnOoHs7rk1dm+7JW40En77srwVWl8+K4P11IImarSjNDx/2IMcF4hfIQSyNlOyU93et2mp6jM5DmTd8kKN6wNTvYznQkuPhqKjukrd9opj9F9bgpzPHbnl9S6rwPVlpZs750rbbLbfNlnXkCGvdAlUom8jceUyb5vGGaf3IYYesSV2GPgisIWOb6ExH5/Oi6BBnBivHCF2P8J5WN03IGWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ncbi.nlm.nih.gov; dmarc=pass action=none header.from=ncbi.nlm.nih.gov; dkim=pass header.d=ncbi.nlm.nih.gov; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nih.onmicrosoft.com; s=selector1-nih-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8GcL6oHbOVm7yNg/53WhmQzF2lnhspfFI8tjr/ilml8=; b=P2UdNGIOtwdL22TaJ9e3UqPFXKTaqo/h0E1k6QD/yLwRj6wg7G+UDAYIIiOjw8nLviAD8M86kuD1dove7KddgZPdivh3qgU5pZ2+vG0lrXxx9grtwvwe2NrRrqScwPNlSaB+0eUWMgJm5x4mTIncG7uNaJeQo8U/NgI1u/fAQvQ= Received: from BL0PR0901MB4308.namprd09.prod.outlook.com (52.135.47.83) by BL0PR0901MB4546.namprd09.prod.outlook.com (52.135.44.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.15; Wed, 7 Aug 2019 19:27:41 +0000 Received: from BL0PR0901MB4308.namprd09.prod.outlook.com ([fe80::8052:3866:283f:306c]) by BL0PR0901MB4308.namprd09.prod.outlook.com ([fe80::8052:3866:283f:306c%3]) with mapi id 15.20.2157.015; Wed, 7 Aug 2019 19:27:41 +0000 From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C] via cygwin" Reply-To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" To: "'cygwin@cygwin.com'" Subject: Re: getpriority() and top display for priority is inconsistent Date: Wed, 07 Aug 2019 19:28:00 -0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=lavr@ncbi.nlm.nih.gov; x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6I6c3HMxyfRWbOk/+B1B9x4tbQo6uTU8iyx1zRNjBOjdkGY+NzmoKPYzk4qvkK8g Return-Path: lavr@ncbi.nlm.nih.gov X-SW-Source: 2019-08/txt/msg00113.txt.bz2 > Please give it a try. diff --git a/winsup/cygwin/fhandler_process.cc b/winsup/cygwin/fhandler_pro= cess.cc index 2a06554..2305b53 100644 --- a/winsup/cygwin/fhandler_process.cc +++ b/winsup/cygwin/fhandler_process.cc @@ -1076,7 +1076,7 @@ format_process_stat (void *data, char *&destbuf) unsigned long fault_count =3D 0UL, vmsize =3D 0UL, vmrss =3D 0UL, vmmaxrss =3D 0UL; uint64_t utime =3D 0ULL, stime =3D 0ULL, start_time =3D 0ULL; - int priority =3D 0; +=20=20 if (p->process_state & PID_EXITED) strcpy (cmd, ""); else @@ -1105,7 +1105,6 @@ format_process_stat (void *data, char *&destbuf) HANDLE hProcess; VM_COUNTERS vmc =3D { 0 }; KERNEL_USER_TIMES put =3D { 0 }; - PROCESS_BASIC_INFORMATION pbi =3D { 0 }; QUOTA_LIMITS ql =3D { 0 }; SYSTEM_TIMEOFDAY_INFORMATION stodi =3D { 0 }; =20 @@ -1134,11 +1133,6 @@ format_process_stat (void *data, char *&destbuf) if (!NT_SUCCESS (status)) debug_printf ("NtQueryInformationProcess(ProcessTimes): status %y", status); - status =3D NtQueryInformationProcess (hProcess, ProcessBasicInformat= ion, - (PVOID) &pbi, sizeof pbi, NULL); - if (!NT_SUCCESS (status)) - debug_printf ("NtQueryInformationProcess(ProcessBasicInformation): " - "status %y", status); status =3D NtQueryInformationProcess (hProcess, ProcessQuotaLimits, (PVOID) &ql, sizeof ql, NULL); if (!NT_SUCCESS (status)) @@ -1159,17 +1153,11 @@ format_process_stat (void *data, char *&destbuf) * CLOCKS_PER_SEC / NS100PERSEC; else start_time =3D (p->start_time - to_time_t (&stodi.BootTime)) * CLOCKS_= PER_SEC; - /* The BasePriority returned to a 32 bit process under WOW64 is - apparently broken, for 32 and 64 bit target processes. 64 bit - processes get the correct base priority, even for 32 bit processes. */ - if (wincap.is_wow64 ()) - priority =3D 8; /* Default value. */ - else - priority =3D pbi.BasePriority; unsigned page_size =3D wincap.page_size (); vmsize =3D vmc.PagefileUsage; vmrss =3D vmc.WorkingSetSize / page_size; vmmaxrss =3D ql.MaximumWorkingSetSize / page_size; + int nice =3D winprio_to_nice(GetPriorityClass(hProcess)); =20 destbuf =3D (char *) crealloc_abort (destbuf, strlen (cmd) + 320); return __small_sprintf (destbuf, "%d (%s) %c " @@ -1181,7 +1169,7 @@ format_process_stat (void *data, char *&destbuf) p->pid, cmd, state, p->ppid, p->pgid, p->sid, p->ctty, -1, 0, fault_count, fault_count, 0, 0, utime, stime, - utime, stime, priority, 0, 0, 0, + utime, stime, NZERO + nice, nice, 0, 0, start_time, vmsize, vmrss, vmmaxrss ); -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple