public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Nikolay Melekhin <nikolay.melekhin@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: cygwin@cygwin.com
Subject: Re: Extra CR symbol from backticks on Cygwin 2.9.0
Date: Tue, 12 Sep 2017 05:38:00 -0000	[thread overview]
Message-ID: <CAAq9174TrUGOr+y4GvMWEqNXao-zyemptuoSM8_Jna33qwpjiw@mail.gmail.com> (raw)
In-Reply-To: <7ed18312-4929-8299-d186-9cb0aa541a93@redhat.com>

Hi Eric,

Thanks! This option is what I am looking for.
However I cannot agree with you on bash behavior in Cygwin. Section of
command substitution in bash documentation says:

https://www.gnu.org/software/bash/manual/bash.html#Command-Substitution

"...with any trailing newlines deleted." That is why I expected that
bash should remove trailing newlines in command substitution results,
which are CRLF on Windows.
From my point of view, bash in Cygwin should follow the same rule on
Linux and Windows: remove trailing newlines in command substitution.
So remove trailing CRLF on Windows.


Best regards,
Nikolay Melekhin

2017-09-12 1:00 GMT+03:00 Eric Blake <eblake@redhat.com>:
> On 09/11/2017 04:27 PM, Nikolay Melekhin wrote:
>>
>> I'd expect that Cygwin must remove CRLF symbols from backtick results,
>
> You expected wrong - by default Cygwin does the same as Linux, which
> does NOT remove CR from command substitution (only LF).
>
>> but remove only LF symbol. It gets different results on Windows and
>> Linux. Result on Windows has additional CR symbol and for example
>> string comparision, which is working in Linux, fails in Windows.
>
> It is NOT a bug in Cygwin, but in your failure to sanitize your input.
> You'd get the same behavior on Linux if you pass in CR bytes.  That said,
>
>>
>> Is any kind of an option/setting which removes such CRs or it is a bug
>> in Cygwin?
>
> Read the release announcements: Cygwin bash DOES have an 'igncr' shell
> option (set -o igncr) that does exactly what you are asking for - it
> makes bash ignore CR characters in command substitutions and other places:
>
> https://cygwin.com/ml/cygwin-announce/2017-01/msg00047.html
>
> The option is not on by default, but exists because it is a common
> desire when you can't be bothered to otherwise sanitize CR out of your
> input stream.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  reply	other threads:[~2017-09-12  5:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 21:36 Nikolay Melekhin
2017-09-11 22:00 ` Eric Blake
2017-09-12  5:38   ` Nikolay Melekhin [this message]
2017-09-12  9:20     ` Andrey Repin
2017-09-12 13:03     ` cyg Simple
2017-09-12 13:06     ` Eric Blake
2017-09-12 13:10       ` cyg Simple
2017-09-13  0:11         ` Michel LaBarre
2017-09-13 14:34           ` cyg Simple
2017-09-13 18:47             ` Brian Inglis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAq9174TrUGOr+y4GvMWEqNXao-zyemptuoSM8_Jna33qwpjiw@mail.gmail.com \
    --to=nikolay.melekhin@gmail.com \
    --cc=cygwin@cygwin.com \
    --cc=eblake@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).