public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: "Carlo B." <carlo.bramini@gmail.com>
To: The Cygwin Mailing List <cygwin@cygwin.com>
Subject: [PATCH] SERIAL: Fix a copy-paste error in DTR setup
Date: Tue, 29 Nov 2022 10:11:49 +0100	[thread overview]
Message-ID: <CADt95742q=-cR8A1-e87X++pBcXvkdhQqDUFjpg2FwohnW0xpg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

Hello,
In commit 2dab880c963ce0204c3513d664f610b587a3e6a6 I did a mistake
when I copied the new fhandler_serial::switch_modem_lines() from my
modified 3.3.6 branch to the current master and I left a copy paste
error that I corrected later. This patch fixes that error.

Sorry for the trouble.
Sincerely,

Carlo Bramini.

[-- Attachment #2: 0001-SERIAL-Fix-a-copy-paste-error-in-DTR-setup.patch --]
[-- Type: application/octet-stream, Size: 1236 bytes --]

From 29df6b2bf87569e016e688fbaaeb2a3773f9094d Mon Sep 17 00:00:00 2001
From: Carlo Bramini <30959007+carlo-bramini@users.noreply.github.com>
Date: Tue, 29 Nov 2022 10:02:43 +0100
Subject: [PATCH] SERIAL: Fix a copy-paste error in DTR setup

In commit 2dab880c963ce0204c3513d664f610b587a3e6a6 I did a mistake when I copied the new fhandler_serial::switch_modem_lines() from my modified 3.3.6 branch to the current master and I left a copy paste error. This patch fixes that error.
---
 winsup/cygwin/fhandler/serial.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/fhandler/serial.cc b/winsup/cygwin/fhandler/serial.cc
index 58a8df677..e04f8f263 100644
--- a/winsup/cygwin/fhandler/serial.cc
+++ b/winsup/cygwin/fhandler/serial.cc
@@ -411,10 +411,10 @@ fhandler_serial::switch_modem_lines (int set, int clr)
         dcb.fRtsControl = RTS_CONTROL_DISABLE;
 
       if (set & TIOCM_DTR)
-        dcb.fRtsControl = DTR_CONTROL_ENABLE;
+        dcb.fDtrControl = DTR_CONTROL_ENABLE;
       else
       if (clr & TIOCM_DTR)
-        dcb.fRtsControl = DTR_CONTROL_DISABLE;
+        dcb.fDtrControl = DTR_CONTROL_DISABLE;
 
       if (!SetCommState(get_handle(), &dcb))
         {
-- 
2.38.1.windows.1


             reply	other threads:[~2022-11-29  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29  9:11 Carlo B. [this message]
2022-11-29 15:02 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADt95742q=-cR8A1-e87X++pBcXvkdhQqDUFjpg2FwohnW0xpg@mail.gmail.com' \
    --to=carlo.bramini@gmail.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).