From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 24CB53857C50 for ; Fri, 19 Mar 2021 11:17:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 24CB53857C50 Received: by mail-ej1-x634.google.com with SMTP id t18so9044581ejc.13 for ; Fri, 19 Mar 2021 04:17:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+BQWDRkux6my8+a6EZo2W7HU+2YDddeWNRiF1sl+Zwo=; b=SANEaTfF0PwUpZWgSzNPFcaQLf3kesEfuZ75o7DaPfY1/HWCLhhKI78r+W3eWnAkFq djX261TMOh1L6QqPozjcLFzmflPGXtGz8B3fO8Sw8O1rfxcn7Duj6o2lguSSR2JSt2E/ AGAya/74cR1iuQAA7g+OhKweWxp14VuBMJUgzWUL5sfQU6UrLCg36ClQSunRu2RbVnoG vlIgR5mSlKGi60kr9ZJFBeFndPePO0akWCj+8QthzxNZjuG70tq54V5RR/KCcAo5MTix h1NUvCgVyPp5ViC9SMD+Lgnld1s7NWB9XeSD/TXLQDkw47S8uvDDqCl6TfnkpCg4Eepe 12nw== X-Gm-Message-State: AOAM530Y0ZwdbQMEKgU6+LoCDuapXjlmtHpSlC9kbF5JDvVnGo7GsJxE czkfuUFZ5n0V5I6AUmpJTpoh0elI7YYXw9gxW0c= X-Google-Smtp-Source: ABdhPJwS7mEuhbq/VRHNKRfK0FqW7+BigCY3hs1HH2Lkq58EV8o2fKNx8rYxaMM8Iun26J7IboFb6ngClCIFuV0x3fY= X-Received: by 2002:a17:906:52d0:: with SMTP id w16mr3688213ejn.172.1616152631223; Fri, 19 Mar 2021 04:17:11 -0700 (PDT) MIME-Version: 1.0 References: <20210319190807.babb0c0312740f44e9119c17@nifty.ne.jp> In-Reply-To: <20210319190807.babb0c0312740f44e9119c17@nifty.ne.jp> From: Christoph Reiter Date: Fri, 19 Mar 2021 12:17:00 +0100 Message-ID: Subject: Re: stdin pipe rename in 3.2.0 To: Takashi Yano Cc: cygwin@cygwin.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 11:17:13 -0000 On Fri, Mar 19, 2021 at 11:09 AM Takashi Yano via Cygwin wrote: > > On Thu, 18 Mar 2021 21:28:40 +0100 > Christoph Reiter wrote: > > I noticed that the stdin pipe was renamed from > > > > "\msys-dd50a72ab4668b33-pty1-from-master" to > > "\msys-dd50a72ab4668b33-pty0-to-slave" in > > https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=bb42852062073439 > > Actually, this is not renamed but newly introduced only > for non-cygwin (native) apps. ah, I see. > > This trips up https://github.com/k-takata/ptycheck to detect the > > cygpty which is used in various code bases. > > If this change is affected, your process seems to be > a non-cygwin process. yes, I noticed this with non-cygwin processes. > > Is there a reason it was renamed? > > > > And while grepping I noticed the old name is still checked for in > > other places like > > https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/tty.cc;h=3c016315cdedb1dcca44cb3f3f96b87fd0b90a97;hb=HEAD#l162 > > which seems weird. > > The name "from-master" is still used for cygwin > processes. ok. > However, the naming was not appropriate. > The name of output pipes are: > "ptyNNNN-to-master-cyg" for cygwin process, > and > "ptyNNNN-to-master" for non-cygwin process. > > However, the name of input pipes are: > "ptyNNNN-from-master" for cygwin process, > and > "ptyNNNN-to-slave" for non-cygwin process. > This is not only consistent but also very confusing. > > I would like to rename these pipes to: > "ptyNNNN-from-master-cyg" for cygwin process, > "ptyNNNN-from-master" for non-cygwin process. If the naming was changed to keep https://github.com/k-takata/ptycheck working then it would help me a lot. But I also don't mind patching this on our side. Thanks!