MSYS mode (continue)

MSYS mode (continue)

[Alexey Pavlov]

I want to continue our discussion about integrating MSYS mode into
Cygwin sources.
Right now we need to determine where you can create hooks for msys
plugin I think.
MSYS plugin need to has ability to change next logic:

 - generating osname
 - reading /etc/fstab
 - changing environment variables and filtering them, that passed to
non-cygwin applications
 - changing program arguments that passed to non-cygwin applications



Regards,
Alexey.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Christopher Faylor]

On Wed, Jul 03, 2013 at 08:03:25PM +0400, Alexey Pavlov wrote:
>I want to continue our discussion about integrating MSYS mode into
>Cygwin sources.
>Right now we need to determine where you can create hooks for msys
>plugin I think.
>MSYS plugin need to has ability to change next logic:
>
> - generating osname
> - reading /etc/fstab
> - changing environment variables and filtering them, that passed to
>non-cygwin applications
> - changing program arguments that passed to non-cygwin applications

That all sounds doable but could you refresh my memory on why you need
an /etc/fstab hook?  Was it to map /cygdrive/c -> /c or something?

If so, as long as you're going to have an fstab why not just do that
in the fstab itself?

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

2013/7/3 Christopher Faylor:
> On Wed, Jul 03, 2013 at 08:03:25PM +0400, Alexey Pavlov wrote:
>>I want to continue our discussion about integrating MSYS mode into
>>Cygwin sources.
>>Right now we need to determine where you can create hooks for msys
>>plugin I think.
>>MSYS plugin need to has ability to change next logic:
>>
>> - generating osname
>> - reading /etc/fstab
>> - changing environment variables and filtering them, that passed to
>>non-cygwin applications
>> - changing program arguments that passed to non-cygwin applications
>
> That all sounds doable but could you refresh my memory on why you need
> an /etc/fstab hook?  Was it to map /cygdrive/c -> /c or something?
>
I need it to be able read short mount points from fstab: <win32_path>
<posix_path>.
All other options are set by default. With my changes I can have in
/etc/fstab both types of mount points - cygwin-like and msys-like.

> If so, as long as you're going to have an fstab why not just do that
> in the fstab itself?
I already add line to stab that drop cygdrive prefix.

>
> cgf
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  3 22:24, Alexey Pavlov wrote:
> 2013/7/3 Christopher Faylor:
> > On Wed, Jul 03, 2013 at 08:03:25PM +0400, Alexey Pavlov wrote:
> >>I want to continue our discussion about integrating MSYS mode into
> >>Cygwin sources.
> >>Right now we need to determine where you can create hooks for msys
> >>plugin I think.
> >>MSYS plugin need to has ability to change next logic:
> >>
> >> - generating osname
> >> - reading /etc/fstab
> >> - changing environment variables and filtering them, that passed to
> >>non-cygwin applications
> >> - changing program arguments that passed to non-cygwin applications
> >
> > That all sounds doable but could you refresh my memory on why you need
> > an /etc/fstab hook?  Was it to map /cygdrive/c -> /c or something?
> >
> I need it to be able read short mount points from fstab: <win32_path>
> <posix_path>.
> All other options are set by default. With my changes I can have in
> /etc/fstab both types of mount points - cygwin-like and msys-like.

And why is that necessary?  There are always default options set anyway,
but a layout change of the fstab file simply makes no sense.  There's no
win at all.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Charles Wilson]

On 7/3/2013 3:50 PM, Corinna Vinschen wrote:
> On Jul  3 22:24, Alexey Pavlov wrote:
>> 2013/7/3 Christopher Faylor:
>> I need it to be able read short mount points from fstab: <win32_path>
>> <posix_path>.
>> All other options are set by default. With my changes I can have in
>> /etc/fstab both types of mount points - cygwin-like and msys-like.
>
> And why is that necessary?  There are always default options set anyway,
> but a layout change of the fstab file simply makes no sense.  There's no
> win at all.

I think Alexey is trying to replicate MSYS's behavior, so it becomes 
more of a drop-in replacement.  Here's my MSYS /etc/fstab (MSYS doesn't 
yet support per-user fstab.d/username settings):

C:/MinGW               /mingw
C:/Users/me/Desktop    /desktop
C:/Users/me/Documents  /docs
C:/msys-src            /usr/src

I agree with Corinna that there's no need to make cygwin-in-msys-mode 
EXACTLY like MSYS in all of its configuration settings (such as the 
syntax of /etc/fstab).

Your MSYS-like cygwin installation would have its own /etc/fstab (in 
regular cygwin format), but perhaps your /home area is mapped 
differently in that fstab, than in the /etc/fstab in your "regular" 
cygwin installation.  Or, like me, I have a separate msys-src and 
cygwin-src directory mapped onto MSYS's /usr/src and cygwin's /usr/src, 
respectively.

Or is the proposal on the table for the same installation to be usable 
in both modes, depending on the nature of the launched application?

--
Chuck


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Christopher Faylor]

On Wed, Jul 03, 2013 at 05:03:04PM -0400, Charles Wilson wrote:
>On 7/3/2013 3:50 PM, Corinna Vinschen wrote:
>> On Jul  3 22:24, Alexey Pavlov wrote:
>>> 2013/7/3 Christopher Faylor:
>>> I need it to be able read short mount points from fstab: <win32_path>
>>> <posix_path>.
>>> All other options are set by default. With my changes I can have in
>>> /etc/fstab both types of mount points - cygwin-like and msys-like.
>>
>> And why is that necessary?  There are always default options set anyway,
>> but a layout change of the fstab file simply makes no sense.  There's no
>> win at all.
>
>I think Alexey is trying to replicate MSYS's behavior, so it becomes 
>more of a drop-in replacement.  Here's my MSYS /etc/fstab (MSYS doesn't 
>yet support per-user fstab.d/username settings):
>
>C:/MinGW               /mingw
>C:/Users/me/Desktop    /desktop
>C:/Users/me/Documents  /docs
>C:/msys-src            /usr/src

I think Cygwin fstab parsing could be loosened up to allow that syntax.

>I agree with Corinna that there's no need to make cygwin-in-msys-mode 
>EXACTLY like MSYS in all of its configuration settings (such as the 
>syntax of /etc/fstab).
>
>Your MSYS-like cygwin installation would have its own /etc/fstab (in 
>regular cygwin format), but perhaps your /home area is mapped 
>differently in that fstab, than in the /etc/fstab in your "regular" 
>cygwin installation.  Or, like me, I have a separate msys-src and 
>cygwin-src directory mapped onto MSYS's /usr/src and cygwin's /usr/src, 
>respectively.
>
>Or is the proposal on the table for the same installation to be usable 
>in both modes, depending on the nature of the launched application?

That's an interesting idea but I don't think anyone was proposing that.

Is there any reason why we'd need to add a hook to filename parsing?
That would be an alternative to hooking fstab.

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Charles Wilson]

On 7/3/2013 5:57 PM, Christopher Faylor wrote:
> On Wed, Jul 03, 2013 at 05:03:04PM -0400, Charles Wilson wrote:
>> Or is the proposal on the table for the same installation to be usable
>> in both modes, depending on the nature of the launched application?
>
> That's an interesting idea but I don't think anyone was proposing that.
>
> Is there any reason why we'd need to add a hook to filename parsing?
> That would be an alternative to hooking fstab.

Well, MSYS doesn't mind dos-style filenames, so the big-ugly-warn-once 
thing shouldn't happen... And if we ever do, really and truly, deprecate 
dos-style paths for cygwin /proper/, you'd need to hook the parsing in 
order to restore that functionality for cygwin-/msys/.

--
Chuck



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

My opinion is to extend Cygwin parser to read msys-like mounts. It's
very simple:

--- mount.cc 2013-04-24 20:29:29.000000000 +0400
+++ Cygwin/winsup/cygwin/mount.cc 2013-06-13 09:35:01.479492100 +0400
@@ -1125,8 +1118,17 @@
   if (!*c)
     return true;
   cend = find_ws (c);
-  *cend = '\0';
   posix_path = conv_fstab_spaces (c);
+  if (!*cend)
+   {
+     unsigned mount_flags = MOUNT_SYSTEM | MOUNT_BINARY |
MOUNT_NOPOSIX | MOUNT_NOACL;
+
+     int res = mount_table->add_item (native_path, posix_path, mount_flags);
+     if (res && get_errno () == EMFILE)
+       return false;
+     return true;
+   }
+  *cend = '\0';
   /* Third field: FS type. */
   c = skip_ws (cend + 1);
   if (!*c)


Regards,
Alexey.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

Hi Alexey,

On Jul  4 06:33, Alexey Pavlov wrote:
> My opinion is to extend Cygwin parser to read msys-like mounts. It's
> very simple:
> 
> --- mount.cc 2013-04-24 20:29:29.000000000 +0400
> +++ Cygwin/winsup/cygwin/mount.cc 2013-06-13 09:35:01.479492100 +0400
> @@ -1125,8 +1118,17 @@
>    if (!*c)
>      return true;
>    cend = find_ws (c);
> -  *cend = '\0';
>    posix_path = conv_fstab_spaces (c);
> +  if (!*cend)
> +   {
> +     unsigned mount_flags = MOUNT_SYSTEM | MOUNT_BINARY |
> MOUNT_NOPOSIX | MOUNT_NOACL;
> +
> +     int res = mount_table->add_item (native_path, posix_path, mount_flags);
> +     if (res && get_errno () == EMFILE)
> +       return false;
> +     return true;
> +   }
> +  *cend = '\0';
>    /* Third field: FS type. */
>    c = skip_ws (cend + 1);
>    if (!*c)

This patch is trivial enough to go in (barring discussion) without
copyright assignment.   Still, the CA is necessary for more complex
patches.

Would you mind to send a CA (http://cygwin.com/assign.txt) per snail
mail to the address given in the form?

Apart from that, please provide a ChangeLog entry.  Please read
http://cygwin.com/contrib.html, especially the last section called
"When you have finalized your changes".


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

2013/7/4 Corinna Vinschen:
> Hi Alexey,
>
> On Jul  4 06:33, Alexey Pavlov wrote:
>> My opinion is to extend Cygwin parser to read msys-like mounts. It's
>> very simple:
>>
>> --- mount.cc 2013-04-24 20:29:29.000000000 +0400
>> +++ Cygwin/winsup/cygwin/mount.cc 2013-06-13 09:35:01.479492100 +0400
>> @@ -1125,8 +1118,17 @@
>>    if (!*c)
>>      return true;
>>    cend = find_ws (c);
>> -  *cend = '\0';
>>    posix_path = conv_fstab_spaces (c);
>> +  if (!*cend)
>> +   {
>> +     unsigned mount_flags = MOUNT_SYSTEM | MOUNT_BINARY |
>> MOUNT_NOPOSIX | MOUNT_NOACL;
>> +
>> +     int res = mount_table->add_item (native_path, posix_path, mount_flags);
>> +     if (res && get_errno () == EMFILE)
>> +       return false;
>> +     return true;
>> +   }
>> +  *cend = '\0';
>>    /* Third field: FS type. */
>>    c = skip_ws (cend + 1);
>>    if (!*c)
>
> This patch is trivial enough to go in (barring discussion) without
> copyright assignment.   Still, the CA is necessary for more complex
> patches.
>
Good.

> Would you mind to send a CA (http://cygwin.com/assign.txt) per snail
> mail to the address given in the form?
>
I will do it in a week I think.

> Apart from that, please provide a ChangeLog entry.  Please read
> http://cygwin.com/contrib.html, especially the last section called
> "When you have finalized your changes".
>
Ok.
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

2013-06-18  Alexey Pavlov

* mount.cc: Allow using a shortened version of mount points in /etc/fstab
* utsname.h: Increase sysname fiels size.
* uname.cc: Allow changing OS name by MSYSTEM environment variable.

Index: cygwin/mount.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/mount.cc,v
retrieving revision 1.100
diff -u -p -r1.100 mount.cc
--- cygwin/mount.cc 24 Apr 2013 10:16:12 -0000 1.100
+++ cygwin/mount.cc 18 Jun 2013 11:39:27 -0000
@@ -1125,8 +1125,16 @@ mount_info::from_fstab_line (char *line,
   if (!*c)
     return true;
   cend = find_ws (c);
-  *cend = '\0';
   posix_path = conv_fstab_spaces (c);
+  if (!*cend)
+   {
+     unsigned mount_flags = MOUNT_SYSTEM | MOUNT_BINARY |
MOUNT_NOPOSIX | MOUNT_NOACL;
+     int res = mount_table->add_item (native_path, posix_path, mount_flags);
+     if (res && get_errno () == EMFILE)
+       return false;
+     return true;
+   }
+  *cend = '\0';
   /* Third field: FS type. */
   c = skip_ws (cend + 1);
   if (!*c)
Index: cygwin/uname.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/uname.cc,v
retrieving revision 1.31
diff -u -p -r1.31 uname.cc
--- cygwin/uname.cc 21 Jan 2013 04:38:29 -0000 1.31
+++ cygwin/uname.cc 18 Jun 2013 11:39:27 -0000
@@ -29,7 +29,9 @@ uname (struct utsname *name)
   char *snp = strstr  (cygwin_version.dll_build_date, "SNP");

   memset (name, 0, sizeof (*name));
-  __small_sprintf (name->sysname, "CYGWIN_%s", wincap.osname ());
+  char* msystem = getenv("MSYSTEM");
+  const char *msystem_cyg = "CYGWIN";
+  __small_sprintf (name->sysname, "%s_%s", msystem ? msystem :
msystem_cyg, wincap.osname ());

 #if 0
   /* Recognition of the real 64 bit CPU inside of a WOW64 system, irritates
Index: cygwin/include/sys/utsname.h
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
retrieving revision 1.3
diff -u -p -r1.3 utsname.h
--- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
+++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
@@ -17,7 +17,7 @@ extern "C" {

 struct utsname
 {
-  char sysname[20];
+  char sysname[21];
   char nodename[20];
   char release[20];
   char version[20];

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  4 13:09, Alexey Pavlov wrote:
> 2013-06-18  Alexey Pavlov
> 
> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
> * utsname.h: Increase sysname fiels size.
> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
> [...SNIP...]

Can we please move patch submissions to the cygwin-patches mailing list?
Thank you.

> Index: cygwin/include/sys/utsname.h
> ===================================================================
> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
> retrieving revision 1.3
> diff -u -p -r1.3 utsname.h
> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
> @@ -17,7 +17,7 @@ extern "C" {
> 
>  struct utsname
>  {
> -  char sysname[20];
> +  char sysname[21];

We can't do that.  struct utsname is a publically facing structure.
If you change the size, you're breaking compatibility with existing
applications.

You should better drop some character from the string you want to enter
here.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

2013/7/4 Corinna Vinschen:
> On Jul  4 13:09, Alexey Pavlov wrote:
>> 2013-06-18  Alexey Pavlov
>>
>> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
>> * utsname.h: Increase sysname fiels size.
>> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
>> [...SNIP...]
>
> Can we please move patch submissions to the cygwin-patches mailing list?
> Thank you.
>
>> Index: cygwin/include/sys/utsname.h
>> ===================================================================
>> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
>> retrieving revision 1.3
>> diff -u -p -r1.3 utsname.h
>> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
>> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
>> @@ -17,7 +17,7 @@ extern "C" {
>>
>>  struct utsname
>>  {
>> -  char sysname[20];
>> +  char sysname[21];
>
> We can't do that.  struct utsname is a publically facing structure.
> If you change the size, you're breaking compatibility with existing
> applications.
>
> You should better drop some character from the string you want to enter
> here.
>

I can't drop any symbol from "MINGW32" word :)
>
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  4 12:37, Alexey Pavlov wrote:
> 2013/7/4 Corinna Vinschen:
> > On Jul  4 13:09, Alexey Pavlov wrote:
> >> 2013-06-18  Alexey Pavlov
> >>
> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
> >> * utsname.h: Increase sysname fiels size.
> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
> >> [...SNIP...]
> >
> > Can we please move patch submissions to the cygwin-patches mailing list?
> > Thank you.
> >
> >> Index: cygwin/include/sys/utsname.h
> >> ===================================================================
> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
> >> retrieving revision 1.3
> >> diff -u -p -r1.3 utsname.h
> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
> >> @@ -17,7 +17,7 @@ extern "C" {
> >>
> >>  struct utsname
> >>  {
> >> -  char sysname[20];
> >> +  char sysname[21];
> >
> > We can't do that.  struct utsname is a publically facing structure.
> > If you change the size, you're breaking compatibility with existing
> > applications.
> >
> > You should better drop some character from the string you want to enter
> > here.
> >
> 
> I can't drop any symbol from "MINGW32" word :)

That's not 20 chars long.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

2013/7/4 Corinna Vinschen:
> On Jul  4 12:37, Alexey Pavlov wrote:
>> 2013/7/4 Corinna Vinschen:
>> > On Jul  4 13:09, Alexey Pavlov wrote:
>> >> 2013-06-18  Alexey Pavlov
>> >>
>> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
>> >> * utsname.h: Increase sysname fiels size.
>> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
>> >> [...SNIP...]
>> >
>> > Can we please move patch submissions to the cygwin-patches mailing list?
>> > Thank you.
>> >
>> >> Index: cygwin/include/sys/utsname.h
>> >> ===================================================================
>> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
>> >> retrieving revision 1.3
>> >> diff -u -p -r1.3 utsname.h
>> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
>> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
>> >> @@ -17,7 +17,7 @@ extern "C" {
>> >>
>> >>  struct utsname
>> >>  {
>> >> -  char sysname[20];
>> >> +  char sysname[21];
>> >
>> > We can't do that.  struct utsname is a publically facing structure.
>> > If you change the size, you're breaking compatibility with existing
>> > applications.
>> >
>> > You should better drop some character from the string you want to enter
>> > here.
>> >
>>
>> I can't drop any symbol from "MINGW32" word :)
>
> That's not 20 chars long.
>
Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:

CYGWIN_NT-6.1-WOW64\0

But

MINGW32_NT-6.1-WOW64\0

is 21 symbol.

Regards,
Alexey.
>
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Kai Tietz]

2013/7/4 Alexey Pavlov wrote:
> 2013/7/4 Corinna Vinschen:
>> On Jul  4 12:37, Alexey Pavlov wrote:
>>> 2013/7/4 Corinna Vinschen:
>>> > On Jul  4 13:09, Alexey Pavlov wrote:
>>> >> 2013-06-18  Alexey Pavlov
>>> >>
>>> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
>>> >> * utsname.h: Increase sysname fiels size.
>>> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
>>> >> [...SNIP...]
>>> >
>>> > Can we please move patch submissions to the cygwin-patches mailing list?
>>> > Thank you.
>>> >
>>> >> Index: cygwin/include/sys/utsname.h
>>> >> ===================================================================
>>> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
>>> >> retrieving revision 1.3
>>> >> diff -u -p -r1.3 utsname.h
>>> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
>>> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
>>> >> @@ -17,7 +17,7 @@ extern "C" {
>>> >>
>>> >>  struct utsname
>>> >>  {
>>> >> -  char sysname[20];
>>> >> +  char sysname[21];
>>> >
>>> > We can't do that.  struct utsname is a publically facing structure.
>>> > If you change the size, you're breaking compatibility with existing
>>> > applications.
>>> >
>>> > You should better drop some character from the string you want to enter
>>> > here.
>>> >
>>>
>>> I can't drop any symbol from "MINGW32" word :)
>>
>> That's not 20 chars long.
>>
> Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
>
> CYGWIN_NT-6.1-WOW64\0
>
> But
>
> MINGW32_NT-6.1-WOW64\0
>
> is 21 symbol.

Hmm, out of curiousity.  Why is the name MINGW_NT-6.1-WOW64\0 not
suitable.  For what is this 32 good for?

> Regards,
> Alexey.

Sorry, for this stupid question.

Kai

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  4 12:34, Kai Tietz wrote:
> 2013/7/4 Alexey Pavlov wrote:
> > 2013/7/4 Corinna Vinschen:
> >> On Jul  4 12:37, Alexey Pavlov wrote:
> >>> 2013/7/4 Corinna Vinschen:
> >>> > On Jul  4 13:09, Alexey Pavlov wrote:
> >>> >> 2013-06-18  Alexey Pavlov
> >>> >>
> >>> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
> >>> >> * utsname.h: Increase sysname fiels size.
> >>> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
> >>> >> [...SNIP...]
> >>> >
> >>> > Can we please move patch submissions to the cygwin-patches mailing list?
> >>> > Thank you.
> >>> >
> >>> >> Index: cygwin/include/sys/utsname.h
> >>> >> ===================================================================
> >>> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
> >>> >> retrieving revision 1.3
> >>> >> diff -u -p -r1.3 utsname.h
> >>> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
> >>> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
> >>> >> @@ -17,7 +17,7 @@ extern "C" {
> >>> >>
> >>> >>  struct utsname
> >>> >>  {
> >>> >> -  char sysname[20];
> >>> >> +  char sysname[21];
> >>> >
> >>> > We can't do that.  struct utsname is a publically facing structure.
> >>> > If you change the size, you're breaking compatibility with existing
> >>> > applications.
> >>> >
> >>> > You should better drop some character from the string you want to enter
> >>> > here.
> >>> >
> >>>
> >>> I can't drop any symbol from "MINGW32" word :)
> >>
> >> That's not 20 chars long.
> >>
> > Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
> >
> > CYGWIN_NT-6.1-WOW64\0
> >
> > But
> >
> > MINGW32_NT-6.1-WOW64\0
> >
> > is 21 symbol.
> 
> Hmm, out of curiousity.  Why is the name MINGW_NT-6.1-WOW64\0 not
> suitable.  For what is this 32 good for?
> 
> > Regards,
> > Alexey.
> 
> Sorry, for this stupid question.

No sorry here, it's not stupid.  I agree, why not just drop the "32"?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

2013/7/4 Corinna Vinschen:
> On Jul  4 12:34, Kai Tietz wrote:
>> 2013/7/4 Alexey Pavlov wrote:
>> > 2013/7/4 Corinna Vinschen:
>> >> On Jul  4 12:37, Alexey Pavlov wrote:
>> >>> 2013/7/4 Corinna Vinschen:
>> >>> > On Jul  4 13:09, Alexey Pavlov wrote:
>> >>> >> 2013-06-18  Alexey Pavlov
>> >>> >>
>> >>> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
>> >>> >> * utsname.h: Increase sysname fiels size.
>> >>> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
>> >>> >> [...SNIP...]
>> >>> >
>> >>> > Can we please move patch submissions to the cygwin-patches mailing list?
>> >>> > Thank you.
>> >>> >
>> >>> >> Index: cygwin/include/sys/utsname.h
>> >>> >> ===================================================================
>> >>> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
>> >>> >> retrieving revision 1.3
>> >>> >> diff -u -p -r1.3 utsname.h
>> >>> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
>> >>> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
>> >>> >> @@ -17,7 +17,7 @@ extern "C" {
>> >>> >>
>> >>> >>  struct utsname
>> >>> >>  {
>> >>> >> -  char sysname[20];
>> >>> >> +  char sysname[21];
>> >>> >
>> >>> > We can't do that.  struct utsname is a publically facing structure.
>> >>> > If you change the size, you're breaking compatibility with existing
>> >>> > applications.
>> >>> >
>> >>> > You should better drop some character from the string you want to enter
>> >>> > here.
>> >>> >
>> >>>
>> >>> I can't drop any symbol from "MINGW32" word :)
>> >>
>> >> That's not 20 chars long.
>> >>
>> > Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
>> >
>> > CYGWIN_NT-6.1-WOW64\0
>> >
>> > But
>> >
>> > MINGW32_NT-6.1-WOW64\0
>> >
>> > is 21 symbol.
>>
>> Hmm, out of curiousity.  Why is the name MINGW_NT-6.1-WOW64\0 not
>> suitable.  For what is this 32 good for?
>>
>> > Regards,
>> > Alexey.
>>
>> Sorry, for this stupid question.
>
> No sorry here, it's not stupid.  I agree, why not just drop the "32"?
>

It can be I think because in config.guess is *MINGW*.
>
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Charles Wilson]

On 7/4/2013 6:47 AM, Corinna Vinschen wrote:
>> Hmm, out of curiousity.  Why is the name MINGW_NT-6.1-WOW64\0 not
>> suitable.  For what is this 32 good for?
>>
>> Sorry, for this stupid question.
>
> No sorry here, it's not stupid.  I agree, why not just drop the "32"?

Because it would break any configure scripts or config.guess that test for:

case $(uname -s) in
MINGW32-* ) ...
esac

There are a few of those in the wild, although modern config.guess says:

     *:MINGW64*:*)
         echo ${UNAME_MACHINE}-pc-mingw64
         exit ;;
     *:MINGW*:*)
         echo ${UNAME_MACHINE}-pc-mingw32
         exit ;;
     i*:MSYS*:*)
         echo ${UNAME_MACHINE}-pc-msys
         exit ;;

(FWIW, I'm not sure what MINGW64 is all about...)

--
Chuck


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  4 14:23, Alexey Pavlov wrote:
> 2013/7/4 Corinna Vinschen:
> > On Jul  4 12:37, Alexey Pavlov wrote:
> >> 2013/7/4 Corinna Vinschen:
> >> > On Jul  4 13:09, Alexey Pavlov wrote:
> >> >> 2013-06-18  Alexey Pavlov
> >> >>
> >> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
> >> >> * utsname.h: Increase sysname fiels size.
> >> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
> >> >> [...SNIP...]
> >> >
> >> > Can we please move patch submissions to the cygwin-patches mailing list?
> >> > Thank you.
> >> >
> >> >> Index: cygwin/include/sys/utsname.h
> >> >> ===================================================================
> >> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
> >> >> retrieving revision 1.3
> >> >> diff -u -p -r1.3 utsname.h
> >> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
> >> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
> >> >> @@ -17,7 +17,7 @@ extern "C" {
> >> >>
> >> >>  struct utsname
> >> >>  {
> >> >> -  char sysname[20];
> >> >> +  char sysname[21];
> >> >
> >> > We can't do that.  struct utsname is a publically facing structure.
> >> > If you change the size, you're breaking compatibility with existing
> >> > applications.
> >> >
> >> > You should better drop some character from the string you want to enter
> >> > here.
> >> >
> >>
> >> I can't drop any symbol from "MINGW32" word :)
> >
> > That's not 20 chars long.
> >
> Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
> 
> CYGWIN_NT-6.1-WOW64\0
> 
> But
> 
> MINGW32_NT-6.1-WOW64\0
> 
> is 21 symbol.

Then drop the dash between "NT" and "6.1".  Or let's drop the WOW64
since it's redundant anyway, given the content of "machine".


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Alexey Pavlov]

2013/7/4 Corinna Vinschen:
> On Jul  4 14:23, Alexey Pavlov wrote:
>> 2013/7/4 Corinna Vinschen:
>> > On Jul  4 12:37, Alexey Pavlov wrote:
>> >> 2013/7/4 Corinna Vinschen:
>> >> > On Jul  4 13:09, Alexey Pavlov wrote:
>> >> >> 2013-06-18  Alexey Pavlov
>> >> >>
>> >> >> * mount.cc: Allow using a shortened version of mount points in /etc/fstab
>> >> >> * utsname.h: Increase sysname fiels size.
>> >> >> * uname.cc: Allow changing OS name by MSYSTEM environment variable.
>> >> >> [...SNIP...]
>> >> >
>> >> > Can we please move patch submissions to the cygwin-patches mailing list?
>> >> > Thank you.
>> >> >
>> >> >> Index: cygwin/include/sys/utsname.h
>> >> >> ===================================================================
>> >> >> RCS file: /cvs/src/src/winsup/cygwin/include/sys/utsname.h,v
>> >> >> retrieving revision 1.3
>> >> >> diff -u -p -r1.3 utsname.h
>> >> >> --- cygwin/include/sys/utsname.h 21 Jan 2013 04:38:31 -0000 1.3
>> >> >> +++ cygwin/include/sys/utsname.h 18 Jun 2013 11:39:27 -0000
>> >> >> @@ -17,7 +17,7 @@ extern "C" {
>> >> >>
>> >> >>  struct utsname
>> >> >>  {
>> >> >> -  char sysname[20];
>> >> >> +  char sysname[21];
>> >> >
>> >> > We can't do that.  struct utsname is a publically facing structure.
>> >> > If you change the size, you're breaking compatibility with existing
>> >> > applications.
>> >> >
>> >> > You should better drop some character from the string you want to enter
>> >> > here.
>> >> >
>> >>
>> >> I can't drop any symbol from "MINGW32" word :)
>> >
>> > That's not 20 chars long.
>> >
>> Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
>>
>> CYGWIN_NT-6.1-WOW64\0
>>
>> But
>>
>> MINGW32_NT-6.1-WOW64\0
>>
>> is 21 symbol.
>
> Then drop the dash between "NT" and "6.1".  Or let's drop the WOW64
> since it's redundant anyway, given the content of "machine".
>

Let's drop it!

>
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  4 13:45, Alexey Pavlov wrote:
> 2013/7/4 Corinna Vinschen:
> > On Jul  4 14:23, Alexey Pavlov wrote:
> >> 2013/7/4 Corinna Vinschen:
> >> > On Jul  4 12:37, Alexey Pavlov wrote:
> >> >> 2013/7/4 Corinna Vinschen:
> >> >> > On Jul  4 13:09, Alexey Pavlov wrote:
> >> >> >>  struct utsname
> >> >> >>  {
> >> >> >> -  char sysname[20];
> >> >> >> +  char sysname[21];
> >> >> >
> >> >> > We can't do that.  struct utsname is a publically facing structure.
> >> >> > If you change the size, you're breaking compatibility with existing
> >> >> > applications.
> >> >> >
> >> >> > You should better drop some character from the string you want to enter
> >> >> > here.
> >> >> >
> >> >>
> >> >> I can't drop any symbol from "MINGW32" word :)
> >> >
> >> > That's not 20 chars long.
> >> >
> >> Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
> >>
> >> CYGWIN_NT-6.1-WOW64\0
> >>
> >> But
> >>
> >> MINGW32_NT-6.1-WOW64\0
> >>
> >> is 21 symbol.
> >
> > Then drop the dash between "NT" and "6.1".  Or let's drop the WOW64
> > since it's redundant anyway, given the content of "machine".
> >
> 
> Let's drop it!

I'm ok with that, but I think we should drop the "32" from MINGW in
the first place.

Does anybody rely on the "WOW64" in uname -s output?  I just checked
the scripts in /bin in my installation and none of it seems to check
for that info.

And then again, it *is* redundant, given the uname -m output...


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Charles Wilson]

On 7/4/2013 8:16 AM, Corinna Vinschen wrote:
> I'm ok with that, but I think we should drop the "32" from MINGW in
> the first place.
>
> Does anybody rely on the "WOW64" in uname -s output?  I just checked
> the scripts in /bin in my installation and none of it seems to check
> for that info.
>
> And then again, it *is* redundant, given the uname -m output...

cygwin64$ uname -s
CYGWIN_NT-6.1

cygwin64$ uname -m
x86_64

cygwin32$ uname -s
CYGWIN_NT-6.1-WOW64

cygwin32$ uname -m
i686

Yep, seems redundant.

--
Chuck


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Christopher Faylor]

On Thu, Jul 04, 2013 at 02:16:17PM +0200, Corinna Vinschen wrote:
>On Jul  4 13:45, Alexey Pavlov wrote:
>> 2013/7/4 Corinna Vinschen:
>> > On Jul  4 14:23, Alexey Pavlov wrote:
>> >> 2013/7/4 Corinna Vinschen:
>> >> > On Jul  4 12:37, Alexey Pavlov wrote:
>> >> >> 2013/7/4 Corinna Vinschen:
>> >> >> > On Jul  4 13:09, Alexey Pavlov wrote:
>> >> >> >>  struct utsname
>> >> >> >>  {
>> >> >> >> -  char sysname[20];
>> >> >> >> +  char sysname[21];
>> >> >> >
>> >> >> > We can't do that.  struct utsname is a publically facing structure.
>> >> >> > If you change the size, you're breaking compatibility with existing
>> >> >> > applications.
>> >> >> >
>> >> >> > You should better drop some character from the string you want to enter
>> >> >> > here.
>> >> >> >
>> >> >>
>> >> >> I can't drop any symbol from "MINGW32" word :)
>> >> >
>> >> > That's not 20 chars long.
>> >> >
>> >> Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
>> >>
>> >> CYGWIN_NT-6.1-WOW64\0
>> >>
>> >> But
>> >>
>> >> MINGW32_NT-6.1-WOW64\0
>> >>
>> >> is 21 symbol.
>> >
>> > Then drop the dash between "NT" and "6.1".  Or let's drop the WOW64
>> > since it's redundant anyway, given the content of "machine".
>> >
>> 
>> Let's drop it!
>
>I'm ok with that, but I think we should drop the "32" from MINGW in
>the first place.
>
>Does anybody rely on the "WOW64" in uname -s output?  I just checked
>the scripts in /bin in my installation and none of it seems to check
>for that info.
>
>And then again, it *is* redundant, given the uname -m output...

Can we back up a moment and discuss whether, regardless of string
length, this is the right approach?  This isn't what I'd envisioned
when I said "hooks".

Also can we please discuss this in the cygwin-developers and
cygwin-patches mailing lists?  That's what they are for.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[BGINFO4X]

Hello,

Regarding to the fstab format, I don't know if it is supported, but it
would be nice to support Environment Variables.

For example, Instead of:
C:/Users    /desktop

Use:
%USERPROFILE% /desktop

It is only a suggestion/example.

Regards.

##############

>>> >> >> >>  {
>>> >> >> >> -  char sysname[20];
>>> >> >> >> +  char sysname[21];
>>> >> >> >
>>> >> >> > We can't do that.  struct utsname is a publically facing structure.
>>> >> >> > If you change the size, you're breaking compatibility with existing
>>> >> >> > applications.
>>> >> >> >
>>> >> >> > You should better drop some character from the string you want to enter
>>> >> >> > here.
>>> >> >> >
>>> >> >>
>>> >> >> I can't drop any symbol from "MINGW32" word :)
>>> >> >
>>> >> > That's not 20 chars long.
>>> >> >
>>> >> Yes. But not only this need to be in 20 symbols. On cygwin 20 symbols is:
>>> >>
>>> >> CYGWIN_NT-6.1-WOW64\0
>>> >>
>>> >> But
>>> >>
>>> >> MINGW32_NT-6.1-WOW64\0
>>> >>
>>> >> is 21 symbol.
>>> >
>>> > Then drop the dash between "NT" and "6.1".  Or let's drop the WOW64
>>> > since it's redundant anyway, given the content of "machine".
>>> >
>>>
>>> Let's drop it!
>>
>>I'm ok with that, but I think we should drop the "32" from MINGW in
>>the first place.
>>
>>Does anybody rely on the "WOW64" in uname -s output?  I just checked
>>the scripts in /bin in my installation and none of it seems to check
>>for that info.
>>
>>And then again, it *is* redundant, given the uname -m output...
>
> Can we back up a moment and discuss whether, regardless of string
> length, this is the right approach?  This isn't what I'd envisioned
> when I said "hooks".
>
> Also can we please discuss this in the cygwin-developers and
> cygwin-patches mailing lists?  That's what they are for.
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

RE: MSYS mode (continue)

[Buchbinder, Barry (NIH/NIAID) [E]]

BGINFO4X sent the following at Tuesday, July 09, 2013 6:39 AM
>Regarding to the fstab format, I don't know if it is supported, but it
>would be nice to support Environment Variables.
>
>For example, Instead of: C:/Users /desktop
>
>Use: %USERPROFILE% /desktop
>
>It is only a suggestion/example.

As long as we're making suggestions about environmental variables.

http://cygwin.com/ml/cygwin/2010-01/msg00977.html

- Barry
  Disclaimer: Statements made herein are not made on behalf of NIAID.


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  4 13:07, Alexey Pavlov wrote:
> 2013/7/4 Corinna Vinschen:
> > Hi Alexey,
> >
> > On Jul  4 06:33, Alexey Pavlov wrote:
> >> My opinion is to extend Cygwin parser to read msys-like mounts. It's
> >> very simple:
> >>
> >> --- mount.cc 2013-04-24 20:29:29.000000000 +0400
> >> +++ Cygwin/winsup/cygwin/mount.cc 2013-06-13 09:35:01.479492100 +0400
> >> @@ -1125,8 +1118,17 @@
> >>    if (!*c)
> >>      return true;
> >>    cend = find_ws (c);
> >> -  *cend = '\0';
> >>    posix_path = conv_fstab_spaces (c);
> >> +  if (!*cend)
> >> +   {
> >> +     unsigned mount_flags = MOUNT_SYSTEM | MOUNT_BINARY |
> >> MOUNT_NOPOSIX | MOUNT_NOACL;
> >> +
> >> +     int res = mount_table->add_item (native_path, posix_path, mount_flags);
> >> +     if (res && get_errno () == EMFILE)
> >> +       return false;
> >> +     return true;
> >> +   }
> >> +  *cend = '\0';
> >>    /* Third field: FS type. */
> >>    c = skip_ws (cend + 1);
> >>    if (!*c)
> >
> > This patch is trivial enough to go in (barring discussion) without
> > copyright assignment.   Still, the CA is necessary for more complex
> > patches.
> >
> Good.
> 
> > Would you mind to send a CA (http://cygwin.com/assign.txt) per snail
> > mail to the address given in the form?
> >
> I will do it in a week I think.

Yep, no worries.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Corinna Vinschen]

On Jul  3 17:57, Christopher Faylor wrote:
> On Wed, Jul 03, 2013 at 05:03:04PM -0400, Charles Wilson wrote:
> >On 7/3/2013 3:50 PM, Corinna Vinschen wrote:
> >> On Jul  3 22:24, Alexey Pavlov wrote:
> >>> 2013/7/3 Christopher Faylor:
> >>> I need it to be able read short mount points from fstab: <win32_path>
> >>> <posix_path>.
> >>> All other options are set by default. With my changes I can have in
> >>> /etc/fstab both types of mount points - cygwin-like and msys-like.
> >>
> >> And why is that necessary?  There are always default options set anyway,
> >> but a layout change of the fstab file simply makes no sense.  There's no
> >> win at all.
> >
> >I think Alexey is trying to replicate MSYS's behavior, so it becomes 
> >more of a drop-in replacement.  Here's my MSYS /etc/fstab (MSYS doesn't 
> >yet support per-user fstab.d/username settings):
> >
> >C:/MinGW               /mingw
> >C:/Users/me/Desktop    /desktop
> >C:/Users/me/Documents  /docs
> >C:/msys-src            /usr/src
> 
> I think Cygwin fstab parsing could be loosened up to allow that syntax.

I didn't realize there's a backward compatibility problem.  Well, if you
think that's ok, we can take Alexey's patch and add a few words to the
docs about the simplified fstab syntax and the default option settings.
Fortunately it weould work independently of the environment, Cygwin or
MSYS2.  The patch is trivial enough to go in w/o CA, too.

> >Your MSYS-like cygwin installation would have its own /etc/fstab (in 
> >regular cygwin format), but perhaps your /home area is mapped 
> >differently in that fstab, than in the /etc/fstab in your "regular" 
> >cygwin installation.  Or, like me, I have a separate msys-src and 
> >cygwin-src directory mapped onto MSYS's /usr/src and cygwin's /usr/src, 
> >respectively.
> >
> >Or is the proposal on the table for the same installation to be usable 
> >in both modes, depending on the nature of the launched application?
> 
> That's an interesting idea but I don't think anyone was proposing that.

Any suggestion how this could work?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: MSYS mode (continue)

[Charles Wilson]

On 7/4/2013 4:38 AM, Corinna Vinschen wrote:
> On Jul  3 17:57, Christopher Faylor wrote:
>> On Wed, Jul 03, 2013 at 05:03:04PM -0400, Charles Wilson wrote:
>>> Or is the proposal on the table for the same installation to be usable
>>> in both modes, depending on the nature of the launched application?
>>
>> That's an interesting idea but I don't think anyone was proposing that.
>
> Any suggestion how this could work?

Badly, now that I think about it.  Say you're in cygwin-proper bash 
session, and you launch a cygwin-msys-linked exe, or a native tool -- 
and pass a pathname to it as an argument. How is it interpreted -- using 
which fstab?

No, forget I said anything.

--
Chuck



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple