From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96955 invoked by alias); 8 Feb 2016 16:10:17 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 96933 invoked by uid 89); 8 Feb 2016 16:10:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:suFuu-J, H*f:DF9FzH1, Hx-languages-length:2027, H*f:sk:3nVujGH X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 08 Feb 2016 16:10:11 +0000 Received: by mail-wm0-f45.google.com with SMTP id g62so123231179wme.0 for ; Mon, 08 Feb 2016 08:10:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=LG4E+OEgWthlNyT4Rjv//hwl4PPexC0bVWGcWDI6RJ8=; b=MS4QUHxauq2pMRpnHrArcVHIz6ibSWxCrV4SKRltJ5eQPAa/ZQ4cI6cJooe2qP2yho xQxuH977yf9d4pQ9VnsdEt3u/x3utlnwsjnm/VrmCQNbY+CeJb7DWTmm35YzWpsRs9M0 deUryr6/dvPbwB84MVIi7jGTF7C9LOaYjVVivYm2Nv/ySLyBSpmT2YJZqx0wu6F+xCTU fetu8Q62lZLbuDnHrDydM1Sm4lkM7blPrG1R1/yGiGgo9rDIp1dhquPGbYC91GIhm7gQ FbT5vEqHJFppJtgmKH8Ks34iCpny2PHTwTwYfDfcmXT1mg7K1/E6IXIcmhoVHbTJkEBh UawA== X-Gm-Message-State: AG10YORtFzGiP6GUWCez7HMLNRNhpL6q/ensQGVPzDr0STpFoNGgZvx6VZ7h/nCMBuDx2uTXHenmL/7R/kKqQg== X-Received: by 10.194.246.134 with SMTP id xw6mr27740930wjc.158.1454947808534; Mon, 08 Feb 2016 08:10:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.63.130 with HTTP; Mon, 8 Feb 2016 08:09:38 -0800 (PST) In-Reply-To: <20160208143630.GG12975@calimero.vinschen.de> References: <20160208131835.GC12975@calimero.vinschen.de> <20160208141015.GD12975@calimero.vinschen.de> <20160208143630.GG12975@calimero.vinschen.de> From: Ismail Donmez Date: Mon, 08 Feb 2016 16:10:00 -0000 Message-ID: Subject: Re: Problem with new acl code and cdrtools To: cygwin@cygwin.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00080.txt.bz2 On Mon, Feb 8, 2016 at 4:36 PM, Corinna Vinschen wrote: > On Feb 8 16:13, Ismail Donmez wrote: >> On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen >> wrote: >> > On Feb 8 15:31, Ismail Donmez wrote: >> >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen >> >> wrote: >> >> > On Feb 8 12:01, Ismail Donmez wrote: >> >> >> Hi, >> >> >> >> >> >> cdrtools has some code to detect Solaris style ACLs: >> >> >> >> >> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ >> >> >> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) >> >> >> # define HAVE_SUN_ACL 1 /* Sun UFS ACL's present */ >> >> >> #endif >> >> >> >> >> >> Since cygwin still seems to be defining aclfromtext() and acltotext() >> >> >> functions (which are not defined in POSIX) cdrtools thinks this a >> >> >> Solaris-style system and get up getting a compile error later on. >> >> > >> >> > Probably due to including sys/acl.h. Does swtiching to cygwin/acl.h >> >> > help? Or changing the above check to prefer POSIX ACLs over Solaris >> >> > ACLs? >> >> >> >> This is a generic code so I don't want to add a cygwin specific >> >> dependency there. Is there a preprocessor definition for cygwin >> >> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+ >> > >> > If you include cygwin/version.h you could use the version definitions. >> > >> > Alternatively we could allow to use the Solaris ACL functions even if >> > only including sys/acl.h, given some macro: >> > >> > sys/acl.h: >> > >> > #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS >> > # include >> > #else >> > [...POSIX definitions...] >> > #endif >> > >> > Would that help? >> >> That should help, I cook a patch and send to cdrecord maintainer. > > Wait, that's a bit premature. I'm not even sure yet if the macro name > is ok. I thought the macro already exissts sorry. But, again I would prefer a __cygwin_version__ macro anyway. Thanks, ismail -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple