From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22266 invoked by alias); 8 Feb 2016 14:14:09 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 22256 invoked by uid 89); 8 Feb 2016 14:14:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=cook, sk:__use_o, version.h, versionh X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 08 Feb 2016 14:14:03 +0000 Received: by mail-wm0-f54.google.com with SMTP id g62so134504577wme.0 for ; Mon, 08 Feb 2016 06:14:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=4XRPENxAzd8k8I95kgpAUEP3wDMLT9ObBEz2UjGyUFM=; b=FXIQC8xFK4SrpoEs/m9TFkPjzj21xedO9H4RC3MPnbmII9aCgSFd1QEAhZ9yT+5a9h 2N7PajEdpiULx27MlaAxZ4UG6aAE003uPCnPkJR0St1XEBUuOBGJI9mOK/5pw7Woiznt 188F893MbUfAqZiXT0JagS13eRVSaOD8J33WdTnTQHVFrowr/XK0TO6mMrq15y28yUZb 9CjkTX/0eGyqUON78e+AxQnKkdZMqFcCTHjO6CD1l5uLRk+jDOVtC8chyFJ4Zd3xOnra 7dPbhrpfkWyd/jcyW9IgY5lAFCFevSOZ9eVKoGAXNnq1DlWUhC8hYIVkVHtEu9AiMDA9 k6WQ== X-Gm-Message-State: AG10YOQxXBq2FAjA/02Llz0tee8u3mxeavujfXpmTyh3fzEENhbBx9aveizEvMlhmFAvqFIt+xPekw//5eHs/g== X-Received: by 10.194.192.198 with SMTP id hi6mr28033406wjc.141.1454940840309; Mon, 08 Feb 2016 06:14:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.63.130 with HTTP; Mon, 8 Feb 2016 06:13:30 -0800 (PST) In-Reply-To: <20160208141015.GD12975@calimero.vinschen.de> References: <20160208131835.GC12975@calimero.vinschen.de> <20160208141015.GD12975@calimero.vinschen.de> From: Ismail Donmez Date: Mon, 08 Feb 2016 14:14:00 -0000 Message-ID: Subject: Re: Problem with new acl code and cdrtools To: cygwin@cygwin.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00076.txt.bz2 On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen wrote: > On Feb 8 15:31, Ismail Donmez wrote: >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen >> wrote: >> > On Feb 8 12:01, Ismail Donmez wrote: >> >> Hi, >> >> >> >> cdrtools has some code to detect Solaris style ACLs: >> >> >> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ >> >> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) >> >> # define HAVE_SUN_ACL 1 /* Sun UFS ACL's present */ >> >> #endif >> >> >> >> Since cygwin still seems to be defining aclfromtext() and acltotext() >> >> functions (which are not defined in POSIX) cdrtools thinks this a >> >> Solaris-style system and get up getting a compile error later on. >> > >> > Probably due to including sys/acl.h. Does swtiching to cygwin/acl.h >> > help? Or changing the above check to prefer POSIX ACLs over Solaris >> > ACLs? >> >> This is a generic code so I don't want to add a cygwin specific >> dependency there. Is there a preprocessor definition for cygwin >> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+ > > If you include cygwin/version.h you could use the version definitions. > > Alternatively we could allow to use the Solaris ACL functions even if > only including sys/acl.h, given some macro: > > sys/acl.h: > > #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS > # include > #else > [...POSIX definitions...] > #endif > > Would that help? That should help, I cook a patch and send to cdrecord maintainer. Thanks a lot. ismail -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple