From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116855 invoked by alias); 8 Feb 2016 13:31:44 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 116842 invoked by uid 89); 8 Feb 2016 13:31:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=getfacl, aclh, UD:acl.h, acl.h X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 08 Feb 2016 13:31:42 +0000 Received: by mail-wm0-f45.google.com with SMTP id c200so15643718wme.0 for ; Mon, 08 Feb 2016 05:31:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=ekot3IFe1ZcpugQymJOSN1JN9c5Z2/c5jo4E1jFfPaU=; b=UlRnT3c/oa0Z4fnPGcVB59kjUu/AyoHWTT8Ejryarx5ealaDYglTK/smZ2g192LiIO 606fqH5Pt2YlMJwypeS7LpkQ1GdG35lly/IX8F+xjr9i1E7428Ry3GWN8esr4TXNIkaO ZjiG31mH8JuySRLncWq0JCvgao+KQsLmF9dAMBalSKLjuahwACHdHD9P788EJ7lkI958 LjAvx5aESYr0Vdo8Rz07naVGgAIIv/ddXr+zjoPtBKYCFgQLozkYtSkOQl8J5yeeQtB2 C7A0hJFlsnj8v2OhukJpeT68qhgQZcdkgVKlCbjxqkBGnSHM/w593Kmg3os1nB01P8OQ le4Q== X-Gm-Message-State: AG10YORKaAM9UPXTLK663C/Qliig7ZtvmdwVrbDNNoSJyUGYaITxHxZwwnHVytrmRNj8x8xNLr1aBoVtb0jq3g== X-Received: by 10.194.192.198 with SMTP id hi6mr27819850wjc.141.1454938299407; Mon, 08 Feb 2016 05:31:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.63.130 with HTTP; Mon, 8 Feb 2016 05:31:09 -0800 (PST) In-Reply-To: <20160208131835.GC12975@calimero.vinschen.de> References: <20160208131835.GC12975@calimero.vinschen.de> From: Ismail Donmez Date: Mon, 08 Feb 2016 13:31:00 -0000 Message-ID: Subject: Re: Problem with new acl code and cdrtools To: cygwin@cygwin.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00073.txt.bz2 On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen wrote: > On Feb 8 12:01, Ismail Donmez wrote: >> Hi, >> >> cdrtools has some code to detect Solaris style ACLs: >> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ >> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) >> # define HAVE_SUN_ACL 1 /* Sun UFS ACL's present */ >> #endif >> >> Since cygwin still seems to be defining aclfromtext() and acltotext() >> functions (which are not defined in POSIX) cdrtools thinks this a >> Solaris-style system and get up getting a compile error later on. > > Probably due to including sys/acl.h. Does swtiching to cygwin/acl.h > help? Or changing the above check to prefer POSIX ACLs over Solaris > ACLs? This is a generic code so I don't want to add a cygwin specific dependency there. Is there a preprocessor definition for cygwin version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+ > >> Since we are switching to POSIX ACLs it would be nice to remove >> Solaris-only ACL functions. > > We can't do that for backward compatibility. The Solaris function > have to stay available, not the least for Cygwin's getfacl/setfacl > which still use them. I see, thanks. ismail -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple