public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Reini Urban <rurban@x-ray.at>
To: "Yaakov (Cygwin/X)" <yselkowitz@users.sourceforge.net>
Cc: cygwin@cygwin.com
Subject: Re: perl-5.14.2 switch
Date: Tue, 10 Jul 2012 23:52:00 -0000	[thread overview]
Message-ID: <CAHiT=DER6DrKrPEuxD5Be0R-FAm5+iyGsTQWKLjct50-3D_-3A@mail.gmail.com> (raw)
In-Reply-To: <CAGvSfewxbyzmZCKcd7mmqO2tC1Nhsqbc2sVyK=tqWQaQuyFqDw@mail.gmail.com>

On Tue, Jul 10, 2012 at 6:10 PM, Yaakov (Cygwin/X) wrote:
> On Tue, Jul 10, 2012 at 5:36 PM, Reini Urban wrote:
>> On Tue, Jul 10, 2012 at 3:56 PM, Yaakov (Cygwin/X) wrote:
>>> Your rebase pure_install changes in EU::MM_Cygwin do not take DESTDIR
>>> into account, breaking cygport.  Line 195 of said module needs to be
>>> changed to (as one long line):
>>>[snip]
>>
>> Great find!
>>
>> I've completed my remaining deps also, so only Volker is missing with one.
>
> I doubt perl-ming is used by many, so if Volker is busy, let's not wait for it.
>
>> I'll fix this and do the switch ASAP.
>> Thanks.
>
> Found another problem which breaks gtk2-perl modules (which link
> against each other).  The following change needs to be made in
> ExtUtils::Liblist::Kid::_unix_os2_ext(), line 135:
>
> -                 && -f ($fullname="$thispth/lib$thislib.$Config_dlext")) {
> +                 && -f ($fullname="$thispth/$thislib.$Config_dlext")) {
>
> I have made this change locally and am continuing the rebuild for Ports.

I do not really understand. A few lines below we check for this case
            elsif ( -f ( $fullname = "$thispth/$thislib.dll" ) ) {
            }
and skip then.
Is there a corner-case case where you have a lib<name>.dll and no <name>.dll,
and lib<name>.dll should not be linked against?

I've also found one more, so I will switch tomorrow. It needs more tests.

--- ./usr/lib/perl5/5.14/ExtUtils/MM_Cygwin.pm~	2012-07-10
18:24:11.977053200 -0500
+++ ./usr/lib/perl5/5.14/ExtUtils/MM_Cygwin.pm	2012-07-10
18:29:50.461428200 -0500
@@ -189,8 +189,8 @@
     my ($rebasever) = $rebaseverstr =~ /rebase version ([0-9.]+)/;
     $rebasever =~ s/(\d\.\d+)\./$1/;
     if ($rebasever > 3.01) {  # new rebase 3.0.2 with database
	my $INSTALLDIRS = $self->{INSTALLDIRS};
-      my $INSTALLLIB = $self->{"INSTALL".uc($INSTALLDIRS)."ARCH"};
+      my $INSTALLLIB = $self->{"INSTALL". ($INSTALLDIRS eq 'perl' ?
'ARCHLIB' : uc($INSTALLDIRS)."ARCH")};
       my $dll =
"$INSTALLLIB/auto/$self->{FULLEXT}/$self->{BASEEXT}.$self->{DLEXT}";
       $s =~ s|^(pure_install ::
pure_\$\(INSTALLDIRS\)_install\n\t)\$\(NOECHO\)
\$\(NOOP\)\n|$1\$(CHMOD) \$(PERM_RWX) \$(DESTDIR)$dll\n\t/bin/rebase
-s \$(DESTDIR)$dll\n|m;
     }

-- 
Reini Urban
http://cpanel.net/   http://www.perl-compiler.org/

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  reply	other threads:[~2012-07-10 23:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 18:01 Reini Urban
2012-07-10 20:56 ` Yaakov (Cygwin/X)
2012-07-10 22:36   ` Reini Urban
2012-07-10 23:10     ` Yaakov (Cygwin/X)
2012-07-10 23:52       ` Reini Urban [this message]
2012-07-11  2:20         ` Yaakov (Cygwin/X)
2012-07-11  2:31           ` Reini Urban
2012-07-11  3:02             ` Yaakov (Cygwin/X)
2012-07-11  7:31 ` Dr. Volker Zell
2012-07-11  9:53 ` Yaakov (Cygwin/X)
2012-07-11 15:08   ` Reini Urban
2012-07-11 16:27     ` Steven Hartland
2012-07-11 17:01       ` Achim Gratz
2012-07-11 17:45         ` Steven Hartland
2012-07-11 18:30           ` Achim Gratz
2012-07-11 23:10             ` Steven Hartland
2012-07-12  5:20               ` Achim Gratz
2012-07-12 15:24                 ` Reini Urban
2012-07-12 16:15                   ` Corinna Vinschen
2012-07-12 16:50                     ` Reini Urban
2012-07-12 18:40     ` Yaakov (Cygwin/X)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHiT=DER6DrKrPEuxD5Be0R-FAm5+iyGsTQWKLjct50-3D_-3A@mail.gmail.com' \
    --to=rurban@x-ray.at \
    --cc=cygwin@cygwin.com \
    --cc=yselkowitz@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).