bash: '\n' after command substitution in $PS1 causes errors when igncr is set

bash: '\n' after command substitution in $PS1 causes errors when igncr is set

[Ken Takata]

[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]

Hello all,

I originally reported this issue to the msys2 team:
https://github.com/msys2/MSYS2-packages/issues/1839
https://github.com/msys2/MSYS2-packages/pull/4477
But I find that this issue is coming from Cygwin Bash, so I'm reporting
here.

When I use \n after command substitution in $PS1, it causes syntax errors
when the igncr option is set:
```
$ set -o igncr
$ PS1='$(date)\n\$ '
-bash: command substitution: line 1: syntax error near unexpected token `)'
-bash: command substitution: line 1: `date)'
```
(Confirmed with bash-5.2.21-1)

I found an issue in rewind_input_string() in parse.y. It didn't take care
of '\r'.
Please find the attached patch to fix it.
Could you consider merging this into bash-5.2-cygwin.patch?

Regards,
Ken Takata

[-- Attachment #2: bash-5.2-cygwin-fix-igncr.patch --]
[-- Type: application/octet-stream, Size: 534 bytes --]

--- a/parse.y
+++ b/parse.y
@@ -1684,7 +1684,16 @@
      into account, e.g., $(...\n) */
   xchars = shell_input_line_len - shell_input_line_index;
   if (bash_input.location.string[-1] == '\n')
-    xchars++;
+    {
+      xchars++;
+#ifdef __CYGWIN__
+      {
+	extern int igncr;
+	if (igncr && bash_input.location.string[-2] == '\r')
+	  xchars++;
+      }
+#endif
+    }
 
   /* XXX - how to reflect bash_input.location.string back to string passed to
      parse_and_execute or xparse_dolparen? xparse_dolparen needs to know how