Re: scandirat return dirents of parent dir

Re: scandirat return dirents of parent dir

[comic fans]

I've already submitted a patch for this but your fix is much
quicker... confirmed this snapshot resolved the problem. Thank you.
>> Hello:
>>      I've found this problem when compile
>> casync(https://github.com/systemd/casync.git) in cygwin,workflow to
>> trigger this :
>>     rootfd=open(".",O_CLOEXEC|O_RDONLY|O_NOCTTY);
>>     scandirat(rootfd,".", firstLevelDirEnts......);
>>     foreach dirent in firstLevelDirEnts:
>>          if dirent is dir:
>>              subdirfd=openat(rootfd,
>>                   dirent->d_name,O_RDONLY|O_CLOEXEC|O_NOCTTY|O_NOFOLLOW);
>>              scandirat(subdirfd,".",  secondLevelDirEnts......);
>>
>>      at this time, secondLevelDirEnts should be files in subdir, but
>> in cygwin, secondLevelDirEnts is just same as firstLevelDirEnts.
>>
>>       This problem didn't happen in linux , nor win10 WSL,  but
>> happens in both cygwin/msys2.
>
>First I thought you stumbled over the problem that the first two entries
>returned by scandirat are "." and "..", but on closer investigation I
>saw the problem.
>
>I pushed a fix to the git repo and uploaded new developer snapshots
>to https://cygwin.com/snapshots/  Please try.
>
>
>Thanks,
>Corinna
>
>--

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: scandirat return dirents of parent dir

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

On Jul  5 05:38, comic fans wrote:
> I've already submitted a patch for this but your fix is much
> quicker... confirmed this snapshot resolved the problem. Thank you.
> >> Hello:
> >>      I've found this problem when compile
> >> casync(https://github.com/systemd/casync.git) in cygwin,workflow to
> >> trigger this :
> >>     rootfd=open(".",O_CLOEXEC|O_RDONLY|O_NOCTTY);
> >>     scandirat(rootfd,".", firstLevelDirEnts......);
> >>     foreach dirent in firstLevelDirEnts:
> >>          if dirent is dir:
> >>              subdirfd=openat(rootfd,
> >>                   dirent->d_name,O_RDONLY|O_CLOEXEC|O_NOCTTY|O_NOFOLLOW);
> >>              scandirat(subdirfd,".",  secondLevelDirEnts......);
> >>
> >>      at this time, secondLevelDirEnts should be files in subdir, but
> >> in cygwin, secondLevelDirEnts is just same as firstLevelDirEnts.
> >>
> >>       This problem didn't happen in linux , nor win10 WSL,  but
> >> happens in both cygwin/msys2.
> >
> >First I thought you stumbled over the problem that the first two entries
> >returned by scandirat are "." and "..", but on closer investigation I
> >saw the problem.
> >
> >I pushed a fix to the git repo and uploaded new developer snapshots
> >to https://cygwin.com/snapshots/  Please try.

I only saw your patch on cygwin-patches hours later, sorry.

Thanks for testing!


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

scandirat return dirents of parent dir

[comic fans]

Hello:
     I've found this problem when compile
casync(https://github.com/systemd/casync.git) in cygwin,workflow to
trigger this :
    rootfd=open(".",O_CLOEXEC|O_RDONLY|O_NOCTTY);
    scandirat(rootfd,".", firstLevelDirEnts......);
    foreach dirent in firstLevelDirEnts:
         if dirent is dir:
             subdirfd=openat(rootfd,
                  dirent->d_name,O_RDONLY|O_CLOEXEC|O_NOCTTY|O_NOFOLLOW);
             scandirat(subdirfd,".",  secondLevelDirEnts......);

     at this time, secondLevelDirEnts should be files in subdir, but
in cygwin, secondLevelDirEnts is just same as firstLevelDirEnts.

      This problem didn't happen in linux , nor win10 WSL,  but
happens in both cygwin/msys2.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: scandirat return dirents of parent dir

[Thomas Wolff]

On 04.07.2017 13:09, comic fans wrote:
> Hello:
>       I've found this problem when compile
> casync(https://github.com/systemd/casync.git) in cygwin,workflow to
> trigger this :
>      rootfd=open(".",O_CLOEXEC|O_RDONLY|O_NOCTTY);
>      scandirat(rootfd,".", firstLevelDirEnts......);
>      foreach dirent in firstLevelDirEnts:
>           if dirent is dir:
>               subdirfd=openat(rootfd,
>                    dirent->d_name,O_RDONLY|O_CLOEXEC|O_NOCTTY|O_NOFOLLOW);
>               scandirat(subdirfd,".",  secondLevelDirEnts......);
>
>       at this time, secondLevelDirEnts should be files in subdir, but
> in cygwin, secondLevelDirEnts is just same as firstLevelDirEnts.
>
>        This problem didn't happen in linux , nor win10 WSL,  but
> happens in both cygwin/msys2.
It would be nice to provide a complete, compilable test case, please.
It is unclear what you mean by "secondLevelDirEnts is just same" because 
that's different things inside a loop.
Did you consider that one of the entries is ".."?

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: scandirat return dirents of parent dir

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On Jul  4 19:09, comic fans wrote:
> Hello:
>      I've found this problem when compile
> casync(https://github.com/systemd/casync.git) in cygwin,workflow to
> trigger this :
>     rootfd=open(".",O_CLOEXEC|O_RDONLY|O_NOCTTY);
>     scandirat(rootfd,".", firstLevelDirEnts......);
>     foreach dirent in firstLevelDirEnts:
>          if dirent is dir:
>              subdirfd=openat(rootfd,
>                   dirent->d_name,O_RDONLY|O_CLOEXEC|O_NOCTTY|O_NOFOLLOW);
>              scandirat(subdirfd,".",  secondLevelDirEnts......);
> 
>      at this time, secondLevelDirEnts should be files in subdir, but
> in cygwin, secondLevelDirEnts is just same as firstLevelDirEnts.
> 
>       This problem didn't happen in linux , nor win10 WSL,  but
> happens in both cygwin/msys2.

First I thought you stumbled over the problem that the first two entries
returned by scandirat are "." and "..", but on closer investigation I
saw the problem.

I pushed a fix to the git repo and uploaded new developer snapshots
to https://cygwin.com/snapshots/  Please try.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]