public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Ivan Gagis <igagis@gmail.com>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: The Cygwin Mailing List <cygwin@cygwin.com>
Subject: Re: mksetupini fails validating packages because curr is test
Date: Thu, 30 Nov 2017 22:16:00 -0000	[thread overview]
Message-ID: <CAL_02JCSUXQ_gLbdKSxNaNXaDkWMKmgY_ntG-vjpchM2GpWT-w@mail.gmail.com> (raw)
In-Reply-To: <8690f394-94f0-58ad-8a6b-8067edabc9d5@dronecode.org.uk>

Hi Jon,

Thanks for prompt actions!

I think no need to package it separately for testing, just release it
to cygwin repo.

Yes, I understand that there always is a human factor, this is why I
do all my building, version bumping up and deployment automatically by
scripts, so this check seems unnecessary in my case and good that it
can be turned off now.

Br,
Ivan

2017-11-30 14:41 GMT+02:00 Jon Turney <jon.turney@dronecode.org.uk>:
> On 30/11/2017 09:28, Ivan Gagis wrote:
>>
>> I use git repository on github to store the files. And to update it I
>> clone the repo, run mksetupini and then commit and push.
>> So, I'm not sure what actually is going on with mtime of the files
>> there. Perhaps git messes up the mtime of cloned files.
>
>
> Yes, a git checkout will have the mtime of the checkout.
>
> I've pushed an update to the calm repo with these changes:
>
> - mksetupini and calm now exit with non-zero exit status on an error
> - Fixes a bug where equal mtime was considered newer
> - Adds 'mksetupini --disable-check=curr-most-recent' option to turn off this
> check
>
> Do I need to package this for you to test it?
>
>> But why is this check of mtime needed at all? Isn't version number
>> enough for tracking earlier-later files?
>
>
> Maybe this doesn't make much sense in the context of mksetupini, but this is
> a useful check for calm to make.
>
> People make mistakes.
>
> People also forget the subtleties of how version numbers sort and upload
> versions which aren't greater than the current version, when they think they
> are...

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  reply	other threads:[~2017-11-30 22:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 15:07 Ivan Gagis
2017-11-29 16:52 ` Jon Turney
     [not found]   ` <CAL_02JC8t9TM6bRyrovCVJRv+pogdn+fNH7kv8ha016XZw0irA@mail.gmail.com>
2017-11-29 22:13     ` Jon Turney
2017-11-30  9:29       ` Ivan Gagis
2017-11-30 12:41         ` Jon Turney
2017-11-30 22:16           ` Ivan Gagis [this message]
2017-12-01 11:00             ` Jon Turney
2017-12-04 12:02               ` Ivan Gagis
2017-12-04 14:00                 ` Jon Turney
2017-12-04 16:57                   ` Ivan Gagis
2017-11-30 18:11         ` Wayne Davison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_02JCSUXQ_gLbdKSxNaNXaDkWMKmgY_ntG-vjpchM2GpWT-w@mail.gmail.com \
    --to=igagis@gmail.com \
    --cc=cygwin@cygwin.com \
    --cc=jon.turney@dronecode.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).