From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88610 invoked by alias); 8 Sep 2015 05:54:48 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 88601 invoked by uid 89); 8 Sep 2015 05:54:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_20,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f181.google.com Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 08 Sep 2015 05:54:45 +0000 Received: by wicfx3 with SMTP id fx3so106746291wic.1 for ; Mon, 07 Sep 2015 22:54:42 -0700 (PDT) X-Received: by 10.180.75.243 with SMTP id f19mr41584499wiw.52.1441691682689; Mon, 07 Sep 2015 22:54:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.144.196 with HTTP; Mon, 7 Sep 2015 22:54:02 -0700 (PDT) Reply-To: fracting@gmail.com In-Reply-To: <55EE66E1.3000908@dwalin.fsnet.co.uk> References: <55EE66E1.3000908@dwalin.fsnet.co.uk> From: Qian Hong Date: Tue, 08 Sep 2015 05:54:00 -0000 Message-ID: Subject: Re: Question about flock - potential memory corruption? To: cygwin Content-Type: multipart/mixed; boundary=f46d0438951b9fa24c051f360045 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00120.txt.bz2 --f46d0438951b9fa24c051f360045 Content-Type: text/plain; charset=UTF-8 Content-length: 1291 Hi Sam, Thank you very much for your reply! On Tue, Sep 8, 2015 at 12:41 PM, Sam Edge wrote: > Erm ... slight technical hitch? Your example flock.c doesn't call > fork(), nor does it use your two macros MAX_ITER & CHILDREN. Good question. This problem was originally found when running autom4te on Wine. In autom4te-2.69, we have: 68 my $flock_implemented = 'yes'; 982 $icache_file = new Autom4te::XFile $icache, O_RDWR|O_CREAT; 983 $icache_file->lock (LOCK_EX) 984 if ($flock_implemented eq "yes"); This cause problem on Wine on some machine, while it works fine on some other machine. After tracking down, I successfully reproduce the problem with Cygwin using the attached test case stc-flock-fork-2.c, which is changed based on another test case from an old cygwin mailing list archive [1]. Later then, I found that even without fork(), we can still reproduce the same problem, Valgrind + Wine shows same warning either with or without fork, so I simply the test case a bit further, that's why you didn't see fork in my test case. Thank for your comment, it's good to make things clearer to everybody. Any further comment is welcome! [1] https://www.cygwin.com/ml/cygwin/2011-08/txt00012.txt -- Regards, Qian Hong - http://www.winehq.org --f46d0438951b9fa24c051f360045 Content-Type: text/x-csrc; charset=US-ASCII; name="stc-flock-fork-2.c" Content-Disposition: attachment; filename="stc-flock-fork-2.c" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ieaxqzf10 Content-length: 3396 LyoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqCiAqIFRoaXMgaXMgYSBTVEMg dGhhdCBjYXVzZXMgdGhlIGZvbGxvd2luZyBlcnJvciBvbiBteSB0ZXN0IG1h Y2hpbmU6CiAqICAgTnRDcmVhdGVFdmVudChsb2NrKTogMHhDMDAwMDAzNQog KgogKiBJdCB0cmllcyB0byB1c2UgZmxvY2soKSBmb3IgZmlsZSBsb2NraW5n LiBJdCBjcmVhdGVzIGEgdGVtcG9yYXJ5CiAqIGZpbGUsIHRoZSB1c2VzIGZv cmsgdG8gc3Bhd24gYSBudW1iZXIgb2YgY2hpbGRyZW4uIEVhY2ggY2hpbGQg b3BlbnMKICogdGhlIGZpbGUsIHRoZW4gcmVwZWF0ZWRseSB1c2VzIGZsb2Nr IHRvIGxvY2sgYW5kIHVubG9jayBpdC4KICoKICogVGhpcyB0ZXN0IHdhcyBl eHRyYWN0ZWQgZnJvbSB0aGUgQVBSIHRlc3Qgc3VpdGUuCiAqCiAqIENvbXBp bGU6IGdjYyAtV2FsbCAtbyBzdGMtZmxvY2stZm9yayBzdGMtZmxvY2stZm9y ay5jCiAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KCiNpbmNsdWRlIDxz eXMvdHlwZXMuaD4KI2luY2x1ZGUgPHN5cy9maWxlLmg+CiNpbmNsdWRlIDxz eXMvd2FpdC5oPgoKI2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxzdGRs aWIuaD4KI2luY2x1ZGUgPGZjbnRsLmg+CiNpbmNsdWRlIDx1bmlzdGQuaD4K I2luY2x1ZGUgPGVycm5vLmg+CgojZGVmaW5lIE1BWF9JVEVSIDMKI2RlZmlu ZSBDSElMRFJFTiAyCgovKiBBIHRlbXBvcmFyeSBmaWxlIHVzZWQgZm9yIGZs b2NrLiAqLwpjaGFyIHRtcGZpbGVuYW1lW10gPSAiL3RtcC9mbG9ja3RzdFhY WFhYWCI7CgovKiBGb3JrIGFuZCB1c2UgZmxvY2sgdG8gbG9jayBhbmQgdW5s b2NrIHRoZSBmaWxlIHJlcGVhdGVkbHkgaW4gdGhlIGNoaWxkLiAqLwp2b2lk IG1ha2VfY2hpbGQoaW50IHRyeWxvY2ssIHBpZF90ICpwaWQpCnsKICAgIGlm ICgoKnBpZCA9IGZvcmsoKSkgPCAwKSB7CiAgICAgICAgcGVycm9yKCJmb3Jr IGZhaWxlZCIpOwogICAgICAgIGV4aXQoMSk7CiAgICB9CiAgICBlbHNlIGlm ICgqcGlkID09IDApIHsKICAgICAgICBpbnQgZmQyID0gb3Blbih0bXBmaWxl bmFtZSwgT19SRE9OTFkpOwogICAgICAgIGlmIChmZDIgPCAwKSB7CiAgICAg ICAgICAgIHBlcnJvcigiY2hpbGQgb3BlbiIpOwogICAgICAgICAgICBleGl0 KDEpOwogICAgICAgIH0KCiAgICAgICAgaW50IHJjOwogICAgICAgIGludCBp OwogICAgICAgIGZvciAoaT0wOyBpPE1BWF9JVEVSOyArK2kpIHsKICAgICAg ICAgICAgZG8gewogICAgICAgICAgICAgICAgcmMgPSBmbG9jayhmZDIsIExP Q0tfRVgpOwogICAgICAgICAgICB9IHdoaWxlIChyYyA8IDAgJiYgZXJybm8g PT0gRUlOVFIpOwogICAgICAgICAgICBpZiAocmMgPCAwKSB7CiAgICAgICAg ICAgICAgICBwZXJyb3IoImxvY2siKTsKICAgICAgICAgICAgICAgIGV4aXQo MSk7CiAgICAgICAgICAgIH0KICAgICAgICAgICAgZG8gewogICAgICAgICAg ICAgICAgcmMgPSBmbG9jayhmZDIsIExPQ0tfVU4pOwogICAgICAgICAgICB9 IHdoaWxlIChyYyA8IDAgJiYgZXJybm8gPT0gRUlOVFIpOwogICAgICAgICAg ICBpZiAocmMgPCAwKSB7CiAgICAgICAgICAgICAgICBwZXJyb3IoInVubG9j ayIpOwogICAgICAgICAgICAgICAgZXhpdCgxKTsKICAgICAgICAgICAgfQog ICAgICAgIH0KICAgICAgICBleGl0KDApOwogICAgfQp9CgovKiBXYWl0IGZv ciB0aGUgY2hpbGQgdG8gZmluaXNoLiAqLwp2b2lkIGF3YWl0X2NoaWxkKHBp ZF90IHBpZCkKewogICAgcGlkX3QgcHN0YXR1czsKICAgIGludCBleGl0X2lu dDsKCiAgICBkbyB7CiAgICAgICAgcHN0YXR1cyA9IHdhaXRwaWQocGlkLCAm ZXhpdF9pbnQsIFdVTlRSQUNFRCk7CiAgICB9IHdoaWxlIChwc3RhdHVzIDwg MCAmJiBlcnJubyA9PSBFSU5UUik7Cn0KCmludCBtYWluKGludCBhcmdjLCBj b25zdCBjaGFyICogY29uc3QgKiBhcmd2LCBjb25zdCBjaGFyICogY29uc3Qg KmVudikKewogICAgcGlkX3QgY2hpbGRbQ0hJTERSRU5dOwogICAgaW50IG47 CiAgICBpbnQgZmQ7CiAKICAgIC8qIENyZWF0ZSB0aGUgdGVtcG9yYXJ5IGZp bGUuICovCiAgICBmZCA9IG1rc3RlbXAodG1wZmlsZW5hbWUpOwogICAgaWYg KGZkIDwgMCkgewogICAgICAgIHBlcnJvcigib3BlbiBmYWlsZWQiKTsKICAg ICAgICBleGl0KDEpOwogICAgfQogICAgY2xvc2UoZmQpOwoKICAgIC8qIENy ZWF0ZSB0aGUgY2hpbGRyZW4uICovCiAgICBmb3IgKG4gPSAwOyBuIDwgQ0hJ TERSRU47IG4rKykKICAgICAgICBtYWtlX2NoaWxkKDAsICZjaGlsZFtuXSk7 CgogICAgLyogV2FpdCBmb3IgdGhlbSB0byBmaW5pc2guICovCiAgICBmb3Ig KG4gPSAwOyBuIDwgQ0hJTERSRU47IG4rKykKICAgICAgICBhd2FpdF9jaGls ZChjaGlsZFtuXSk7CgogICAgLyogQ2xlYW4gdXAuICovCiAgICB1bmxpbmso dG1wZmlsZW5hbWUpOwogICAgcmV0dXJuIDA7Cn0K --f46d0438951b9fa24c051f360045 Content-Type: text/plain; charset=us-ascii Content-length: 218 -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple --f46d0438951b9fa24c051f360045--