From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103782 invoked by alias); 4 Jan 2016 03:11:56 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 103768 invoked by uid 89); 4 Jan 2016 03:11:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2762, UD:ca, sk:systema, reserved X-HELO: mail-io0-f171.google.com Received: from mail-io0-f171.google.com (HELO mail-io0-f171.google.com) (209.85.223.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 04 Jan 2016 03:11:54 +0000 Received: by mail-io0-f171.google.com with SMTP id 77so113781221ioc.2 for ; Sun, 03 Jan 2016 19:11:54 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.107.136.226 with SMTP id s95mr34083769ioi.38.1451877112531; Sun, 03 Jan 2016 19:11:52 -0800 (PST) Received: by 10.107.10.34 with HTTP; Sun, 3 Jan 2016 19:11:52 -0800 (PST) In-Reply-To: References: Date: Mon, 04 Jan 2016 03:11:00 -0000 Message-ID: Subject: Re: Issues in utmp/utmpx headers From: David Lee To: cygwin@cygwin.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00015.txt.bz2 Sorry I am totally unfamiliar with Cygwin internals, here are some related questions: 1. how does one test a code path that involves a failed syscall (strdup() in this case, but can be others) in cygwin dll? 2. If the call to strdup() fails, I want to debug_print() the errno value set by strdup(). Do I have to save errno before debug_print() that and restore afterwards? 3. Does the instruction from 6.21 in https://cygwin.com/faq/faq.html#faq.prog5asdramming.building-cygwin generates a debugging dll (i.e. contains debug symbols usable by gdb)? If not, what modifications are needed to create one? Thanks. On 29 December 2015 at 13:16, Brian Inglis wrote: >> > David Lee gmail.com> writes: >> >> While trying to port bsdgames to Cygwin I spotted the following issues: >> >> (1) In /usr/include/utmpx.h, utmpxname() is declared a void function. >> >> Should it return int? >> >> (2) In /usr/include/sys/utmp.h, utmpname() is declared a void >> >> function. Should it return int? >> >> (3) _PATH_UTMPX is not defined in any system headers. > >> On 28 December 2015 at 03:02, Brian Inglis >> systematicsw.ab.ca> wrote: >> > Search packages for missing files e.g. >> > https://cygwin.com/cgi-bin2/package-grep.cgi?grep=utmp.h&arch=x86_64 >> > brings up package cygwin-devel and cygwin32. >> > Download and run setup and select cygwin-devel to install the headers and >> > libraries. > > David Lee gmail.com> writes: >> The issue isn't missing, not-installed packages. The issues are (1) >> some function declaration seem wrong; and (2) a constant is missing. > > Pardon my reading comprehension bork! > > The utmpname implementation in newlib-cygwin/winsup/cygwin/syscalls.cc > could probably be improved to: avoid a memory leak; return -1 if > strdup fails, zero otherwise; default the path if a null pointer or string > argument is passed. > That would also fix utmpxname which is an alias. > Such a change would have little likely impact on downstream apps, but could > produce warnings about ignoring return values. > > Unfortunately there appears to be no standard defined names to access the > default file name although GNU and Cygwin provide UTMP_FILE and UTMPX_FILE; > GNU also provide UTMP_FILENAME and UTMPX_FILENAME. > _PATH_UTMP and _PATH_UTMPX are implementation reserved names which may or > may not be provided, though adding the latter in paths.h would be trivial. > > As the developers say, patches always welcome. > > > > -- > Problem reports: http://cygwin.com/problems.html > FAQ: http://cygwin.com/faq/ > Documentation: http://cygwin.com/docs.html > Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple > -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple