From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75399 invoked by alias); 13 Feb 2018 18:26:36 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 74930 invoked by uid 89); 13 Feb 2018 18:26:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-io0-f172.google.com Received: from mail-io0-f172.google.com (HELO mail-io0-f172.google.com) (209.85.223.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 18:26:34 +0000 Received: by mail-io0-f172.google.com with SMTP id m11so22288632iob.2 for ; Tue, 13 Feb 2018 10:26:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=kDUSKp80c9nNbpfHvySAZGcXkuqaGNf01Lzm58w1KbM=; b=lZlvgm6gKyCAnsN8j1D83e7TyOInXmjUpB6Ok1AlFH7f1q/6oK6ADB4DU9ihDuFwrJ SKbxz3OSRTiA6Mejy/ks01e9NwKgZU++UrVgETH05lJjBixd7A0ekJjgAReGY7U2QoMY 881NW4kkhXjCUhEnbLN5CXpeYBrWHB7l55lYN1nEH1dCWVI27PktQgJCQ6P32RK03W0s nDkymrDZoqGUB3jUFJzNpMFF+nKaoZ+MSA/DSQ4AoXfsNn43QrPDEkHsUy2pzT5NOMc0 y3Jk+43/iVYvic5Eh7Ov+ca6xxY3jqLIEGVN75wAOD+d7ryfOrPFk4KnOUqKo+Z0XY39 m1Fg== X-Gm-Message-State: APf1xPDFxPlwxvsVplOcuoCv9M5Jdv6JsCVznTLgcHJI7Kjp4XYvyYpY wCElJPz8tiQY/qFpIxlSFz2hsXVB5xMQhXN5bfVpQA== X-Google-Smtp-Source: AH8x225oTVfnpciQK+bGTo59Re04EsvE3jlFwXp4tD1nwIOkkwRpPKGafoUiYxjk8Ea+kwVqM/CMjuLNz2lmDzef9sk= X-Received: by 10.107.166.140 with SMTP id p134mr2426454ioe.272.1518546392124; Tue, 13 Feb 2018 10:26:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.34.70 with HTTP; Tue, 13 Feb 2018 10:26:31 -0800 (PST) In-Reply-To: <874lmu6lgx.fsf@Rainer.invalid> References: <874lmu6lgx.fsf@Rainer.invalid> From: Erik Bray Date: Tue, 13 Feb 2018 18:26:00 -0000 Message-ID: Subject: Re: OpenBLAS patch for Cygwin To: cygwin@cygwin.com Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00143.txt.bz2 On Tue, Feb 6, 2018 at 7:07 PM, Achim Gratz wrote: > Erik Bray writes: >> Assuming this looks good (feedback welcome) it might be nice to have >> this patch included in the next release of the official OpenBLAS >> package for Cygwin since its incompatibility with fork() has caused >> problems in the past [1]. > > It would be vastly preferrable if OPenBLAS ditched the (unfortunately > quite common) notion that "Cygwin is some sort of Windows" for "Cygwin > is some sort of Linux". I've patched out quite some bit of conditionals > like that in some other packages and it was almost always for the > better. The worst ones are those that go into the Windows conditional > branch and then on to "oh wait, but for Cygwin we need something else". Yup--OpenBLAS treats Cygwin as "some sort of Windows" and you can see in my pull requests that there are some conditions like "if WINDOWS && !CYGWIN". I will probably try another patch to remove that notion in general. I've had a little other experience with patching OpenBLAS for Cygwin and it's one of those cases where upstream is, fortunately, receptive to supporting it as a platform. Their existing Cygwin support has just been a bit janky (a previous patch I submitted installed the DLL as cygopenblas.dll instead of libopenblas.dll, for example). Best, E -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple