Re: cygwin_conv_path sometimes removes trailing slash

[Ray Donnelly <mingw.android@gmail.com>]

On Mon, Feb 1, 2016 at 10:29 AM, Henri <houder@xs4all.nl> wrote:
> Jan Nijtmans <jan.nijtmans <at> gmail.com> writes:
>
>>
>> 2016-01-30 4:21 GMT+01:00 Ken Brown:
>> > I'm using cygwin_conv_path to convert Win32 paths to POSIX paths, and I'm
>> > puzzled by the conversion
>> >
>> >   d:/ --> /cygdrive/d
>> >
>> > without the trailing slash.  By contrast, we have
>> >
>> >   d:/foo/ --> /cygdrive/d/foo/
>>
>> This came up before:
>>    <https://cygwin.com/ml/cygwin/2015-10/msg00048.html>
>> I had to workaround it in tkimg.
>>
>> It's easy to workaround in your program, but - indeed -
>> that shouldn't be necessary. I too would expect that
>> when the input contains a slash, the output should too.
>>
>> Regards,
>>      Jan Nijtmans
>
> For the record ...
>
>  - Ken Brown refers to: win32 -> posix
>  - Jan Nijthuis and Ray Donnelly refer to: posix -> win32
>
> Different code paths ...
>
> (and yes, conversions in both directions should be correct)

I can't check as I'm at work, but to the best of my knowledge (and yes
I wrote these a long time ago) path_conv::check is used in conversions
both ways so I am talking about both cases here, Jan's with the first
patch and Ken's with the second patch. Please do correct me if I am
wrong though! I will run some detailed tests tonight.

Best regards,

Ray.

>
> Regards,
> Henri
>
>
>
>
>
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple