From: Kevin Nomura <knomura@vmware.com>
To: "cygwin@cygwin.com" <cygwin@cygwin.com>
Cc: Taylor Hutt <thutt@vmware.com>
Subject: spinlock.h timeout causing *** fatal error - add_item abort
Date: Fri, 29 Apr 2016 16:32:00 -0000 [thread overview]
Message-ID: <D348D3EA.10AEB%knomura@vmware.com> (raw)
Hi,
We occasionally see an api_fatal abort during process startup like:
*** fatal error - add_item ("somepath", "/", ...) failed, errno 1
This happens if mountinfo.init(false) in user_info::initialize is
called twice. The error occurs on a second call when trying to add
the root mount point when it already exists.
mountinfo.init is guarded by a "spinlock" object that should only
allow one process to call it. But the spinlock has a timeout. After
15 seconds, it stops waiting and returns a value of 0. The fatal
error can occur if two processes are starting around the same time
and the first process takes a long time in internal_getpwsid(). We've
seen this happen in our environment due to LDAP queries taking a long
time. (Incidentally we are using msys, but code in spinlock.h and
shared.cc looks the same in cygwin).
To solve the aborts it is tempting to make a local fix to remove the
spinlock timeout. I assume there was a rationale for it, and would
like to understand what tradeoff is incurred if we remove it.
- Kevin
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next reply other threads:[~2016-04-29 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 16:32 Kevin Nomura [this message]
2016-05-24 10:23 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D348D3EA.10AEB%knomura@vmware.com \
--to=knomura@vmware.com \
--cc=cygwin@cygwin.com \
--cc=thutt@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).