From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4055 invoked by alias); 3 Mar 2002 21:15:09 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Received: (qmail 3940 invoked from network); 3 Mar 2002 21:15:06 -0000 Received: from unknown (HELO itdomain003.itdomain.net.au) (203.63.157.208) by sources.redhat.com with SMTP; 3 Mar 2002 21:15:06 -0000 content-class: urn:content-classes:message Subject: RE: setup.exe (cinstall) bugfixes + minor new feature Date: Sun, 03 Mar 2002 13:15:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Message-ID: X-MimeOLE: Produced By Microsoft Exchange V6.0.5762.3 X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: setup.exe (cinstall) bugfixes + minor new feature Thread-Index: AcHC3W1VhjefPyWlRBS2Mh8DRkOTfwAGeKdg From: "Robert Collins" To: "Max Bowsher" , X-SW-Source: 2002-03/txt/msg00136.txt.bz2 Thanks Max. > -----Original Message----- > From: Max Bowsher [mailto:maxb@ukf.net]=20 > Sent: Monday, March 04, 2002 4:54 AM > To: cygwin@cygwin.com > Subject: setup.exe (cinstall) bugfixes + minor new feature >=20 >=20 > I've been working with the setup code, and have discovered=20 > some bugs in the current (just updated) CVS version. >=20 > I'm posting a patch here for comments, whilst I join=20 > cygwin-patches, and study the Contributing instructions. >=20 > The patch does the following: >=20 > BugFix: io_stream::mkpath_p(isadir, path) misuse > mkpath_p is supposed to take a path with either a file:// or=20 > a cygfile:// prefix, but it is fed a path with no prefix in=20 > some places. The patch adds a file:// prefix where needed.=20 > This was causing some directories not to be created,=20 > including the Cygwin directory in the start menu. I know about these - they are fixed in setup200202 - when that goes live I'll be backporting some key bugs.=20 =20 > BugFix: add backslash call to make_link, in desktop.cc > This was causing the start menu shortcut to be called=20 > 'Programs/Cygwin/Cygwin Bash Shell' instead of being in the=20 > correct directory structure Does this affect setup200202? I haven't checked yet. I'm trying to encpasulate the path specific knowledge - so whilst this solution works, I'd rather refactor make_link to leverage io_stream, and make this a method or variant of the file:// io_stream. Also '/' separated paths are valid to pass to the WIN32 API, so I'm curious why this is suddenly become a problem. (Quite a lot of setup expects '/' separated paths, and I see no reason to change that at this point. =20 > Feature Addition: Use files=20 > /etc/setup/inhibit-{startmenu,desktop}-icon to remeber user=20 > de-selection of the create icon checkboxes on the last page of setup. This approach is too simple - it will only remember turning them off. The settings should go in /etc/setup/setup.conf as something like "desktop_icon =3D yes|no".=20 Thanks for the patch though, I look forward to an update. Cheers, Rob -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/