public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-21 16:28 Robert Collins
  2002-04-21 17:47 ` Michael A Chase
  2002-04-22  3:29 ` Cliff Hones
  0 siblings, 2 replies; 31+ messages in thread
From: Robert Collins @ 2002-04-21 16:28 UTC (permalink / raw)
  To: Cliff Hones, cygwin



> -----Original Message-----
> From: Cliff Hones [mailto:cliff@aonix.co.uk] 
> Sent: Sunday, April 21, 2002 11:55 PM

> It seems then that the buggy behaviour is present on W9X NT and W2K
but not XP.  Since the majority of Cygwin users do not 
> use XP (yet) I'd suggest that it would be a good idea for some
setup.exe developers to have access to a variety of systems
> to help avoid and debug this sort of problem in the future.

I certainly do try to test on more than one system, and I always make
alpha and betas available and ask for feedback. The simple reality
though is that I am a single individual, not a corporation with a test
lab. As such, testing on other platforms only happens when another
developer (such as Pavel or Gary or Michael or ...) makes the time to
test - and notices the fault. If someone wants to ship me a smallish
machine for using for tests, that would be neat. Short of that though...
we'll continue doing what we can.

> As a first step to investigating this, I moved my 'latest' 
> directory from under the mirror directory to the top level of 
> the local download directory, and the problem still occured.  
> So if the problem is in check_for_cached it's common to both 
> legacy and mirror directory handling.

Thanks for the detail Cliff. As a point of interest: both latest and
contrib are obsolete - and I expect setup.exe to redownload the entire
content of mirror sites. This is due to a restructuring done on
sources.redhat.com to put everythign in to /release. However the
restructuring is transparent in all other respects - which is why there
have been no trouble reports here :}.

The download process iterates over all known packages, and calls
download_one for the binary (if the binary is selected for
install/download) and source packages (likewise, only if selected). The
first thing that download_one does is call check_for_cached and returns
success if check_for_cached succeeds. Check_for_cached checks both the
non-prefixed directories, and the directories in each <known> mirror
prefix. This means that changing mirrors will cause repeated downloads,
and that selecting all the mirrors you want to use is the most efficient
approach.

Cheers,
Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-22  4:37 Robert Collins
  2002-04-22  6:13 ` Cliff Hones
  2002-04-22  9:28 ` Michael A Chase
  0 siblings, 2 replies; 31+ messages in thread
From: Robert Collins @ 2002-04-22  4:37 UTC (permalink / raw)
  To: Cliff Hones, cygwin



> -----Original Message-----
> From: Cliff Hones [mailto:cliff@aonix.co.uk] 
> Sent: Monday, April 22, 2002 9:14 PM
 
> The problem seems to be that setup doesn't set these 
> already-present packages to 'keep' or 'skip' by default, and 
> there's no way for the user to find out which packages are in 
> this state.

So you are suggesting that in download mode it should not offer to
upgrade any installed packages by default? Or that it should only offer
upgrades for installed packages without cached files?

I'll happily accept a (reasonable) patch for the second case, but the
first case also seems counter-intuitive to me.
 
> I can't actually see any advantage in re-downloading the 
> packages *by default*.  

The point of 'download' mode is to allow downloads. If you choose not to
install what you have downloaded, what should setup assume that means?

> This is very unhelpful if one download failed to complete, 
> and you just want to re-fetch what hadn't been transferred on 
> the previous run.

There is a lot that setup does that needs to be more persistent. It
needs the ability to hold packages (ie 'do not offer to upgrade
autoconf'), and much more.
 
> Also, does the current implementation 
> mean that I won't be informed of a newly-added package by default?

Yes.
 
> And even cgf and the implementors now seem undecided as 
> to what should be happening.  

You do realise that that includes me I hope :}.

> So can I ask for 
> the design decision to be re-addressed?  I'd like to hear 
> what the arguments in favour of the current mechanism are.

I'd like to remove the re-download facility completely. If a package
file is corrupt, delete the local copy and then run setup. This makes
setup simpler, for little cost. Setup won't keep partial files anyway,
so the only form of corruption has to be network transit problems, and
GPG signing would solve that too, and allow setup to detect and remove
corrupt packages automatically.

Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-22  4:11 Robert Collins
  2002-04-22  4:36 ` Cliff Hones
  0 siblings, 1 reply; 31+ messages in thread
From: Robert Collins @ 2002-04-22  4:11 UTC (permalink / raw)
  To: Cliff Hones, cygwin



> -----Original Message-----
> From: Cliff Hones [mailto:cliff@aonix.co.uk] 
> Sent: Monday, April 22, 2002 7:16 PM

>  I was pleasantly 
> surprised how easy this was (once I realised the setup200202 
> branch was needed), and after adding some diagnostics have so 
> far found that the check_for_cached calls do seem to be 
> working ok.  

That's good to know. There is one additional possibility that has
occurred to me. Setup is *designed* to redownload files in download-only
mode. This is not my preference, but was argued over waay back. So in
download mode, *any* choice other than 'keep' or 'skip' will result in
the files being downloaded.

Does that tie in with the behaviour you are reporting? (I finally
clicked to this just a few minutes ago, or I'd have made  that statement
*ages* ago.)

Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-21  2:43 Robert Collins
  2002-04-21 10:18 ` Cliff Hones
  0 siblings, 1 reply; 31+ messages in thread
From: Robert Collins @ 2002-04-21  2:43 UTC (permalink / raw)
  To: Gerrit P. Haase, cygwin



> -----Original Message-----
> From: Gerrit P. Haase [mailto:gp@familiehaase.de] 
> Sent: Sunday, April 21, 2002 6:20 PM
> To: cygwin@cygwin.com
> Subject: Re: Bug in setup.exe 2.194.2.24
> 
> 
> Hallo Robert,
> 
> > And I *stil* cannot reproduce it. Setup detects the local 
> files *every 
> > single time*.
> 
> what system are you on?
> I have problems on Win2000 and WinNT4.
> 
> Say, you *install* everything you need from the release using 
> the 'current' (default setting) including some packages where 
> a 'test' version is available (autoconf, automake).
> 
> Now start Setup (Download only mode) again, click one time on 
> 'View' to see the full list and choose 'Exp' from the 
> radiobuttons.  All what is present in setup.ini as test 
> (experimental) gets downloaded (if it doesn't default to 
> skip), regardless if it already present in your archive 
> (repository) or not .
> 
> Now repeat it, Setup will download everything again. 

No, it doesn't. That's the point - I can't repeat this (with the
setup200202 branch - the released setup). I suggest you roll your own
and debug it.

Start with download.cc:check_for_cached.

Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-21  0:48 Robert Collins
  2002-04-21  1:32 ` Gerrit P. Haase
  0 siblings, 1 reply; 31+ messages in thread
From: Robert Collins @ 2002-04-21  0:48 UTC (permalink / raw)
  To: cygwin



> -----Original Message-----
> From: Christopher Faylor [mailto:cgf@redhat.com] 
> Sent: Saturday, April 20, 2002 10:16 AM
> To: cygwin@cygwin.com
> Subject: Re: Bug in setup.exe 2.194.2.24
> 
> 
> On Sat, Apr 20, 2002 at 09:31:02AM +1000, Robert Collins wrote:
> >
> >
> >> -----Original Message-----
> >> From: Cliff Hones [mailto:cliff@aonix.co.uk]
> >> Sent: Saturday, April 20, 2002 9:10 AM
> >
> >> Since noone acknowledged it was a bug I've been assuming it was a
> >(rather strange to me) design feature.
> >
> >Actually, I acknowledged it as a bug, but one I couldn't 
> repeat until I 
> >was given an exact recipe on cygwin-apps. I've jet to track 
> it down and 
> >squash it though.

And I *stil* cannot reproduce it. Setup detects the local files *every
single time*.

The only thing I can think of is platform: Can anyone reproduce the bug
on windows XP? If so, please please please tell me how.

Otherwise, I'll forge on ahead with getting a new HEAD tidyup done,
including the URL class that Pavel worked quite hard on, that will allow
some normalisations - and may be able to fix the bug. (The only thing I
can see that might cause it is that the file paths look like
d:\foo\bar/release/package/packagefile, which could potentially confuse
the MSVCRT library..

Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-19 16:36 Robert Collins
  2002-04-19 17:25 ` Christopher Faylor
  0 siblings, 1 reply; 31+ messages in thread
From: Robert Collins @ 2002-04-19 16:36 UTC (permalink / raw)
  To: Cliff Hones, cygwin



> -----Original Message-----
> From: Cliff Hones [mailto:cliff@aonix.co.uk] 
> Sent: Saturday, April 20, 2002 9:10 AM

> Since noone acknowledged it was a bug I've been assuming it was a
(rather strange to me) design feature.

Actually, I acknowledged it as a bug, but one I couldn't repeat until I
was given an exact recipe on cygwin-apps. I've jet to track it down and
squash it though.

Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-19 16:31 Robert Collins
  0 siblings, 0 replies; 31+ messages in thread
From: Robert Collins @ 2002-04-19 16:31 UTC (permalink / raw)
  To: cygwin



> -----Original Message-----
> From: Christopher Faylor [mailto:cgf@redhat.com] 
> Sent: Saturday, April 20, 2002 8:02 AM

> >> On Fri, 19 Apr 2002 18:41:04 +0100 Alan Hourihane 
> >><alanh@fairlite.demon.co.uk> wrote: I think this is because you 
> >>haven't installed the packages yet.  I think setup.exe gets the 
> >>current version information from the installed package not the 
> >>download directory.

Setup gets the version of the current installed package from the local
information - which it should.
It also gets the 'curr' package information from one or more setup.ini
files.

...

> And, (bwahaha) I don't have time to look into this myself right now.

Don't worry - I've got a little time right now and am actively hacking
cygwin&related stuff this weekend.
 
> However, if Robert indicates that this is not the desired 
> behavior 

http://cygwin.com/ml/cygwin/2002-04/msg01048.html

Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-19 16:25 Lawrence W. Smith
  0 siblings, 0 replies; 31+ messages in thread
From: Lawrence W. Smith @ 2002-04-19 16:25 UTC (permalink / raw)
  To: cygwin



> From: Randall R Schulz [mailto:rrschulz@cris.com]
> Sent: Friday, April 19, 2002 9:43 PM
> To: cygwin@cygwin.com
> Subject: Re: Bug in setup.exe 2.194.2.24
> 
> 
> Chris,
> 
> At 12:38 2002-04-19, you wrote:
> >On Fri, Apr 19, 2002 at 11:28:19AM -0700, Randall R Schulz wrote:
> > >I think to generalize, the current Setup.exe offers to 
> download based on
> > >which packages are currently installed, not on which 
> packages are present
> > >in the local download area(s).
> >
> >I hate to say it but that sounds like a bug to me.  I can't 
> remember if 
> >this is new behavior, though. Is it?
> 
> 
> I hesitate to say with 100% certainty, but I'm fairly sure it 
> is new behavior.
> 
> Randall Schulz

Last 2 versions behave like that but ver 2.29 didn't just tested it.

It offers to d/l packages even if not installed whereas setup 2.194.2.22
and 24 default to skip for packages not installed.

hth

Lawrence

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* RE: Bug in setup.exe 2.194.2.24
@ 2002-04-19 15:01 Robert Collins
  0 siblings, 0 replies; 31+ messages in thread
From: Robert Collins @ 2002-04-19 15:01 UTC (permalink / raw)
  To: cygwin



> -----Original Message-----
> From: Christopher Faylor [mailto:cgf@redhat.com] 
> Sent: Saturday, April 20, 2002 5:38 AM
> To: cygwin@cygwin.com
> Subject: Re: Bug in setup.exe 2.194.2.24
> 
> 
> On Fri, Apr 19, 2002 at 11:28:19AM -0700, Randall R Schulz wrote:
> >I think to generalize, the current Setup.exe offers to 
> download based 
> >on
> >which packages are currently installed, not on which 
> packages are present 
> >in the local download area(s).
> 
> I hate to say it but that sounds like a bug to me.  I can't 
> remember if this is new behavior, though.  Is it?

It's a bug.

Rob

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread
* Bug in setup.exe 2.194.2.24
@ 2002-04-19 10:42 Alan Hourihane
  2002-04-19 11:27 ` Michael A Chase
                   ` (2 more replies)
  0 siblings, 3 replies; 31+ messages in thread
From: Alan Hourihane @ 2002-04-19 10:42 UTC (permalink / raw)
  To: cygwin

Hi,

I'm wondering if I've found a bug in setup.exe.

I'm using 2.194.2.24 and when I go through "Download from Internet"
and download the "new" components. It downloads them fine.

Next, I re-run setup.exe and I go through "Download from Internet" again,
(but this was by accident) and it says that the same files are ready
to be downloaded and proceeds to re-download them all again.

If I "Install from Local Directory" first it clears the problem.

Alan.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

^ permalink raw reply	[flat|nested] 31+ messages in thread

end of thread, other threads:[~2002-04-22 16:44 UTC | newest]

Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-21 16:28 Bug in setup.exe 2.194.2.24 Robert Collins
2002-04-21 17:47 ` Michael A Chase
2002-04-22  3:29 ` Cliff Hones
  -- strict thread matches above, loose matches on Subject: below --
2002-04-22  4:37 Robert Collins
2002-04-22  6:13 ` Cliff Hones
2002-04-22  9:28   ` Michael A Chase
2002-04-22 10:04     ` Cliff Hones
2002-04-22  9:28 ` Michael A Chase
2002-04-22  4:11 Robert Collins
2002-04-22  4:36 ` Cliff Hones
2002-04-21  2:43 Robert Collins
2002-04-21 10:18 ` Cliff Hones
2002-04-21  0:48 Robert Collins
2002-04-21  1:32 ` Gerrit P. Haase
2002-04-19 16:36 Robert Collins
2002-04-19 17:25 ` Christopher Faylor
2002-04-19 16:31 Robert Collins
2002-04-19 16:25 Lawrence W. Smith
2002-04-19 15:01 Robert Collins
2002-04-19 10:42 Alan Hourihane
2002-04-19 11:27 ` Michael A Chase
2002-04-19 12:36   ` Alan Hourihane
2002-04-19 15:35     ` Christopher Faylor
2002-04-19 16:19       ` Michael A Chase
2002-04-19 17:15         ` Christopher Faylor
2002-04-19 12:17 ` Randall R Schulz
2002-04-19 12:46   ` Christopher Faylor
2002-04-19 13:43     ` Randall R Schulz
2002-04-19 15:47     ` Ilya Goldin
2002-04-19 16:17     ` Cliff Hones
2002-04-19 16:25 ` E

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).