From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104590 invoked by alias); 26 Aug 2019 22:13:27 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 104581 invoked by uid 89); 26 Aug 2019 22:13:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=inbetween, in-between X-HELO: NAM05-DM3-obe.outbound.protection.outlook.com Received: from mail-eopbgr730132.outbound.protection.outlook.com (HELO NAM05-DM3-obe.outbound.protection.outlook.com) (40.107.73.132) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2019 22:13:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZgwLeghHshVXq3vF0P/RCyOaT5yGHDaLSnauDp6iUHzZR6pte3teaGbRqtdMPkK5c92V7273VRaLDn4hlSRWbSi68o40y8JSxp6wUkY/MQgR+UYd/nRAZThuJYIqoQmxIg5sLFk2oFeT9mcwW+ZkNjOFC4h3r7P+7rZ2Szb+EywHoA4KB1hN3nmX5xuatIOp/WuNpP2VkGae7vqwn6NnZiPBtX0ddHbrCTfAwNSk6IExE5V5q7K53BOxUgyCRMjHkFqiBJ/RjzjnwwEM3UEJQNb9JTMgRC+tJHU+6gDTaj15j9XR+GV3WwuszeJNzjqwivvvWCGPTURgxmG/vz2rBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0L3+NjBkQTD5ztnpsaePfjCt+AZ/4TYSRmSOcILD434=; b=djPXplzzchRT0Dc6u8alAKsn4sbLniLcXX1SiEdpSBUsEfhVq1AI5hoS1jcSKl55EtMWk93kPNCb6Rv0ZxnQPt5Ljynb4ppXN4d/NlPQHmMBr6o8jjh09HnIwWMDA4W0EVwSU2WY19O3Kmwy9BAxSFdMGlCG2dUHG13FxgmJ7GIP74mJqqPbxcAJ33NagGWDGDmx8XNUc43C8JZxy1Qmp49WP/Ud5Yp1PDAH6U0mldSl0/NREOuPRjE/nmkTf9Fqqqhr+7oHxeM4zOIws1xHB9cUxd0eO3AJJF9asc5UE7pz1Izb49ZdN7d7nqSGo1Og/1yyfPokYgJhInb/4ukOMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0L3+NjBkQTD5ztnpsaePfjCt+AZ/4TYSRmSOcILD434=; b=OAzAWOi6W46bflPXJkdW9YpmpMOzgNCtjxhc/TsmK/dfjMB/NoTpHQINoe1n8JMfqR8IP9bMpjZMSu9I9QFxOVkeKeWhbXMuQr4vRBwde1JdcmMQOexf+TL6hIlHg+cE+7haoluX3Jj82Fr6CtOxzr6wMRYLwQJT5x3kxQ5ohJI= Received: from MWHPR21MB0845.namprd21.prod.outlook.com (10.173.51.139) by MWHPR21MB0831.namprd21.prod.outlook.com (10.173.51.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.1; Mon, 26 Aug 2019 22:13:19 +0000 Received: from MWHPR21MB0845.namprd21.prod.outlook.com ([fe80::3085:a037:7cbc:be5]) by MWHPR21MB0845.namprd21.prod.outlook.com ([fe80::3085:a037:7cbc:be5%5]) with mapi id 15.20.2241.000; Mon, 26 Aug 2019 22:13:19 +0000 From: "Stephen Provine via cygwin" Reply-To: Stephen Provine To: Ken Brown , "cygwin@cygwin.com" Subject: RE: Future setup regression caused by 'mkdir: always check-for-existence' commit Date: Tue, 27 Aug 2019 12:51:00 -0000 Message-ID: References: <860a3bd2-fc37-27c0-54f3-0fce8add7c24@cornell.edu> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=stephpr@microsoft.com; x-ms-exchange-purlcount: 1 x-ms-oob-tlc-oobclassifiers: OLM:10000; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CYqyzcDQHdEEYbU1mSDx127+NKMBz4QenajLIVh4BzVWrcCDkT5hRdODRatsILbm7ygiAn47V65PpiJsLlt4mw== X-SW-Source: 2019-08/txt/msg00334.txt.bz2 On 8/26/2019 1:33 PM, Ken Brown wrote: > I don't think you understand the logic change in that commit. An attempt= to create an existing directory would already fail before that commit; the= failure would occur in the call to fh->mkdir(). The commit in question si= mply guarantees that the error code is EEXIST. Take a look at the commit m= essage. I installed the current release of Cygwin with all the default packages (so= cygwin package version 3.0.7-1) and tested the scenario that Git for Windo= ws runs into, which is that prior to running its post-install script (https= ://github.com/git-for-windows/git-sdk-64/blob/master/etc/post-install/01-de= vices.post), there is no "dev" directory present on the host Windows machin= e (I just renamed it to "dev2" before running Cygwin.bat). Running "mkdir -= m 0755 /dev" in Cygwin *succeeds* with exit code 0. I then deleted that ins= tallation and installed Cygwin again, only changing the cygwin package vers= ion to 3.1.0-0.2 (test). Tried the same scenario again and "mkdir -m 0755 /= dev" fails with the error " mkdir: cannot create directory '/dev': File exi= sts". I should also point out that this change in behavior starts not in 3.1.0 bu= t in 3.0.7-3, and in-between 3.0.7-1 and 3.0.7-3 the commit I mention seeme= d like the most reasonable reason for it. All this said, Cygwin succeeds in both cases. And now that I look, I think = the Cygwin setup program explicitly creates "/dev" as a standard directory = so it avoids this change in behavior. Given that the new behavior is obviously correct, I assume this means there= is nothing for Cygwin to do, and the fix is for Git for Windows to explici= tly create this directory. Thanks, Stephen -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple