From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls /proc/PID/...
Date: Tue, 10 Jan 2023 11:57:26 +0100 [thread overview]
Message-ID: <Y71ElhBj2unNOxzx@calimero.vinschen.de> (raw)
In-Reply-To: <20230110190145.ed5438f6c7a9d979899fa823@nifty.ne.jp>
On Jan 10 19:01, Takashi Yano via Cygwin wrote:
> On Mon, 9 Jan 2023 18:13:26 +0100
> Corinna Vinschen wrote:
> > If q->sigtls is NULL, the signal is nevertheless waiting for being
> > handled. It's just not directed at a specific thread. Beats me, why
> > this didn't occur in my testing. The process signal info should contain
> > the process-wide mask of pending signals as well, obviously, so the
> > following patch should do the right thing:
> >
> > diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
> > index ce36c8be37fb..86e4e607ab7e 100644
> > --- a/winsup/cygwin/sigproc.cc
> > +++ b/winsup/cygwin/sigproc.cc
> > @@ -1375,7 +1375,8 @@ wait_sig (VOID *)
> > *pack.mask = 0;
> > while ((q = q->next))
> > {
> > - if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo)))
> > + _cygtls *sigtls = q->sigtls ?: _main_tls;
> > + if (sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo)))
> > {
> > tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait);
> > if (tl_entry)
> >
> > Can you confirm?
>
> I confirmed that your patch fixes the issue.
>
> This issue can be easily reproduced in my environment by:
> 1) Open two mintty windows.
> 2) Run "while true; do procps; done" in one mintty.
> 3) Build cygwin1.dll in another window.
> Build hangs in a short time and response of procps slows down.
Great. I pushed the patch. The next test relaese
cygwin-3.5.0-0.76.g7c14e5a10add contains this patch.
Thanks,
Corinna
next prev parent reply other threads:[~2023-01-10 10:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 4:59 Brian Inglis
2023-01-02 2:32 ` Takashi Yano
2023-01-02 5:38 ` Takashi Yano
2023-01-02 8:21 ` Takashi Yano
2023-01-09 13:20 ` Corinna Vinschen
2023-01-16 9:02 ` Takashi Yano
2023-01-16 10:23 ` Corinna Vinschen
2023-01-16 14:45 ` Takashi Yano
2023-01-16 15:18 ` Corinna Vinschen
2023-01-16 19:23 ` Brian Inglis
2023-01-16 21:42 ` Corinna Vinschen
2023-01-17 20:46 ` Corinna Vinschen
2023-01-18 9:16 ` Takashi Yano
2023-01-18 9:42 ` Corinna Vinschen
2023-01-19 16:31 ` Brian Inglis
2023-01-19 17:12 ` Brian Inglis
2023-01-19 18:38 ` Corinna Vinschen
2023-01-19 18:42 ` Jose Isaias Cabrera
2023-01-19 19:31 ` Brian Inglis
2023-03-21 19:17 ` Brian Inglis
2023-03-22 19:05 ` Brian Inglis
2023-01-02 23:03 ` Takashi Yano
2023-01-09 16:02 ` Corinna Vinschen
2023-01-09 17:13 ` Corinna Vinschen
2023-01-10 10:01 ` Takashi Yano
2023-01-10 10:57 ` Corinna Vinschen [this message]
2023-01-09 13:36 ` Corinna Vinschen
2023-01-10 0:00 ` Brian Inglis
2023-01-16 15:40 ` Jon Turney
2023-01-16 18:54 ` Brian Inglis
2022-12-31 20:01 Brian Inglis
2023-01-01 18:51 ` Jeremy Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y71ElhBj2unNOxzx@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).