From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by sourceware.org (Postfix) with ESMTPS id 4EF1A3858CDA for ; Mon, 9 Jan 2023 16:02:59 +0000 (GMT) Authentication-Results: sourceware.org; dmarc=permerror header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M3UIe-1pFSZn2z8k-000cU4 for ; Mon, 09 Jan 2023 17:02:57 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id EEF49A80B72; Mon, 9 Jan 2023 17:02:56 +0100 (CET) Date: Mon, 9 Jan 2023 17:02:56 +0100 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls /proc/PID/... Message-ID: Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <4a4427cc-422b-1d14-015e-26523e620d9b@Shaw.ca> <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp> <20230103080350.04a8f6cd63854e0a49f8942d@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230103080350.04a8f6cd63854e0a49f8942d@nifty.ne.jp> X-Provags-ID: V03:K1:5kG3QOcCN99jBmoY6ZSj2nypOiMh877s2ebn2Gxt2MlJzBCZSsy N8FwbgxBlD4UoUjPr/mN9iWoOzJdchJU0gEbr9G30sm9vkECn3tUnFuu8ry649iKz9zBmu/ LdvFeUbmIU4szt9OyJvMX+zrSsViyBgoeqY+ziK0OYzOykerg/IujnLEhEmaM6LipJ7zv15 ZZRRlhFR2RmCfWmqYYPWw== UI-OutboundReport: notjunk:1;M01:P0:VJ0b5icuGZU=;AJw8lG/SVNuY6ZNzBZ1Zx0T5BEG TvM5s4r0cRAU+cC2ATHFrvPKsrvkVGEAVcZ3Do1n2kuaMf0MXmOd9T7QzKp75NODfnsPseN4f z7PUTv5XeYCAizQljR0m5gf/Iwg9+5zFGKlh04n5hA5eg08K91eP2m0aYTaunwiKDYvF6rMrC 4d5F8ApHV02FDHW5xbSKltDPbNp3YmG43/uhSGWnrS+27qc2Pkw3r/hv2CX/DGIdVSplAwR+P Ji0m1tR/eRUvjUP4FzZGcypi//i0CS/ypeDKFDDZjKijrMRwiocOqpMYRmfogQvz4nsRgOrgC NRCDc7HlOw2KMh+KTFW7Wko1tWyp7Kt+LJAdCiH66MhXm7gLx+JQ9A7N4QOfHmEA09WNrNqZ+ VsVl1jsjN35bkpb4cOiLBFIUJVpwJzlAi50kQSX5021TXBIQhrFumlv03031WneV24f6+98a0 T6UXPLu3UrIsxriPYfCQ066Qs7Wp29yXbPYH17j9yw/xUJ3AQbH7AV4R1Lsn/6QeH0rvZ/sMR vl1OvOH8auSx1VZDl0iHXCQm6PAE6tfUndnRpXq4Kk3GPZMtlIMgFig9FNOX9kDVt7RBjT45C GhBtcfJEqJ/+MEGqVQ72qe9aeo01s1TjirMpQW2+GsQQNRb9a6hbsFlsK85CpnQeZp9fuLPCB 7shxOsre87jFL6oIGyVWzOuhUSMYIXzdoWTcS7bJlw== X-Spam-Status: No, score=-96.7 required=5.0 tests=BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_FAIL,SPF_HELO_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 3 08:03, Takashi Yano via Cygwin wrote: > On Mon, 2 Jan 2023 11:32:01 +0900 > Takashi Yano wrote: > > On Thu, 29 Dec 2022 21:59:45 -0700 > > Brian Inglis wrote: > > > I got some hangs (deadlock?) between (parallel?) make jobs, top, procps, and > > > even ls /proc/*/ when trying to cygport all check curl or look at the process > > > statuses when builds hung under Cygwin 3.4.3 and 3.5.0-0.69... > > > [...] > Do we need to guard here as well? > > case __SIGPENDING: > { > unsigned bit; > > *pack.mask = 0; > tl_entry = cygheap->find_tls (pack.sigtls); > while ((q = q->next)) > { > /* Skip thread-specific signals for other threads. */ > if (q->sigtls && pack.sigtls != q->sigtls) > continue; > -------> if (pack.sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) > *pack.mask |= bit; > } > cygheap->unlock_tls (tl_entry); > } > break; I'm not entirely clear what the right action is in terms of this sigtls problem, but no, we don't need a guard in the __SIGPENDING branch. __SIGPENDING is always called with a valid sigtls member in pack, because __SIGPENDING is only called for a specific thread, either from sigpending(2) or from fhandler_signalfd::poll(), which is called via select(2). Corinna