From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by sourceware.org (Postfix) with ESMTPS id 94E7D3858D1E for ; Mon, 9 Jan 2023 17:13:35 +0000 (GMT) Authentication-Results: sourceware.org; dmarc=permerror header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MfpjF-1oZYLe0ff7-00gFLz; Mon, 09 Jan 2023 18:13:27 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id 75603A80B72; Mon, 9 Jan 2023 18:13:26 +0100 (CET) Date: Mon, 9 Jan 2023 18:13:26 +0100 From: Corinna Vinschen To: cygwin@cygwin.com Cc: Takashi Yano Subject: Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls /proc/PID/... Message-ID: Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com, Takashi Yano References: <4a4427cc-422b-1d14-015e-26523e620d9b@Shaw.ca> <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp> X-Provags-ID: V03:K1:NX2XH6Z1x2PYJGwqE/rp2DC4b9OsvPrPAB7AbH0EC9aj9Wk+ZcD PZC9GP9w22UyJaGvqu6XlvGG14DW+bqT/pVdrdP+BzsICknKoe6xfvVt8it/uaNAZ5Mq/PR MvOw9MiWYSL0X7YRoRfzZVnukaFXEbCfmt3rlHsDgZB2RIEhxd7HEYEk9dcsv6fN4JBEdAt gGyL07Wtpx7XI8iJ0k15g== UI-OutboundReport: notjunk:1;M01:P0:qR7dIedXOKU=;+6yc8Umd5SDWaxMiWwblGmgQoG+ bGwNiarLtTpyTRRCcGeBhG0pWPavr8a0hivDRCUdZrubL+bGv57SI8YaikKDdL+yzKJQzXAmO 0TqLc573leGsJO4pgcbmpU9/Lc89P74shyJlQuUsj4NbfK2AZa3gyKdE/Q3oVErmBzVYsH9jS 8DDLD16JDaXff9ZXmhf9qN/SbezcdvYAg77VTujiNBfEAAQrBnsN+4rZTAa133hTC/oV5+5Sq 3sEthre4DC+lFnoD+Y7IcySYUdORp4SbcMg/SzuZOji7aXz2z7gXjnOjZ/NFYhUQ5Nz8faq6d NMPm21kEQ4KU+7m4rJxe9VPai+QkI4qmSGGrgx2U5M3Pa5VrWvS6U/0fRGTBkt4NNnqDEawVQ pqz22IkwyQfVAwn1lZrf/Ns3IGITcDrZP9SGEOypgmHJgx3CmttLsuZZvUlJbtoBTrljvsDNn KsyZdRcakYlyXRtOPLonM7zZmLWsFkb7X9rGlY4LJgd6t79HJfQEIcDIjAeK5H2YyG4MYRUAY jJxxLnMJOy8JPDkJ0UWzcUyOhYxf8+96E5Zh9okzWuboulSY6lCGuNF6Wsgs8+VhT0Le/Tr2z o5hm0JZrAqpKE23/sdjNnx7jOWTKEoaggvLylfKIlxBxabSFLPe04491j23jRQm/zE/vlLOMv SIGJeuiEuXY2UzqxnT9MK/eHqlGtYclS2SpkNPs9mA== X-Spam-Status: No, score=-102.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,GOOD_FROM_CORINNA_CYGWIN,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_FAIL,SPF_HELO_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 2 11:32, Takashi Yano via Cygwin wrote: > On Thu, 29 Dec 2022 21:59:45 -0700 > Brian Inglis wrote: > > I got some hangs (deadlock?) between (parallel?) make jobs, top, procps, and > > even ls /proc/*/ when trying to cygport all check curl or look at the process > > statuses when builds hung under Cygwin 3.4.3 and 3.5.0-0.69... > > [...] > I have looked into this issue a bit, and found that > q->sigtls becomes sometimes NULL and access violation > occurs at the following code. > > winsup/cygwin/sigproc.cc: 1378 > if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) > { > tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait); > > I'm not sure why this happens, however it seems that > the following patch fixes the issue. > > diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc > index ce36c8be3..90eaa2a47 100644 > --- a/winsup/cygwin/sigproc.cc > +++ b/winsup/cygwin/sigproc.cc > @@ -1375,6 +1375,8 @@ wait_sig (VOID *) > *pack.mask = 0; > while ((q = q->next)) > { > + if (q->sigtls == NULL) > + continue; > if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) > { > tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait); > > Corinna, could you please have a look? If q->sigtls is NULL, the signal is nevertheless waiting for being handled. It's just not directed at a specific thread. Beats me, why this didn't occur in my testing. The process signal info should contain the process-wide mask of pending signals as well, obviously, so the following patch should do the right thing: diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc index ce36c8be37fb..86e4e607ab7e 100644 --- a/winsup/cygwin/sigproc.cc +++ b/winsup/cygwin/sigproc.cc @@ -1375,7 +1375,8 @@ wait_sig (VOID *) *pack.mask = 0; while ((q = q->next)) { - if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) + _cygtls *sigtls = q->sigtls ?: _main_tls; + if (sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo))) { tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait); if (tl_entry) Can you confirm? Thanks, Corinna