From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: realpath issue with native[strict] symlinks
Date: Wed, 19 May 2021 14:42:49 +0200 [thread overview]
Message-ID: <YKUHyWcpxMR1s/79@calimero.vinschen.de> (raw)
In-Reply-To: <alpine.BSO.2.21.2105181301130.14962@resin.csoft.net>
On May 18 13:01, Jeremy Drake via Cygwin wrote:
> Sorry ,forgot subject
>
> On Tue, 18 May 2021, Jeremy Drake wrote:
>
> > > Sorry, but there's only this or that, not both. Either we revert the
> > > entire change, including the native shortcut stuff, or we do it
> > > completely and fully, including handling virtual drives as symlinks.
> >
> > I had success with just the following change (of course comments would
> > also need to be updated):
> >
> > diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> > index 4ebaf4dc6..53534b8b6 100644
> > --- a/winsup/cygwin/path.cc
> > +++ b/winsup/cygwin/path.cc
> > @@ -3670,8 +3670,7 @@ restart:
> > somewhere else, thus, it's a symlink in POSIX speak. */
> > if (upath.Length == 14) /* \??\X:\ */
> > {
> > - fileattr &= ~FILE_ATTRIBUTE_DIRECTORY;
> > - path_flags |= PATH_SYMLINK;
> > + goto file_not_symlink;
> > }
> > /* For final paths differing in inner path components return
> > length as negative value. This informs path_conv::check
> >
> > Treating mapped/subst drives as though they were not symlinks, without
> > messing with intermedate symlinks.
It was that simple, surprise, surprise...
I pushed the change under your name.
Thanks,
Corinna
next prev parent reply other threads:[~2021-05-19 12:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 20:01 Jeremy Drake
2021-05-19 12:42 ` Corinna Vinschen [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-27 20:21 Jeremy Drake
2021-05-28 19:23 ` Jeremy Drake
2021-06-08 0:01 ` Jeremy Drake
2021-05-15 4:12 Jeremy Drake
2021-05-17 10:12 ` Corinna Vinschen
2021-04-27 5:44 Orgad Shaneh
2021-05-04 19:52 ` Orgad Shaneh
2021-05-06 17:44 ` Corinna Vinschen
2021-05-06 18:36 ` Orgad Shaneh
2021-05-07 21:20 ` Corinna Vinschen
2021-05-09 11:35 ` Orgad Shaneh
2021-05-10 7:50 ` Corinna Vinschen
2021-05-12 7:10 ` Andrey Repin
2021-05-12 8:14 ` Corinna Vinschen
2021-04-18 7:59 Orgad Shaneh
2021-04-19 12:58 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKUHyWcpxMR1s/79@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).