From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>
Subject: Re: raise(-1) has stopped returning an error recently
Date: Tue, 23 Nov 2021 19:27:23 +1100 [thread overview]
Message-ID: <YZyl69ODRcBVnMed@slk1.local.net> (raw)
In-Reply-To: <YZuVy5+nbzPtiqdw@calimero.vinschen.de>
On Mon, Nov 22, 2021 at 02:06:19PM +0100, cygwin wrote:
> On Nov 22 11:25, Corinna Vinschen via Cygwin wrote:
> > On Nov 22 16:20, Duncan Roe wrote:
> > > Hi,
> > >
> > > I stumbled across this when running 'make check' in the grep source directory.
> > >
> > > test-raise failed when it didn't a few weeks ago.
> >
> > Pretty unlikely. This code didn;'t change for ages. I just checked
> > against Cygwin 3.2.0 and it also returns success.
> >
> > > #include <stdio.h>
> > > #include <signal.h>
> > >
> > > int
> > > main (void)
> > > {
> > > int retcod;
> > >
> > > retcod = raise (-1);
> > > printf("raise(-1) returned %d\n", retcod);
> > > }
> >
> > Thanks for the STC. There are actually two long-standing problems,
> > one in raise, calling pthread_kill even for non-threaded processes,
> > one in pthread_kill, not checking the signal number.
> >
> > I'll patch them right away.
>
> I created a patchset:
> https://sourceware.org/git?p=newlib-cygwin.git;a=commitdiff;h=d54d8f173d66
> https://sourceware.org/git?p=newlib-cygwin.git;a=commitdiff;h=24bffff63eb7
> https://sourceware.org/git?p=newlib-cygwin.git;a=commitdiff;h=afb7c557d2af
>
> Please test the latest developer snapshot from http://cygwin.com/snapshots/
>
>
> Thanks,
> Corinna
Thanks, that fixed it.
Btw to whoever maintains grep for cygwin: 'make check' should pass on
next release (I patched out the surrogate-pair failre).
Cheers ... Duncan.
next prev parent reply other threads:[~2021-11-23 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 5:20 Duncan Roe
2021-11-22 10:25 ` Corinna Vinschen
2021-11-22 13:06 ` Corinna Vinschen
2021-11-23 8:27 ` Duncan Roe [this message]
2021-11-23 9:50 ` Corinna Vinschen
2021-11-23 18:18 ` Brian Inglis
2021-11-23 22:36 ` Duncan Roe
2021-11-24 9:25 ` Corinna Vinschen
2021-11-24 18:01 ` Brian Inglis
2021-11-25 12:54 ` Corinna Vinschen
2021-11-27 7:24 ` Brian Inglis
2021-11-28 3:04 ` Duncan Roe
2021-11-26 23:43 ` Duncan Roe
2021-11-29 10:41 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZyl69ODRcBVnMed@slk1.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).