From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: vboxsharedfs - Too many levels of symbolic links
Date: Wed, 8 Dec 2021 11:37:39 +0100 [thread overview]
Message-ID: <YbCK8/w9KfjB+b/N@calimero.vinschen.de> (raw)
In-Reply-To: <20211208172008.01b11239c374604abf638a19@nifty.ne.jp>
On Dec 8 17:20, Takashi Yano wrote:
> On Tue, 7 Dec 2021 18:15:42 +0100
> Corinna Vinschen wrote:
> > Hi Takashi,
> >
> > ----- Forwarded message from Corinna Vinschen <corinna-cygwin@cygwin.com> -----
> > > The idea of the GFPNBH call is to short-circuit the path_conv handling
> > > in case we have native Windows symlinks in the path. My example above
> > > was only considering what comes out of the `if ((pc_flags & ...) { ... }
> > > ' expression starting in line 3485 (assuming "b" is a native symlink).
> > >
> > > What I mean is this: Your patch disregards the entire string returned by
> > > GFPNBH, if the returned path is an UNC path, no matter what.
> > >
> > > But what if the incoming path already *was* an UNC path, and potentially
> > > contains native symlinks? In that case you have no reason to disregard
> > > the resulting path from GFPNBH.
> > >
> > > And if it was a drive letter path, wouldn't it be nicer to just convert
> > > the UNC path prefix back to the drive letter and keep the rest of the
> > > final path intact?
> > >
> > > However, both of these scenarios require extra code, which isn't that
> > > important for now, so, never mind.
> > ----- End forwarded message -----
> >
> > What I meant is something like the below (entirely untested). Yeah, I'm
> > not sure myself, if it's worth the effort...
> > [...]
> I confirmed that your patch works nicely.
>
> ...except when the drive is created by subst using UNC path,
> e.g. subst w: \\server\share.
>
> In this case, WNetGetConnectionW() fails with ERROR_NO_NET_OR_BAD_PATH.
>
> So, I modified your patch a bit.
>
> What about attached patch?
Oh, great! GetVolumePathNameW is the function I somehow missed when
looking into the Microsoft docs yesterday, so thanks for modifying the
patch this way.
Please push.
Corinna
next prev parent reply other threads:[~2021-12-08 10:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Ya+WvmECA+zAbuV9@calimero.vinschen.de>
2021-12-08 8:20 ` Takashi Yano
2021-12-08 10:37 ` Corinna Vinschen [this message]
2021-12-09 8:16 ` Takashi Yano
2021-12-09 9:16 ` Corinna Vinschen
2021-11-30 17:04 Oskar Skog
2021-11-30 21:40 ` Gackle, Philip P
2021-12-02 10:43 ` Corinna Vinschen
2021-12-05 2:54 ` Takashi Yano
2021-12-05 14:49 ` Oskar Skog
2021-12-06 3:31 ` Takashi Yano
2021-12-06 6:34 ` Oskar Skog
2021-12-06 8:04 ` Takashi Yano
2021-12-06 10:16 ` Corinna Vinschen
2021-12-06 10:55 ` Takashi Yano
2021-12-07 0:46 ` Takashi Yano
2021-12-07 14:57 ` Corinna Vinschen
2021-12-07 15:32 ` Takashi Yano
2021-12-07 15:43 ` Takashi Yano
2021-12-07 16:03 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbCK8/w9KfjB+b/N@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).