From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: ps | cat broken in newlib-cygwin git head (master)
Date: Tue, 17 May 2022 09:38:51 +0200 [thread overview]
Message-ID: <YoNRCx0CiZgbQdY0@calimero.vinschen.de> (raw)
In-Reply-To: <20220517121724.d801487688110f34f2e5d764@nifty.ne.jp>
Hi Takashi,
please send this to the newlib ML, ideally as a reply to the patch or
patchset, CCing Matt and Sebastian.
Thanks,
Corinna
On May 17 12:17, Takashi Yano wrote:
> On Tue, 17 May 2022 04:37:12 +0900
> Takashi Yano wrote:
> > I found that "ps | cat" outputs nothing with the current git head (master)
> > of newlib-cygwin. However, just "ps" and "ls | cat" works.
> >
> > This happens after the commit:
> >
> > commit 26747c47bc0a1137e02e0377306d721cc3478855
> > Author: Matt Joyce <matthew.joyce@embedded-brains.de>
> > Date: Tue May 3 06:51:22 2022 +0200
> >
> > Add stdio_exit_handler()
> >
> > Add a dedicated stdio exit handler to avoid using _GLOBAL_REENT in exit().
> >
> >
> > Is this the problem of cygwin side? Or newlib?
> >
> > I also found "stdbuf -o 0 ps | cat" works. It seems that this problem is
> > caused by buffering of stdout.
>
> I am not sure this is the right thing, however, I found the following
> patch solves the issue. It seems that initializing __stdio_exit_handler
> is missing.
>
> diff --git a/newlib/libc/stdio/findfp.c b/newlib/libc/stdio/findfp.c
> index 19952d4e0..e759b5402 100644
> --- a/newlib/libc/stdio/findfp.c
> +++ b/newlib/libc/stdio/findfp.c
> @@ -63,6 +63,8 @@ struct _glue __sglue = {NULL, 3, &_GLOBAL_REENT->__sf[0]};
> #endif
> #endif
>
> +static void stdio_exit_handler (void);
> +
> #if (defined (__OPTIMIZE_SIZE__) || defined (PREFER_SIZE_OVER_SPEED))
> _NOINLINE_STATIC void
> #else
> @@ -109,6 +111,11 @@ std (FILE *ptr,
> if (__stextmode (ptr->_file))
> ptr->_flags |= __SCLE;
> #endif
> +
> + if (__stdio_exit_handler == NULL) {
> + __sinit (_GLOBAL_REENT);
> + __stdio_exit_handler = stdio_exit_handler;
> + }
> }
>
> static inline void
>
> --
> Takashi Yano <takashi.yano@nifty.ne.jp>
>
> --
> Problem reports: https://cygwin.com/problems.html
> FAQ: https://cygwin.com/faq/
> Documentation: https://cygwin.com/docs.html
> Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
prev parent reply other threads:[~2022-05-17 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 19:37 Takashi Yano
2022-05-17 3:17 ` Takashi Yano
2022-05-17 7:38 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoNRCx0CiZgbQdY0@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).