From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2155)
	id 0F3433858C53; Fri, 25 Aug 2023 09:38:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F3433858C53
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1692956311;
	bh=YNCKxinMMr/U5Uwqz49mjefgLjXQUSIOKKObfG+T4kE=;
	h=Date:From:To:Subject:Reply-To:References:In-Reply-To:From;
	b=jxtOlwwFsVgR1ZZMY4HYbDaFE7jEJsbVYQIyNBnvGpaHSydXIJLEW6Ok5BnRgEVZv
	 1VgAKsAW96EI7PdyaFpChxIZiy2eJhmlu68fusIi/c2f81sIOnWZrf+anyI5scWtz7
	 ZmFPzWbKEVmNm66tA8MidqCiu+bN04qRXYl1WD4U=
Received: by calimero.vinschen.de (Postfix, from userid 500)
	id F0303A80C9A; Fri, 25 Aug 2023 11:38:28 +0200 (CEST)
Date: Fri, 25 Aug 2023 11:38:28 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: can't compile coreutils-9.3 any more after upgrade to
 cygwin-3.4.8
Message-ID: <ZOh2lNSnYAJmZqUh@calimero.vinschen.de>
Reply-To: cygwin@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
References: <83C27059-CB24-48F5-AC91-AB0622DF82CD@Denis-Excoffier.org>
 <aa38a12e-875a-bfaf-6427-2f8d05c0bc47@maxrnd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <aa38a12e-875a-bfaf-6427-2f8d05c0bc47@maxrnd.com>
List-Id: <cygwin.cygwin.com>

On Aug 24 14:39, Mark Geisert via Cygwin wrote:
> Hi Denis,
> 
> Thanks for the report.  More below...
> 
> Denis Excoffier via Cygwin wrote:
> > Hello,
> > When i try to compile coreutils-9.3 under cygwin-3.4.8 i get the following error messages (see below).
> > There seems to be a kind of loop in the hierarchy of #includes.
> > Moreover, with cygwin-3.4.7, this is ok. Also, if under cygwin-3.4.8 i remove the 2 #includes from /usr/include/sys/cpuset.h,
> > this is also ok.
> > 
> > Regards,
> > 
> > Denis Excoffier.
> > 
> > [...]
> > /usr/include/sys/signal.h:227:29: error: expected ')' before 'int'
> >    227 | int pthread_kill (pthread_t, int);
> >        |                             ^~~~
> >        |                             )
> 
> ISTM the above could be fixed by moving "#include <sys/cpuset.h>" after all
> the typedefs in <sys/_pthreadtypes.h>.  That would be an odd location for an
> #include though.  Another approach would be to have explicit external refs
> for the needed two functions in <sys/cpuset.h> and remove the #includes
> there.
> 
> > In file included from /usr/include/sys/stat.h:22,
> >                   from ./lib/sys/stat.h:47,
> >                   from ./lib/fcntl.h:64,
> >                   from ./lib/unistd.h:99,
> >                   from ./lib/stdlib.h:98,
> >                   from /usr/include/sys/cpuset.h:12,
> >                   from /usr/include/sys/_pthreadtypes.h:12,
> >                   from /usr/include/sys/types.h:221,
> >                   from ./lib/sys/types.h:39,
> >                   from ./lib/stdio.h:69,
> >                   from src/chroot.c:21:
> > /usr/include/cygwin/stat.h:27:3: error: unknown type name 'timestruc_t'
> >     27 |   timestruc_t   st_atim;
> >        |   ^~~~~~~~~~~
> > /usr/include/cygwin/stat.h:28:3: error: unknown type name 'timestruc_t'
> >     28 |   timestruc_t   st_mtim;
> >        |   ^~~~~~~~~~~
> > /usr/include/cygwin/stat.h:29:3: error: unknown type name 'timestruc_t'
> >     29 |   timestruc_t   st_ctim;
> >        |   ^~~~~~~~~~~
> > /usr/include/cygwin/stat.h:32:3: error: unknown type name 'timestruc_t'
> >     32 |   timestruc_t   st_birthtim;
> >        |   ^~~~~~~~~~~
> 
> I don't have an answer for these.  Awaiting more input from our wizards.
> I'm willing to submit the patch for any agreed solution.

Usually it's easily fixable. There's typically no loop because
of the guards, e.g.

  #ifndef _SYS_CPUSET_H_
  #define _SYS_CPUSET_H_

but some guarding can have side effects.

However, somebody needs to come up *at least* with a simple reproducer.


Corinna