From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Possiblly bug of cygwin1.dll
Date: Mon, 22 Jan 2024 10:25:28 +0100 [thread overview]
Message-ID: <Za40iEPcedfBSt5n@calimero.vinschen.de> (raw)
In-Reply-To: <20240122123023.b8eaac0e50d1e8856f44a115@nifty.ne.jp>
On Jan 22 12:30, Takashi Yano via Cygwin wrote:
> PATCH2: (for cygwin)
> Avoid handle leak caused when non-static pthread_once_t is initialized
> with PTHREAD_ONCE_INIT
> diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
> index 7bb4f9fc8..127569160 100644
> --- a/winsup/cygwin/thread.cc
> +++ b/winsup/cygwin/thread.cc
> @@ -2060,6 +2060,9 @@ pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
> {
> init_routine ();
> once_control->state = 1;
> + pthread_mutex_unlock (&once_control->mutex);
> + while (pthread_mutex_destroy (&once_control->mutex) == EBUSY);
> + return 0;
> }
> /* Here we must remove our cancellation handler */
> pthread_mutex_unlock (&once_control->mutex);
I see what you're doing here. Wouldn't it be simpler, though, to do this?
diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
index 7bb4f9fc8341..7ec3aace395d 100644
--- a/winsup/cygwin/thread.cc
+++ b/winsup/cygwin/thread.cc
@@ -2063,6 +2063,7 @@ pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
}
/* Here we must remove our cancellation handler */
pthread_mutex_unlock (&once_control->mutex);
+ while (pthread_mutex_destroy (&once_control->mutex) == EBUSY);
return 0;
}
Corinna
next prev parent reply other threads:[~2024-01-22 9:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 13:44 Takashi Yano
2024-01-19 14:28 ` Corinna Vinschen
2024-01-20 4:18 ` Takashi Yano
2024-01-20 5:13 ` Takashi Yano
2024-01-20 9:13 ` ASSI
2024-01-20 12:24 ` Takashi Yano
2024-01-20 12:46 ` ASSI
2024-01-21 11:10 ` Takashi Yano
2024-01-21 13:30 ` ASSI
2024-01-22 3:30 ` Takashi Yano
2024-01-22 9:25 ` Corinna Vinschen [this message]
2024-01-22 9:57 ` Corinna Vinschen
2024-01-22 11:16 ` Takashi Yano
2024-01-22 11:49 ` Corinna Vinschen
2024-01-22 12:41 ` ASSI
2024-01-22 14:54 ` Corinna Vinschen
2024-01-22 11:06 ` Takashi Yano
2024-01-22 11:42 ` Corinna Vinschen
2024-01-23 3:24 ` Kaz Kylheku
2024-01-24 11:55 ` Takashi Yano
2024-01-24 13:05 ` Corinna Vinschen
2024-01-24 13:11 ` Corinna Vinschen
2024-01-24 20:37 ` Kaz Kylheku
2024-01-24 20:08 ` Kaz Kylheku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za40iEPcedfBSt5n@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).