cygport : A[CM]_CONFIG_HEADERS extraction fault

cygport : A[CM]_CONFIG_HEADERS extraction fault

[Marco Atzeri]

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

Hi Yaakov,
building librsb I hit a very unusual AC_CONFIG_HEADERS
definition where the extraction logic implemented in
/usr/share/cygport/cygclass/autotools.cygclass
is failing.

Attached file with examples
------------------------------------------------------
$ grep 'A[CM]_CONFIG_HEADERS*' configure.ac | sed -e 
's!A[CM]_CONFIG_HEADERS*(\[*\(.*\))!\1!g' -e 's!\]*!!g'

config.h:config.in.h

rsb-config.h,[sed 's/^#define /#define RSB_/g;s/ RSB_RSB_/ RSB_/g' 
rsb-config.h > rsb-config.h.tmp ; echo '#endif /* RSB_CONFIG_H_INCLUDED 
*/' >> rsb-config.h.tmp ; cat $srcdir/rsb_license_header.inc 
$srcdir/rsb-config.h.hin rsb-config.h.tmp > rsb-config.h ; rm 
rsb-config.h.tmp
-------------------------------------------------------

The first is from a very standard definition, the second
from the unusual one. I suppose the expected behavior is to catch only
"rsb-config.h" and not all the rest.

No clue how to solve

Regards
Marco


[-- Attachment #2: configure.ac --]
[-- Type: text/plain, Size: 344 bytes --]

AC_CONFIG_HEADERS([config.h:config.in.h])

AC_CONFIG_HEADERS([rsb-config.h],[sed 's/^#define /#define RSB_/g;s/ RSB_RSB_/ RSB_/g' rsb-config.h > rsb-config.h.tmp ; echo '#endif /* RSB_CONFIG_H_INCLUDED */' >> rsb-config.h.tmp ; cat $srcdir/rsb_license_header.inc $srcdir/rsb-config.h.hin rsb-config.h.tmp > rsb-config.h ; rm rsb-config.h.tmp])

[-- Attachment #3: Type: text/plain, Size: 218 bytes --]

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: cygport : A[CM]_CONFIG_HEADERS extraction fault

[Yaakov Selkowitz]

[-- Attachment #1.1: Type: text/plain, Size: 567 bytes --]

On 2016-07-25 12:34, Marco Atzeri wrote:
> building librsb I hit a very unusual AC_CONFIG_HEADERS
> definition where the extraction logic implemented in
> /usr/share/cygport/cygclass/autotools.cygclass
> is failing.
> 
> $ grep 'A[CM]_CONFIG_HEADERS*' configure.ac | sed -e
> 's!A[CM]_CONFIG_HEADERS*(\[*\(.*\))!\1!g' -e 's!\]*!!g'

Sorry for missing this.  Could you please test the following not just on
this package but on others:

grep 'A[CM]_CONFIG_HEADERS*' configure.ac | \
sed -e 's!A[CM]_CONFIG_HEADERS*(\[*\([^],]*\).*)!\1!g'

-- 
Yaakov


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: cygport : A[CM]_CONFIG_HEADERS extraction fault

[Marco Atzeri]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

On 13/02/2018 06:56, Yaakov Selkowitz wrote:
> On 2016-07-25 12:34, Marco Atzeri wrote:
>> building librsb I hit a very unusual AC_CONFIG_HEADERS
>> definition where the extraction logic implemented in
>> /usr/share/cygport/cygclass/autotools.cygclass
>> is failing.
>>
>> $ grep 'A[CM]_CONFIG_HEADERS*' configure.ac | sed -e
>> 's!A[CM]_CONFIG_HEADERS*(\[*\(.*\))!\1!g' -e 's!\]*!!g'
> 
> Sorry for missing this.  Could you please test the following not just on
> this package but on others:
> 
> grep 'A[CM]_CONFIG_HEADERS*' configure.ac | \
> sed -e 's!A[CM]_CONFIG_HEADERS*(\[*\([^],]*\).*)!\1!g'
> 

It took more time to remember where I hit the issue.

https://sourceforge.net/projects/librsb/files/oldrc/librsb-1.2.0-rc4.tar.gz/download

It seems to work, or at least it does not throw anymore an error.

I will continue to use the attached patch for my normal builds.

Regards
Marco



[-- Attachment #2: autotools.cygclass.patch --]
[-- Type: text/plain, Size: 574 bytes --]

--- autotools.cygclass.bk	2018-02-13 09:49:21.751427000 +0100
+++ autotools.cygclass	2018-02-13 10:02:36.667625900 +0100
@@ -547,7 +547,7 @@
 			fi
 
 			auxdir="$(grep '^[^\#]*AC_CONFIG_AUX_DIR' ${sub_configure_ac} | sed -e 's!.*AC_CONFIG_AUX_DIR(\[*\(.*\))!\1!g' -e 's!\]*!!g')"
-			config_h="$(grep 'A[CM]_CONFIG_HEADERS*' ${sub_configure_ac} | sed -e 's!A[CM]_CONFIG_HEADERS*(\[*\(.*\))!\1!g' -e 's!\]*!!g')";
+			config_h="$(grep 'A[CM]_CONFIG_HEADERS*' ${sub_configure_ac} | sed -e 's!A[CM]_CONFIG_HEADERS*(\[*\([^],]*\).*)!\1!g')";
 
 			if defined config_h
 			then

[-- Attachment #3: Type: text/plain, Size: 219 bytes --]


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple