From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90917 invoked by alias); 29 May 2017 11:39:54 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 90909 invoked by uid 89); 29 May 2017 11:39:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1079, treating, 8, announcement X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 May 2017 11:39:52 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF447C057FA4 for ; Mon, 29 May 2017 11:39:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DF447C057FA4 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=eblake@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DF447C057FA4 Received: from [10.10.120.133] (ovpn-120-133.rdu2.redhat.com [10.10.120.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95EDF1714A for ; Mon, 29 May 2017 11:39:54 +0000 (UTC) Subject: Re: grep-3.0-2 issues within Makefile To: cygwin@cygwin.com References: From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Message-ID: Date: Mon, 29 May 2017 12:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kde48HSWN44IV7tp6TwV5lL597Nk9KfWv" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00472.txt.bz2 --kde48HSWN44IV7tp6TwV5lL597Nk9KfWv Content-Type: multipart/mixed; boundary="KlninlhhMJN0mjvNvSWgAJ8fglAeGr3Rb"; protected-headers="v1" From: Eric Blake To: cygwin@cygwin.com Message-ID: Subject: Re: grep-3.0-2 issues within Makefile References: In-Reply-To: --KlninlhhMJN0mjvNvSWgAJ8fglAeGr3Rb Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1070 On 05/29/2017 03:52 AM, Marco Atzeri wrote: > On 29/05/2017 08:34, Daniel Fort wrote: >> grep-3.0-2 binary will not function as expected when the -v option is >> used in a Makefile. >=20 > Please note the last grep announcement > https://sourceware.org/ml/cygwin-announce/2017-02/msg00035.html >=20 > and the changes between text and binary mounts. >=20 >> Using a Cygwin install that includes the default grep-3.0-1 will >> result in errors when running the follow Makefile code: >> >> localsyms: libtcctmp.o >> @$(READELF) $< -Ws | $(AWK) "{print \$$8}" | sort | uniq \ Most likely, $(READELF) is producing \r\n-terminated output. The solution, then, is to rewrite the line to: $(READELF) $< -Ws | tr -d '\r' | $(AWK) ... >=20 > and what is the error ? Most likely, grep is not filtering as expected, because now that it is treating your data as binary rather than text, your explicit $ anchor is only matching \n instead of \r\n. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --KlninlhhMJN0mjvNvSWgAJ8fglAeGr3Rb-- --kde48HSWN44IV7tp6TwV5lL597Nk9KfWv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 604 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJZLAiJAAoJEKeha0olJ0NqNRwH/0uqs1WkE42reqiBej6tXx3i HVHWTosiy73C7TuZwL+W9HHT+3OCRdsLUFzIvzNP2XXdYgtbT0fRAlNW+3D2EKum iNAVQXZKBj1q2uzdkX65ateEa2UexZsJUVhyX5NcBpQhN/jufgpYMZQZ52PR+1G9 hGc+SGTnySbVZnkPA2dceGBYQs5rFAtX9x4LUV/hzfywPq9Pk7ITu4XvcjNAKe36 doVKzBIdqsM1tmysutjNjCzdXqQsw1UJE+H3DIndXwMVdTTYqFUX4O0J+yjoXZzu ftC73lRzMfMfXDPgt2Febu6nJrGXc7S11DzTPxYo1aqJSBrCCY3JaN26j4qanM4= =tvzS -----END PGP SIGNATURE----- --kde48HSWN44IV7tp6TwV5lL597Nk9KfWv--