From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-044.btinternet.com (mailomta31-re.btinternet.com [213.120.69.124]) by sourceware.org (Postfix) with ESMTPS id 5655E384240C for ; Thu, 16 Jul 2020 13:42:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5655E384240C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jon.turney@dronecode.org.uk Received: from re-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.54.6]) by re-prd-fep-044.btinternet.com with ESMTP id <20200716134246.WZQB21348.re-prd-fep-044.btinternet.com@re-prd-rgout-003.btmx-prd.synchronoss.net>; Thu, 16 Jul 2020 14:42:46 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com X-Originating-IP: [31.51.206.31] X-OWM-Source-IP: 31.51.206.31 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggdeikecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthekredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepgfevledvjeffudfhvdehhfdutddthffhffeuvdeuuedtvdfgveeuhfduvefhuddvnecuffhomhgrihhnpegthihgfihinhdrtghomhdpfihikhhiphgvughirgdrohhrghenucfkphepfedurdehuddrvddtiedrfedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurdduuddungdpihhnvghtpeefuddrhedurddvtdeirdefuddpmhgrihhlfhhrohhmpeeojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhequceuqfffjgepkeeukffvoffkoffgpdhrtghpthhtohepoegthihgfihinhestgihghifihhnrdgtohhmqedprhgtphhtthhopeeomhgrrhgtohdrrghtiigvrhhisehgmhgrihhlrdgtohhmqe X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.111] (31.51.206.31) by re-prd-rgout-003.btmx-prd.synchronoss.net (5.8.340) (authenticated as jonturney@btinternet.com) id 5ED9C2FD07334D9D; Thu, 16 Jul 2020 14:42:46 +0100 Subject: Re: Cygwin package search and cygcheck -p urlencoding still broken on new web server To: The Cygwin Mailing List References: <9c03bed5-da26-512c-3c31-ed6cd59f8043@SystematicSw.ab.ca> From: Jon Turney Message-ID: Date: Thu, 16 Jul 2020 14:42:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, BODY_8BITS, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 13:42:49 -0000 On 16/07/2020 08:44, Marco Atzeri via Cygwin wrote: > On 16.07.2020 06:25, Brian Inglis wrote: >> On 2020-07-15 14:13, Marco Atzeri via Cygwin wrote: >>> Problem: I want to search for >>>     libssh/libssh.h >>> Using https://cygwin.com/packages/ >>> If I put the name and press Go the URL is changed in >>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh%2Flibssh.h&arch=x86_64 >>> >>> and the output is >>>     Found 0 matches for libsshx2Flibssh.h >>>                               ^^^ >>> Instead if I modify directly the URL in: >>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh/libssh.h&arch=x86_64 I think that this is an invalid URL, that just happens to work, so it's correct that the link we produce is urlencoded. (See e.g. https://en.wikipedia.org/wiki/Query_string#URL_encoding) >>> Found 3 matches for libssh/libssh.h >>> .... >>> I guess that the current incapability is due to spurious urlencode in >>> cgi-bin2/package-grep.cgi >>> that is modifing the $param_grep >>> echo '
  • '$file' - >>> '$desc'
    • ' >>> Could someone double check my guess ? So it seems the urlencode is correct, but the urldecode isn't working. I've applied a one-character change which appears to fix things. > the git logs says that only Frank and Jon have recently worked on > >    cgi-bin2/package-grep.cgi > > I would like to double check any possible modification before proposing a > patch to change the web server... This was actually fairly easy to reproduce locally, once I realized what was going on: $ export url="libssh%2Flibssh.h" ; printf '%b' "${url//%/\x}" libsshx2Flibssh.h $ export url="libssh%2Flibssh.h" ; printf '%b' "${ur//%/\\x}" libssh/libssh.h