fish-3.5.0-1: /etc/fish/conf.d/cygwin.fish only readable by owner

fish-3.5.0-1: /etc/fish/conf.d/cygwin.fish only readable by owner

[Christian Franke]

The permission of cygwin.fish looks somewhat random (depends on umask 
during build?):

$ tar tvf fish-3.4.1-1.tar.xz etc/defaults/etc/fish/conf.d/cygwin.fish
-rw-r-xr-- ... 1101 2022-04-07 20:34 
etc/defaults/etc/fish/conf.d/cygwin.fish

$ tar tvf fish-3.5.0-1.tar.xz etc/defaults/etc/fish/conf.d/cygwin.fish
-rw------- ... 1101 2022-06-29 17:29 
etc/defaults/etc/fish/conf.d/cygwin.fish



BTW: Easily found during testing of new setup rc 2.920 with etckeeper 
installed:

$ etckeeper vcs log -1
...
     committing changes in /etc after cygwin-setup run

     Packages with configuration changes:
     -fish 3.4.1-1
     +fish 3.5.0-1

     Package changes:
     -fish 3.4.1-1
     +fish 3.5.0-1

$ etckeeper vcs diff --stat HEAD^
  .etckeeper                           | 4 ++--
  defaults/etc/fish/conf.d/cygwin.fish | 0
  fish/conf.d/cygwin.fish              | 0
  setup/installed.db                   | 2 +-
  4 files changed, 3 insertions(+), 3 deletions(-)

$ etckeeper vcs diff HEAD^ .etckeeper
...
-maybe chmod 0754 'defaults/etc/fish/conf.d/cygwin.fish'
+maybe chmod 0600 'defaults/etc/fish/conf.d/cygwin.fish'
...
-maybe chmod 0754 'fish/conf.d/cygwin.fish'
+maybe chmod 0600 'fish/conf.d/cygwin.fish'
...


-- 
Regards,
Christian

Re: fish-3.5.0-1: /etc/fish/conf.d/cygwin.fish only readable by owner

[Andrew Schulman]

> The permission of cygwin.fish looks somewhat random (depends on umask 
> during build?):
> 
> $ tar tvf fish-3.4.1-1.tar.xz etc/defaults/etc/fish/conf.d/cygwin.fish
> -rw-r-xr-- ... 1101 2022-04-07 20:34 
> etc/defaults/etc/fish/conf.d/cygwin.fish
> 
> $ tar tvf fish-3.5.0-1.tar.xz etc/defaults/etc/fish/conf.d/cygwin.fish
> -rw------- ... 1101 2022-06-29 17:29 
> etc/defaults/etc/fish/conf.d/cygwin.fish

Hi Christian. Thanks for reporting this, and sorry for my slow reply. I was
suprprised by this, because I thought setup would set up rational permissions
for us. I've just come to expect that permissions on my Cygwin files get set to
screwy values, and I thought that setup was fixing them up for us.

Anyway I fixed the permissions in version 3.5.1-2, which I just uploaded. Once
you update to that version, please let me know if everything looks okay again.

Andrew

Re: fish-3.5.0-1: /etc/fish/conf.d/cygwin.fish only readable by owner

[Christian Franke]

Andrew Schulman via Cygwin wrote:
>> The permission of cygwin.fish looks somewhat random (depends on umask
>> during build?):
>>
>> $ tar tvf fish-3.4.1-1.tar.xz etc/defaults/etc/fish/conf.d/cygwin.fish
>> -rw-r-xr-- ... 1101 2022-04-07 20:34
>> etc/defaults/etc/fish/conf.d/cygwin.fish
>>
>> $ tar tvf fish-3.5.0-1.tar.xz etc/defaults/etc/fish/conf.d/cygwin.fish
>> -rw------- ... 1101 2022-06-29 17:29
>> etc/defaults/etc/fish/conf.d/cygwin.fish
> Hi Christian. Thanks for reporting this, and sorry for my slow reply. I was
> suprprised by this, because I thought setup would set up rational permissions
> for us. I've just come to expect that permissions on my Cygwin files get set to
> screwy values, and I thought that setup was fixing them up for us.

setup sets the permissions as specified in the tar file.


> Anyway I fixed the permissions in version 3.5.1-2, which I just uploaded. Once
> you update to that version, please let me know if everything looks okay again.

Looks good, permissions are now -rw-r--r--.

-- 
Regards,
Christian