From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45992 invoked by alias); 14 Dec 2017 19:57:22 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 45980 invoked by uid 89); 14 Dec 2017 19:57:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=SHOULD, Greetings, H*f:sk:b06765e, misunderstood X-HELO: limerock03.mail.cornell.edu Received: from limerock03.mail.cornell.edu (HELO limerock03.mail.cornell.edu) (128.84.13.243) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Dec 2017 19:57:18 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id vBEJvGVA012422 for ; Thu, 14 Dec 2017 14:57:16 -0500 Received: from [192.168.0.5] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id vBEJvEsT002921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Thu, 14 Dec 2017 14:57:16 -0500 Subject: Re: setup's response to a "corrupt local copy" To: cygwin@cygwin.com References: <116333312.20171214224616@yandex.ru> From: Ken Brown Message-ID: Date: Thu, 14 Dec 2017 23:34:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <116333312.20171214224616@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00142.txt.bz2 On 12/14/2017 2:46 PM, Andrey Repin wrote: > Greetings, Ken Brown! > >> This is a followup to the discussion started here: > >> https://cygwin.com/ml/cygwin/2017-12/msg00088.html > >> When setup is preparing to download files and it finds a corrupt copy in >> the local cache, it issues a fatal error message telling the user to >> remove the corrupt file and retry. Steven said that setup should >> silently delete the corrupt file, while I argued in favor of the current >> behavior, on the grounds that setup shouldn't be deleting user files if >> it doesn't know where they came from. > > The point being, if this is a "Download" Setup mode, the files are NOT "User" > files, but a local setup cache. And all files therein SHOULD be valid package > archives. > There's of course situations, when setup.ini on server become corrupted or > otherwise out of sync. But being rare, they should not interfere too much. > >> There is a middle ground: setup could query the user. Additionally, as >> suggested by cyg Simple, there could be an option that directs setup to >> silently remove corrupt files. > > Make it mode dependent. > If it's a "download[ and install]" mode, cleanup and redownload. > If redownloaded file still does not match the setup.ini hash or if it's an > "install from local cache" mode, leave file alone for investigation and notify > the user. You've misunderstood the context. The error is only shown in download or download/install mode. And, as I said, it happens when setup is *preparing* to download files and finds a corrupt copy already present in the local cache. In that context, setup has no idea where the file came from. Ken -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple