From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66298 invoked by alias); 8 Feb 2019 12:52:25 -0000 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Received: (qmail 66287 invoked by uid 89); 8 Feb 2019 12:52:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=worker, Hx-languages-length:1942, informed X-HELO: atfriesa01.ssi-schaefer.com Received: from atfriesa01.ssi-schaefer.com (HELO atfriesa01.ssi-schaefer.com) (193.186.16.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Feb 2019 12:52:23 +0000 Received: from samail03.wamas.com (HELO mailhost.salomon.at) ([172.28.33.235]) by atfriesa01.ssi-schaefer.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2019 13:52:22 +0100 Received: from [172.28.53.111] by mailhost.salomon.at with esmtps (UNKNOWN:AES128-SHA:128) (Exim 4.77) (envelope-from ) id 1gs5dk-0003Jo-SC; Fri, 08 Feb 2019 13:52:20 +0100 Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.7 To: cygwin@cygwin.com References: <02da4eeb-fcce-b1bc-e6eb-68ff3ec0cf74@ssi-schaefer.com> <20190207182735.GG13951@calimero.vinschen.de> <8a2f041f-f8f7-6e17-5d97-5a168440009b@ssi-schaefer.com> <20190208113158.GH13951@calimero.vinschen.de> <17e339bb-2115-bf22-7291-04215aab3150@ssi-schaefer.com> <20190208122126.GM13951@calimero.vinschen.de> <20190208122338.GN13951@calimero.vinschen.de> From: Michael Haubenwallner Message-ID: Date: Fri, 08 Feb 2019 12:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190208122338.GN13951@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00070.txt.bz2 On 2/8/19 1:23 PM, Corinna Vinschen wrote: > On Feb 8 13:21, Corinna Vinschen wrote: >> On Feb 8 12:51, Michael Haubenwallner wrote: >>> >>> For now it seems like there's an inconsistency with PIDs: >>> A first process PID 100, receives PID 101 from spawn(), >>> but in the new process getpid() returns 102: >>> >>> $ ./dospawn /bin/bash -c 'echo $$' >>> 12625 >>> waitpid: pid 12624 status 0x0 >> >> Oh, hmm. If you call spawnve, rather than execve, a new child pid >> is generated in spawnve, rather than just keeping the callers pid. >> >> However, apparently the child invents its own pid in pinfo::thisproc >> after being spawned. But actually this should only occur for forked >> processes aore processes started from non-Cygwin parents. > > Does that help, by any chance: > > diff --git a/winsup/cygwin/dcrt0.cc b/winsup/cygwin/dcrt0.cc > index 78506d43de29..0b274287d9f6 100644 > --- a/winsup/cygwin/dcrt0.cc > +++ b/winsup/cygwin/dcrt0.cc > @@ -656,7 +656,7 @@ child_info_spawn::handle_spawn () > !DuplicateHandle (GetCurrentProcess (), moreinfo->myself_pinfo, > GetCurrentProcess (), &h, 0, > FALSE, DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE)) > - h = NULL; > + h = INVALID_HANDLE_VALUE; > > /* Setup our write end of the process pipe. Clear the one in the structure. > The destructor should never be called for this but, it can't hurt to be > diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc > index 445bd35b224e..d10c4fc4580c 100644 > --- a/winsup/cygwin/pinfo.cc > +++ b/winsup/cygwin/pinfo.cc > @@ -62,6 +62,8 @@ pinfo::thisproc (HANDLE h) > cygheap->pid = create_cygwin_pid (); > flags |= PID_NEW; > } > + else if (h == INVALID_HANDLE_VALUE) > + h = NULL; No, because cygheap->pid still is the parent's pid here, not the new child's one. How should the child be informed at all about the new cygpid value generated in parent's child_info_spawn::worker() ? /haubi/ -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple